From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail-wr1-f42.google.com (mail-wr1-f42.google.com [209.85.221.42]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 51E74437879 for ; Mon, 20 Jul 2026 15:41:41 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.221.42 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1784562103; cv=none; b=eq2qyJCJcBdVmsVeG3L4UmeIduCb3jfqFqthcP4SB0vkYzrB685SVxLYcs9A9Ji3r+012BnLdCOF9mtoEmvA2K/iTLEZNVndC/ry84quljCu805NXzLE8bVFQR7XMLCpKvDzupaOfIfNcPE7avkLMnHXe49g1SplHNaopltK2Yc= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1784562103; c=relaxed/simple; bh=bMs/03E/pLT09J4z4UiyyuHjtplBVReDGtgMdQzn3hE=; h=From:Date:Subject:MIME-Version:Content-Type:Message-Id:References: In-Reply-To:To:Cc; b=cN1KNi3fVhyHV64i0Q8GjNwwhjAaRp+AWXWFLJEANckJHCTgmd+MeyVkwpogYjovqimlNwOOyRTHJPqF7x+Qm8xPHZ7mwtYz+GFowaGBDMbIr75ftZUtDzhmg1rO8XhmeXbIgCV+GBbrzEQ1kJJDNJNQTmuUJYZak1c5g1eGAec= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com; spf=pass smtp.mailfrom=gmail.com; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b=VWmMJTpk; arc=none smtp.client-ip=209.85.221.42 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=gmail.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="VWmMJTpk" Received: by mail-wr1-f42.google.com with SMTP id ffacd0b85a97d-472326ca506so7943336f8f.2 for ; Mon, 20 Jul 2026 08:41:41 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20251104; t=1784562099; x=1785166899; darn=vger.kernel.org; h=cc:to:in-reply-to:references:message-id:content-transfer-encoding :content-type:mime-version:subject:date:from:from:to:cc:subject:date :message-id:reply-to:content-type; bh=LYdVSEJYSxlpPRyHCi7r5tN2RJPa+UFv81a3Ufh1joM=; b=VWmMJTpkEKEYTYiEghxZdfOKcSv37ci+3ri1jshAFOVvq8hExThRLCqUNgaC/xubDS KyCTIBH1J3QuXvDwnkASDjvB6e/jocO9NVWJWciFuM8wToWXOjpCfQF7jgiWwb3UP1LZ 6M3sUdBXaOp1mGgXXwuDb3+g0eyLDJHH/GHkjurKMdvFAn6hUjKq7uf0sP8G85nLMLGq ipXQjN+TpEPzEmrKYe2UE+EOdFUkyq6/1x1KlhV2YFKGQPKt5NTYslf8zCu8ibBU8QwN 4RjPrBq1yVGcgr5rXpAfBxi8Ywaf1+WSuANm8od4KSKq0Twr3+OWxcHkTC7N8lsZMlh2 ZfFw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1784562099; x=1785166899; h=cc:to:in-reply-to:references:message-id:content-transfer-encoding :content-type:mime-version:subject:date:from:x-gm-gg :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to :content-type; bh=LYdVSEJYSxlpPRyHCi7r5tN2RJPa+UFv81a3Ufh1joM=; b=Jxh41X9plWRNuoCvpA4vGl5oi0+C1I68gZb5xGJfhJ9e/Qe3fT+ztAvTKOTwx0ObL4 5UijS663yaYCHgFnRGIx9rJYUus6Yo4ShVAQvN0RRkVP9mE6Jfnpsoa6VQBuN9Z3SinP RrXDiNDeQZz9tqXc5WmNZ+Qld51+iGAgUAmUhN0TYipiOzpBdKJfRZHN2bIe2RZ/rN+f TluM8KzDGVCiD/51vyyMHx5fPbvQ/TQaZ1X6EP8x2wcimzMr8WhBuh0A64GFLnfFKMNa r2KsV5YYntpFzzu0Y8wt332T1l+5HnxMJNtO1HYGeeJ5RAf9GNSli2S2DwvzKaVZAQMo U/Zw== X-Forwarded-Encrypted: i=1; AHgh+RoWEYGQpX1I6f6gsz3Md6Gbz6Hs1hSwJTlZ4dWZD53u9UoQT/IB0jbksxkKlVoPwYq0jsYkBiV2rsYG+A0=@vger.kernel.org X-Gm-Message-State: AOJu0Yw0n7wf1H4AprGlgsgXOjkcKls6kxagoPO725C+nvXQB+dbu2sK rt9ZInr2D9agnYlcBT+y2e4USRlPcRyIoLApSLcMDZYFR8yLUf5iERv/ X-Gm-Gg: AR+sD11pziHp5wdpylO/kiTKnfr6/QsgOqr3WEtbgNQQOCPzQhYI4Kyt2BI+BLxYkGZ l+hmO0CKzzpka5nOklECcqJp610X5hdTtG7PqlFwUtKDoVCWudwmnwdvjNfNk9nhZST9PEuYErD SKIWpccz+hydgCAVP0insRSrSLHNz48hrPuJhM6RgKE+324KsFuYKaP6AtqI4p7COb1t8H2aQIl i3hjgKFbwAPzBwluQlx5q8Q+2kbME536NwN8v1TOx1PrIMOraG62sftvsRzU1H588vc3YSW/SYW kd49x9sbNtvSYcL+pYEIOJOP/WQNcud1mBlt3BRmaGzxhroiyG+JPXvktq/ZFnVDg7E9MuDme6X xk0r+UygimYt9B7zmu8yynIBdiLJlPP8BEPU+S/RTF4Ximv3wbDtr9xF5krzlKrDRMPldusgAPf ozxVxt17ZzDA== X-Received: by 2002:a5d:5f91:0:b0:46f:7d90:8121 with SMTP id ffacd0b85a97d-47f62305661mr18563371f8f.14.1784562099337; Mon, 20 Jul 2026 08:41:39 -0700 (PDT) Received: from [127.0.0.2] ([2a01:14:111:ccf0:e9c1:2f80:10a9:c708]) by smtp.gmail.com with ESMTPSA id ffacd0b85a97d-47f67466e09sm32667936f8f.21.2026.07.20.08.41.35 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 20 Jul 2026 08:41:38 -0700 (PDT) From: Diogo Silva Date: Mon, 20 Jul 2026 17:40:46 +0200 Subject: [PATCH v2 14/15] drm/drm_simple: remove deprecated drm_simple_encoder_init function Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: 7bit Message-Id: <20260720-drm_simple_encoder_init-v2-14-5020b630668a@gmail.com> References: <20260720-drm_simple_encoder_init-v2-0-5020b630668a@gmail.com> In-Reply-To: <20260720-drm_simple_encoder_init-v2-0-5020b630668a@gmail.com> To: Jingoo Han , Inki Dae , Seung-Woo Kim , Kyungmin Park , David Airlie , Simona Vetter , Krzysztof Kozlowski , Peter Griffin , Alim Akhtar , Laurent Pinchart , Tomi Valkeinen , Maarten Lankhorst , Maxime Ripard , Thomas Zimmermann , Michal Simek , Thierry Reding , Mikko Perttunen , Jonathan Hunter , Stefan Agner , Alison Wang , Anitha Chrisanthus , David Airlie , Gerd Hoffmann , Dmitry Osipenko , Gurchetan Singh , Chia-I Wu , Jyri Sarha , Liu Ying , Frank Li , Sascha Hauer , Pengutronix Kernel Team , Fabio Estevam , Chun-Kuang Hu , Philipp Zabel , Matthias Brugger , AngeloGioacchino Del Regno , Geert Uytterhoeven , Xinliang Liu , Sumit Semwal , Yongqin Liu , John Stultz , Liviu Dudau , Neil Armstrong , Kevin Hilman , Jerome Brunet , Martin Blumenstingl , Jonathan Corbet , Shuah Khan Cc: dri-devel@lists.freedesktop.org, linux-arm-kernel@lists.infradead.org, linux-samsung-soc@vger.kernel.org, linux-kernel@vger.kernel.org, linux-tegra@vger.kernel.org, virtualization@lists.linux.dev, imx@lists.linux.dev, linux-mediatek@lists.infradead.org, linux-renesas-soc@vger.kernel.org, linux-amlogic@lists.infradead.org, linux-doc@vger.kernel.org, Diogo Silva X-Mailer: b4 0.15.2 The simple KMS helpers are deprecated because they only add an intermediate layer between drivers and atomic modesetting. All driver users of drm_simple_encoder_init() have been converted to drm_encoder_init(). Drop the helper and open-code its remaining internal use in drm_simple_display_pipe_init() to prevent new users. Signed-off-by: Diogo Silva --- drivers/gpu/drm/drm_simple_kms_helper.c | 13 ++----------- include/drm/drm_simple_kms_helper.h | 4 ---- 2 files changed, 2 insertions(+), 15 deletions(-) diff --git a/drivers/gpu/drm/drm_simple_kms_helper.c b/drivers/gpu/drm/drm_simple_kms_helper.c index 8e1d07b9f1e3..7878b9d7d524 100644 --- a/drivers/gpu/drm/drm_simple_kms_helper.c +++ b/drivers/gpu/drm/drm_simple_kms_helper.c @@ -20,16 +20,6 @@ static const struct drm_encoder_funcs drm_simple_encoder_funcs_cleanup = { .destroy = drm_encoder_cleanup, }; -int drm_simple_encoder_init(struct drm_device *dev, - struct drm_encoder *encoder, - int encoder_type) -{ - return drm_encoder_init(dev, encoder, - &drm_simple_encoder_funcs_cleanup, - encoder_type, NULL); -} -EXPORT_SYMBOL(drm_simple_encoder_init); - void *__drmm_simple_encoder_alloc(struct drm_device *dev, size_t size, size_t offset, int encoder_type) { @@ -363,7 +353,8 @@ int drm_simple_display_pipe_init(struct drm_device *dev, return ret; encoder->possible_crtcs = drm_crtc_mask(crtc); - ret = drm_simple_encoder_init(dev, encoder, DRM_MODE_ENCODER_NONE); + ret = drm_encoder_init(dev, encoder, &drm_simple_encoder_funcs_cleanup, + DRM_MODE_ENCODER_NONE, NULL); if (ret || !connector) return ret; diff --git a/include/drm/drm_simple_kms_helper.h b/include/drm/drm_simple_kms_helper.h index cb672ce0e856..c95f86ff355f 100644 --- a/include/drm/drm_simple_kms_helper.h +++ b/include/drm/drm_simple_kms_helper.h @@ -68,10 +68,6 @@ int drm_simple_display_pipe_init(struct drm_device *dev, const uint64_t *format_modifiers, struct drm_connector *connector); -int drm_simple_encoder_init(struct drm_device *dev, - struct drm_encoder *encoder, - int encoder_type); - void *__drmm_simple_encoder_alloc(struct drm_device *dev, size_t size, size_t offset, int encoder_type); -- 2.54.0