From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail-pj1-f42.google.com (mail-pj1-f42.google.com [209.85.216.42]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 484F22C21F1 for ; Mon, 20 Jul 2026 05:26:32 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.216.42 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1784525193; cv=none; b=Lx5yHARK13DzSG3IIuLcTSR96UyzGGCykNP+RHmhjsLq5mRyUDMzVpipWSxOFEhoX3pohbzYCxaKyJ+O0lyz638xsC1c5eonoHbHh8BtnC3er48kUEHV5FL/x043CsxbfAnyW6ZN6ThMEfe6WaIiMS+h87zJiraSXLJ9J5lq/cE= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1784525193; c=relaxed/simple; bh=kn8o9Xny6EkFavYSuEhixgsPPNLSIaJEZjT74JOh/fM=; h=From:To:Cc:Subject:Date:Message-ID:MIME-Version; b=k29/Sr9QPW+b02J6zKlObYq07HfgB2doBDukAGgcXAsPOkDqDaMadYwByqfL99AR32meHvKNtagTpWScXn4Z1f5qri6Wec4v6JtKS4KPLSDnO5x+claX8RfJp8ErLMyH9JIUXTW/UESVGyNgoHYG6sQQMXkiFgNHgPiVS8sMR3c= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com; spf=pass smtp.mailfrom=gmail.com; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b=pvSvlNPi; arc=none smtp.client-ip=209.85.216.42 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=gmail.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="pvSvlNPi" Received: by mail-pj1-f42.google.com with SMTP id 98e67ed59e1d1-382ef647e20so9117593a91.1 for ; Sun, 19 Jul 2026 22:26:32 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20251104; t=1784525192; x=1785129992; darn=vger.kernel.org; h=content-transfer-encoding:mime-version:message-id:date:subject:cc :to:from:from:to:cc:subject:date:message-id:reply-to:content-type; bh=OaLypST4vYbwf1OTn5lOAvWr6BZgnAgmJzuQeo8TE7Y=; b=pvSvlNPiI/rMmKy06Wk+6WWFx4rUs69xcugcICKm9gNCkZ7PB1ZIWBZtZHp7CZz25X EpPwbh4eBRnX0dna3J085sHH3ZCNHqSY3mig1Tz7jjwJk/cxCkdI5sAL7qp1wQ7Om5ZT o+4PMSD8zmXc9BZQZZOI4ODZSLsFWalkEVbKs7feJlrvTY8mpUKAAMS2C9QiAlrud3HZ e1o4UF1RHswDv7mjWoiBeh5iWR2H1fP5xLeVMtspU5I3LFZcpZE0Ui2IWpifB4sn1vBL Gd3MlMQFArlL/GCGbdq2t0TpLNXvVhVcsIbPKC3sq36Rw26XC1zyLuBI3kINb6bJnuUy ILDQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1784525192; x=1785129992; h=content-transfer-encoding:mime-version:message-id:date:subject:cc :to:from:x-gm-gg:x-gm-message-state:from:to:cc:subject:date :message-id:reply-to:content-type; bh=OaLypST4vYbwf1OTn5lOAvWr6BZgnAgmJzuQeo8TE7Y=; b=ACzkU7bD4fSfYbnVIpkoKjVgQpmqBUEnrXV/Rg/Syj1cHSO1esJGmC4gPrprF5zMUp 7sK9wJXk9dnRpRXaARAQaGN3j4TZqFEruKS6+nhWjXCgLit6DFoMgNko6JQXUgrTcRio LTiOFl7ThMa63SzIZia+4YSKgmMCFvp46/G3VY89sW+rnalkWZFzsWDUiO29ufTYff3A RCmxbTE374kCAP9IKf76izrFJkpUVTBhrvwkzkXFTj9Hc1Q711mB8AnNSdPfcX+w3rbp oKobXCJ6kwcuAExwjRHfkQKYbIeFcWq7SKEyX1WyBSfLQlV9h2NMFJD/bZCrdx93Wqtk q9VA== X-Gm-Message-State: AOJu0YyXWzxfE2fMr+7FoLOnF3+4ZkXP14F3ygtYmDDXEi/iZU/TRRww xWxpI5bMYEenZGEpTi5dDs4PCMegzygfWI8j2lSxJJevvLRLALOZ+CiH X-Gm-Gg: AfdE7cmfq3EK15PxaBAZXORKNLqClnsmbAmVAeofxK4FpHrUOdDpJn+V0B+QcXAqrea ajgqRmSfx6GKTtfG1J0t4i5hLxgqSa359GzE1/X0NQ88ErhTfN0wy63oD/Ti1n+AeZvV5xDnS2C 9Pg8q1FcINbGFQWmzXpXSlMy0keFF7sd7ijCRdAV37veqlSalVk0u7zV5/Wl5yIlzJmQ4bV3jyp AfhVG2LoI0/YBt/uE5Hqtbh4aQ/vHwRMiasM9WbE21t4LU1NCujlhZ2E0JXuL58Le8mY7Mf8I2R pZfcwuPQxUvPoKunxEWy19IVE3vxtbJMnCeqpsYerkQ9K0YVlfN833a6YXBzSv8+DUtGGTcsxUg 8ohM0gMbfq3YmbRvmhJXg88kbjyfj8Xufi3Pa0My+99YuY8PZs6iIiUKnqmY74l+quAp0taWxQW C3a2ufIswMkusjZ699qPdSrfAL3vICGdeGxmwc X-Received: by 2002:a17:90b:2f85:b0:381:a766:efc9 with SMTP id 98e67ed59e1d1-38e4b4227b8mr11488380a91.7.1784525191633; Sun, 19 Jul 2026 22:26:31 -0700 (PDT) Received: from phuc-desktop.. ([183.91.15.56]) by smtp.gmail.com with ESMTPSA id 98e67ed59e1d1-38e39e0531asm6973502a91.5.2026.07.19.22.26.29 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Sun, 19 Jul 2026 22:26:31 -0700 (PDT) From: phucduc.bui@gmail.com To: Mark Brown , Liam Girdwood , Jaroslav Kysela , Takashi Iwai , Lars-Peter Clausen Cc: linux-kernel@vger.kernel.org, linux-sound@vger.kernel.org, bui duc phuc Subject: [PATCH v2] ASoC: soc-generic-dmaengine: Handle DMA channel request failures correctly Date: Mon, 20 Jul 2026 12:26:18 +0700 Message-ID: <20260720052618.64849-1-phucduc.bui@gmail.com> X-Mailer: git-send-email 2.43.0 Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: 8bit From: bui duc phuc Currently any dma_request_chan() failure other than -EPROBE_DEFER is silently ignored, since a missing channel is expected for devices that only support one DMA direction. Improve the handling of these failures by: - reporting failures when a configured DMA channel cannot be requested; - failing probe if neither playback nor capture obtains a DMA channel, since the PCM device would be unusable. Devices that legitimately support only one DMA direction continue to work as before. Signed-off-by: bui duc phuc --- Changes in v2: - Update the commit message and title. - Refine DMA channel request failure handling to match the dma_request_chan() implementation. sound/soc/soc-generic-dmaengine-pcm.c | 29 +++++++++++++++++++++++++++ 1 file changed, 29 insertions(+) diff --git a/sound/soc/soc-generic-dmaengine-pcm.c b/sound/soc/soc-generic-dmaengine-pcm.c index 467426d2b5e4..7ed698314573 100644 --- a/sound/soc/soc-generic-dmaengine-pcm.c +++ b/sound/soc/soc-generic-dmaengine-pcm.c @@ -3,6 +3,7 @@ // Copyright (C) 2013, Analog Devices Inc. // Author: Lars-Peter Clausen +#include #include #include #include @@ -395,6 +396,28 @@ static int dmaengine_pcm_request_chan_of(struct dmaengine_pcm *pcm, */ if (PTR_ERR(chan) == -EPROBE_DEFER) return -EPROBE_DEFER; + + bool has_fw_node = dev->of_node || is_acpi_device_node(dev->fwnode); + bool has_legacy_config = config->chan_names[i]; + bool name_exists_in_fw = false; + + if (has_fw_node) + name_exists_in_fw = device_property_match_string(dev, + "dma-names", + name) >= 0; + + if (has_fw_node && name_exists_in_fw) + dev_warn(dev, "DTS/ACPI DMA channel '%s' request failed (%ld)\n", + name, PTR_ERR(chan)); + + if (has_fw_node && !name_exists_in_fw && has_legacy_config) + dev_warn(dev, "DTS/ACPI name '%s' not found, legacy failed (%ld)\n", + name, PTR_ERR(chan)); + + if (!has_fw_node && has_legacy_config) + dev_warn(dev, "Legacy DMA channel '%s' request failed (%ld)\n", + name, PTR_ERR(chan)); + pcm->chan[i] = NULL; } else { pcm->chan[i] = chan; @@ -406,6 +429,12 @@ static int dmaengine_pcm_request_chan_of(struct dmaengine_pcm *pcm, if (pcm->flags & SND_DMAENGINE_PCM_FLAG_HALF_DUPLEX) pcm->chan[1] = pcm->chan[0]; + if (!pcm->chan[0] && + !pcm->chan[1]) { + dev_err(dev, "no DMA channel found for either playback or capture\n"); + return -ENODEV; + } + return 0; } -- 2.43.0