From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail-pj1-f54.google.com (mail-pj1-f54.google.com [209.85.216.54]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id C54533C7DE1 for ; Mon, 20 Jul 2026 07:41:25 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.216.54 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1784533287; cv=none; b=M7tqhqGdxWXuzprsWdIl2rLAbtPGuQvVX4A3QdOcVU1whCbVhtFtUvv5LqMOCYLsTxqmhKduLbnHyX9bLGWMgNGOnCLCUh/oB1j75Gxb8PLhvw74EEb6nqIf0uN4grpU1uTk5u5N0FVVVyNDlBSO8Ue1b8ZTbgUZTUhx4OgRFdE= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1784533287; c=relaxed/simple; bh=+vs1BDGdDM58TuXDdX1LP1xFHTn/ZKSHj4D+LcB/aA8=; h=From:To:Cc:Subject:Date:Message-ID:In-Reply-To:References: MIME-Version; b=VkKLIAcf8y/6Z5lUELgRaM4/+IexJtTSMUQjhyDgBJCVjDeGwLbdwKgSL0SRVBw0BnOM6zuZpMV1XqMSWGJ0fkiFhn7X5avUST2vxfJF1USOFR6A5VlOPvhNmvPPyt5QYFYWXAjhQrVOGqtdB5oxNHXGqEOYZiWxkXtDnBTPF/I= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com; spf=pass smtp.mailfrom=gmail.com; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b=KgR2kzfL; arc=none smtp.client-ip=209.85.216.54 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=gmail.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="KgR2kzfL" Received: by mail-pj1-f54.google.com with SMTP id 98e67ed59e1d1-384c94c9414so5382082a91.3 for ; Mon, 20 Jul 2026 00:41:25 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20251104; t=1784533285; x=1785138085; darn=vger.kernel.org; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to:content-type; bh=BxfhfVFXLPGi+jPTouqRSV9wQYObASU5W++hCoymJqs=; b=KgR2kzfLfeZ9PtV3tlECR58RnnfufgIw+jVxlaOomeXc5T8gmWtNPGu16R1yta1gah qP4+OUm6CWnNyEX/q0qYekkBcc8TCFunQVuHMMsh81mP/xgeI3J0l+E6AFFnzxfl1Qly GKNLSGCO+9MJ8vAFoRmPXSQS3Jz4gp991Sqlj2KF4yI4HC2oEOQINWKjEFANxum6+iBE PaJj0KawcIm12bcybAL8xPU4G19m+7yrRpvNFRrP10ur2geeUlSh3KoL5cox2vINP6rc AnqAr4jAcTy2/cnX/d5IMj14ZkjCKMl3KlzerwFOX4jpBAchC5/12W301Q1X7CvvBraT D+7w== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1784533285; x=1785138085; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-gg:x-gm-message-state:from :to:cc:subject:date:message-id:reply-to:content-type; bh=BxfhfVFXLPGi+jPTouqRSV9wQYObASU5W++hCoymJqs=; b=EFO0Ny4+P9ZqVvWY+3ibtLywCox/YYkGtot6WdXeH90Rk8/FUr8SMtmHQUd54nfmy/ vDy60n6JdwqotjAtfFh9wHWrkRj74owyUC5iBQPO984oRlMtMfyUF5bZUpk+ciB5M9OU /4uRQjc/cj8vK4d3WvJr3nPFqBvUp60KtvlJPWxGN/adyTK9V+jsdeGWZMwRI1eyD2IU lN9jxiEya4tz46zpQzaIqhDYSZ8b8T3zexGlhUQnxiWPOSb2QBmsjJSlvyOKzLtZpCHc 9GxY0q61acJEpFQNFgFjUtNt7uBc3N1fKqNpSOjw2eWJreWwtaryFLI3TClXvDD6riYi 9W/Q== X-Forwarded-Encrypted: i=1; AHgh+Rr9X3PaPeyRFxQvdLJ3SQKpi4aecVil1sJ+ErkTcZZ7eTb4SifNhNbJiwKqhde7A37ZBvDEqlAPLkoamBU=@vger.kernel.org X-Gm-Message-State: AOJu0YwLI4bxEA4Mpus3VZFQhSKGBRjFKHkJa8CtvhAoimapPnyTnIMx hv+g3/Yoc2GLeEQvxteIzdzXM9fEMM0zJNxx/sepBAAL8drmq4qL3AWF X-Gm-Gg: AfdE7cnIXhqA0lanztvynracclM8UFHi3USSjywHVE7Ggh68K90Jc2IiMtS/wN9NVob TFbQ6VxpuFADndkZY86IF3UUhta7rJYBDuCIVp1qjC+xLPRoKf9scVsIk2Ul4UXvTmb6Tsq2yMC WriAXrniCAcRJxpmVe46kpJMnn4l+RD77zqNC1OfzJ02nyW6QCUEvCF2St2wYmPYw5VU4/n1IMp 1UVfM9gy8hNA+zSE+cjzEn2NU9uaR2FFsJbS69LGsBuJ4CQgwBwRsiRj86CEZMhl+dNm6Y3H4U4 3Bxh2TsSxjoI6KbXsux8m2ARR8VIWaJ5DrUB5R24gt3ZYSXYmSrrDratAsrq30DiIb+FGK6opjM p28AZ8q4e8DXUHiW+N0vFU1eHDSlFjZkL349tVwKzdpN45NgJKrMth9YeyoPrEkyUziAdqaXi4H mYTkykAbO3WegWdGku2rR+ZnkKTf1cczocUy+Z X-Received: by 2002:a17:90b:57ee:b0:383:f52b:d616 with SMTP id 98e67ed59e1d1-38e4b40292cmr13847602a91.10.1784533285047; Mon, 20 Jul 2026 00:41:25 -0700 (PDT) Received: from phuc-desktop.. ([183.91.15.56]) by smtp.gmail.com with ESMTPSA id 98e67ed59e1d1-38e60cc2ad5sm470171a91.4.2026.07.20.00.41.21 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 20 Jul 2026 00:41:24 -0700 (PDT) From: phucduc.bui@gmail.com To: Mark Brown , Liam Girdwood , Jaroslav Kysela , Takashi Iwai , Olivier Moysan , Arnaud Pouliquen , Maxime Coquelin , Alexandre Torgue Cc: linux-stm32@st-md-mailman.stormreply.com, linux-kernel@vger.kernel.org, linux-sound@vger.kernel.org, linux-arm-kernel@lists.infradead.org, bui duc phuc Subject: [PATCH 4/4] ASoC: stm: stm32_spdifrx: Drop redundant error messages Date: Mon, 20 Jul 2026 14:40:43 +0700 Message-ID: <20260720074044.87528-5-phucduc.bui@gmail.com> X-Mailer: git-send-email 2.43.0 In-Reply-To: <20260720074044.87528-1-phucduc.bui@gmail.com> References: <20260720074044.87528-1-phucduc.bui@gmail.com> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: 8bit From: bui duc phuc Both devm_request_irq() and snd_dmaengine_pcm_register() already log failures internally. Drop the redundant error messages and return the original errors directly. Signed-off-by: bui duc phuc --- sound/soc/stm/stm32_spdifrx.c | 6 ++---- 1 file changed, 2 insertions(+), 4 deletions(-) diff --git a/sound/soc/stm/stm32_spdifrx.c b/sound/soc/stm/stm32_spdifrx.c index 2f83ca989e68..e0fef47a227e 100644 --- a/sound/soc/stm/stm32_spdifrx.c +++ b/sound/soc/stm/stm32_spdifrx.c @@ -970,10 +970,8 @@ static int stm32_spdifrx_probe(struct platform_device *pdev) ret = devm_request_irq(&pdev->dev, spdifrx->irq, stm32_spdifrx_isr, 0, dev_name(&pdev->dev), spdifrx); - if (ret) { - dev_err(&pdev->dev, "IRQ request returned %d\n", ret); + if (ret) return ret; - } rst = devm_reset_control_get_optional_exclusive(&pdev->dev, NULL); if (IS_ERR(rst)) @@ -987,7 +985,7 @@ static int stm32_spdifrx_probe(struct platform_device *pdev) pcm_config = &stm32_spdifrx_pcm_config; ret = snd_dmaengine_pcm_register(&pdev->dev, pcm_config, 0); if (ret) - return dev_err_probe(&pdev->dev, ret, "PCM DMA register error\n"); + return ret; ret = snd_soc_register_component(&pdev->dev, &stm32_spdifrx_component, -- 2.43.0