From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from out-174.mta0.migadu.com (out-174.mta0.migadu.com [91.218.175.174]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 0155940910A for ; Mon, 20 Jul 2026 12:00:14 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=91.218.175.174 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1784548817; cv=none; b=t40klz8/yeyDn53zqi/9SbpOIR/IihcNjkwyuLbihJg868K2Agz9X8TPiijGk+X4Dt+0RPqlQjhay9rn12cngc5GeFONiw4a2VMqBbzSLCNsIIBsYMiZb3+juUI6XhWR9YASsw7OWRt4PATBXjmStbObvAfiBaf6OpsylznKYBM= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1784548817; c=relaxed/simple; bh=InN9oAB2urhyxfkildtRDiqajOaSB6e5oq4l6p7A+yU=; h=From:To:Cc:Subject:Date:Message-ID:In-Reply-To:References: MIME-Version; b=GEVvBgeUJ57NcSf8dBJ0w0wUw30UEYriIq8I2RCsHKcj/sYsQCT0e7rK4VWB7ahroN72MRgtSONYgyYHQ7p/+ZRvU6mIhY06aVokL2n/CxGRg0cxdEOZCLEvZugcv1+e9yAS0f3kQVfnKg3Kd2qswGjzw/9kMIwycdLWUOrYIjs= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=linux.dev; spf=pass smtp.mailfrom=linux.dev; dkim=pass (1024-bit key) header.d=linux.dev header.i=@linux.dev header.b=Zz/2JB1+; arc=none smtp.client-ip=91.218.175.174 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=linux.dev Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=linux.dev Authentication-Results: smtp.subspace.kernel.org; dkim=pass (1024-bit key) header.d=linux.dev header.i=@linux.dev header.b="Zz/2JB1+" X-Report-Abuse: Please report any abuse attempt to abuse@migadu.com and include these headers. DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linux.dev; s=key1; t=1784548811; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=JfG1ZHcv+rjvAHjyJjxi2sRN0IfFFjf4AjdeqTop9C4=; b=Zz/2JB1+Mjxt6Dns0uYzFOLTpBQzIGJuYWgxQWef6tQ/Sif17tZoTMbnsT31ipbxFQqIC1 by46BgHzKdI49KEy4T6VOcJ9sDDWluNNus+x4SW729AZrSg7ZqMe59h+dIAuyEei/KIDgi jnbZK4lJjvBXGxcY5kNPMkJxf7hndIU= From: Usama Arif To: Rik van Riel Cc: Usama Arif , linux-kernel@vger.kernel.org, Andrew Morton , kernel-team@meta.com, David Hildenbrand , Lorenzo Stoakes , "Liam R. Howlett" , Vlastimil Babka , Mike Rapoport , Suren Baghdasaryan , Michal Hocko , linux-mm@kvack.org, Catalin Marinas , Will Deacon , Masami Hiramatsu , Oleg Nesterov , Peter Zijlstra , Thomas Gleixner , Ingo Molnar , Borislav Petkov , Dave Hansen , x86@kernel.org, "H. Peter Anvin" , Harry Yoo , Jann Horn , Lance Yang , linux-arm-kernel@lists.infradead.org, linux-trace-kernel@vger.kernel.org Subject: Re: [PATCH RFC v3 3/6] mm: rename get_user_page_vma_remote() to get_user_page_lookup_vma() Date: Mon, 20 Jul 2026 05:00:01 -0700 Message-ID: <20260720120002.299101-1-usama.arif@linux.dev> In-Reply-To: <20260717170036.743149-4-riel@surriel.com> References: Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-Migadu-Flow: FLOW_OUT On Fri, 17 Jul 2026 13:00:33 -0400 Rik van Riel wrote: > get_user_page_vma_remote() faults in the page at @addr in a remote mm and > also looks up the VMA that covers it, handing both back to the caller. > > This cleans up the name space for adding a get_user_page_vma() variant nit: s/name space/namespace/ > where the caller already has the vma. > > Assisted-by: Claude:claude-opus-4.8 > Signed-off-by: Rik van Riel > --- > arch/arm64/kernel/mte.c | 2 +- > arch/x86/kernel/uprobes.c | 2 +- > include/linux/mm.h | 2 +- > mm/memory.c | 4 ++-- > mm/rmap.c | 2 +- > 5 files changed, 6 insertions(+), 6 deletions(-) > I think good to add no functional change intended in the patch. Acked-by: Usama Arif > diff --git a/arch/arm64/kernel/mte.c b/arch/arm64/kernel/mte.c > index 1a9aad6ef22a..7a6ecc3d9294 100644 > --- a/arch/arm64/kernel/mte.c > +++ b/arch/arm64/kernel/mte.c > @@ -459,7 +459,7 @@ static int __access_remote_tags(struct mm_struct *mm, unsigned long addr, > struct vm_area_struct *vma; > unsigned long tags, offset; > void *maddr; > - struct page *page = get_user_page_vma_remote(mm, addr, > + struct page *page = get_user_page_lookup_vma(mm, addr, > gup_flags, &vma); > struct folio *folio; > > diff --git a/arch/x86/kernel/uprobes.c b/arch/x86/kernel/uprobes.c > index 3af979fb41d3..329efac0cfb3 100644 > --- a/arch/x86/kernel/uprobes.c > +++ b/arch/x86/kernel/uprobes.c > @@ -1036,7 +1036,7 @@ static int copy_from_vaddr(struct mm_struct *mm, unsigned long vaddr, void *dst, > struct vm_area_struct *vma; > struct page *page; > > - page = get_user_page_vma_remote(mm, vaddr, gup_flags, &vma); > + page = get_user_page_lookup_vma(mm, vaddr, gup_flags, &vma); > if (IS_ERR(page)) > return PTR_ERR(page); > uprobe_copy_from_page(page, vaddr, dst, len); > diff --git a/include/linux/mm.h b/include/linux/mm.h > index 485df9c2dbdd..24ead14b4790 100644 > --- a/include/linux/mm.h > +++ b/include/linux/mm.h > @@ -3238,7 +3238,7 @@ long pin_user_pages_remote(struct mm_struct *mm, > /* > * Retrieves a single page alongside its VMA. Does not support FOLL_NOWAIT. > */ > -static inline struct page *get_user_page_vma_remote(struct mm_struct *mm, > +static inline struct page *get_user_page_lookup_vma(struct mm_struct *mm, > unsigned long addr, > int gup_flags, > struct vm_area_struct **vmap) > diff --git a/mm/memory.c b/mm/memory.c > index ff338c2abe92..3b86eeaf084f 100644 > --- a/mm/memory.c > +++ b/mm/memory.c > @@ -7039,7 +7039,7 @@ static int __access_remote_vm(struct mm_struct *mm, unsigned long addr, > void *maddr; > struct folio *folio; > struct vm_area_struct *vma = NULL; > - struct page *page = get_user_page_vma_remote(mm, addr, > + struct page *page = get_user_page_lookup_vma(mm, addr, > gup_flags, &vma); > > if (IS_ERR(page)) { > @@ -7167,7 +7167,7 @@ static int __copy_remote_vm_str(struct mm_struct *mm, unsigned long addr, > struct page *page; > struct vm_area_struct *vma = NULL; > > - page = get_user_page_vma_remote(mm, addr, gup_flags, &vma); > + page = get_user_page_lookup_vma(mm, addr, gup_flags, &vma); > if (IS_ERR(page)) { > /* > * Treat as a total failure for now until we decide how > diff --git a/mm/rmap.c b/mm/rmap.c > index 1c77d5dc06e9..b36f2e219b8f 100644 > --- a/mm/rmap.c > +++ b/mm/rmap.c > @@ -2838,7 +2838,7 @@ struct page *make_device_exclusive(struct mm_struct *mm, unsigned long addr, > * (non-device-exclusive) PTE and issue a MMU_NOTIFY_EXCLUSIVE. > */ > retry: > - page = get_user_page_vma_remote(mm, addr, > + page = get_user_page_lookup_vma(mm, addr, > FOLL_GET | FOLL_WRITE | FOLL_SPLIT_PMD, > &vma); > if (IS_ERR(page)) > -- > 2.53.0-Meta > >