The Linux Kernel Mailing List
 help / color / mirror / Atom feed
From: Rob Herring <robh@kernel.org>
To: Bhargav Joshi <j.bhargav.u@gmail.com>
Cc: Michael Turquette <mturquette@baylibre.com>,
	Stephen Boyd <sboyd@kernel.org>,
	Brian Masney <bmasney@redhat.com>,
	Krzysztof Kozlowski <krzk+dt@kernel.org>,
	Conor Dooley <conor+dt@kernel.org>,
	Tony Lindgren <tony@atomide.com>, Tero Kristo <kristo@kernel.org>,
	linux-clk@vger.kernel.org, devicetree@vger.kernel.org,
	linux-kernel@vger.kernel.org, goledhruva@gmail.com,
	m-chawdhry@ti.com, daniel.baluta@gmail.com, simona.toaca@nxp.com
Subject: Re: [PATCH] dt-bindings: clock: ti,dm816-fapll-clock: Convert to DT schema
Date: Tue, 21 Jul 2026 08:47:46 -0500	[thread overview]
Message-ID: <20260721134746.GA3401192-robh@kernel.org> (raw)
In-Reply-To: <20260717-ti-fapll-clock-v1-1-1b684cb2543b@gmail.com>

On Fri, Jul 17, 2026 at 11:43:37PM +0530, Bhargav Joshi wrote:
> Convert the Texas Instruments DM816 FAPLL clock binding from plain text
> to YAML DT schema.
> 
> The text documented #clock-cells to be set as 0, while the example and
> existing dt and driver require it to be 1. The schema now strictly
> enforces #clock-cells = <1>.
> 
> Properties clock-indices and clock-output-names are documented in the
> binding and added as required as driver strictly requires it and existing
> dt already use this property.
> 
> Signed-off-by: Bhargav Joshi <j.bhargav.u@gmail.com>
> ---
>  .../devicetree/bindings/clock/ti/fapll.txt         | 31 ----------
>  .../bindings/clock/ti/ti,dm816-fapll-clock.yaml    | 72 ++++++++++++++++++++++
>  2 files changed, 72 insertions(+), 31 deletions(-)


> diff --git a/Documentation/devicetree/bindings/clock/ti/ti,dm816-fapll-clock.yaml b/Documentation/devicetree/bindings/clock/ti/ti,dm816-fapll-clock.yaml
> new file mode 100644
> index 000000000000..9b6b824faa30
> --- /dev/null
> +++ b/Documentation/devicetree/bindings/clock/ti/ti,dm816-fapll-clock.yaml
> @@ -0,0 +1,72 @@
> +# SPDX-License-Identifier: (GPL-2.0-only OR BSD-2-Clause)
> +%YAML 1.2
> +---
> +$id: http://devicetree.org/schemas/clock/ti/ti,dm816-fapll-clock.yaml#
> +$schema: http://devicetree.org/meta-schemas/core.yaml#
> +
> +title: Texas Instruments FAPLL clock
> +
> +maintainers:
> +  - Tony Lindgren <tony@atomide.com>
> +  - Tero Kristo <kristo@kernel.org>
> +
> +description:
> +  This binding uses the common clock binding. It assumes a register-mapped

Drop the first sentence.

> +  FAPLL with usually two selectable input clocks (reference clock and bypass
> +  clock), and one or more child synthesizers.
> +
> +properties:
> +  compatible:
> +    const: ti,dm816-fapll-clock
> +
> +  "#clock-cells":
> +    const: 1
> +
> +  reg:
> +    maxItems: 1
> +
> +  clocks:
> +    items:
> +      - description: phandle for parent clock clk-ref
> +      - description: phandle for parent clock clk-bypass

Drop 'phandle for'

Rob

      reply	other threads:[~2026-07-21 13:47 UTC|newest]

Thread overview: 2+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2026-07-17 18:13 [PATCH] dt-bindings: clock: ti,dm816-fapll-clock: Convert to DT schema Bhargav Joshi
2026-07-21 13:47 ` Rob Herring [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20260721134746.GA3401192-robh@kernel.org \
    --to=robh@kernel.org \
    --cc=bmasney@redhat.com \
    --cc=conor+dt@kernel.org \
    --cc=daniel.baluta@gmail.com \
    --cc=devicetree@vger.kernel.org \
    --cc=goledhruva@gmail.com \
    --cc=j.bhargav.u@gmail.com \
    --cc=kristo@kernel.org \
    --cc=krzk+dt@kernel.org \
    --cc=linux-clk@vger.kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=m-chawdhry@ti.com \
    --cc=mturquette@baylibre.com \
    --cc=sboyd@kernel.org \
    --cc=simona.toaca@nxp.com \
    --cc=tony@atomide.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox