The Linux Kernel Mailing List
 help / color / mirror / Atom feed
From: Rob Herring <robh@kernel.org>
To: Alexandre Belloni <alexandre.belloni@bootlin.com>
Cc: Eduard Bostina <egbostina@gmail.com>,
	Aaro Koskinen <aaro.koskinen@iki.fi>,
	Andreas Kemnade <andreas@kemnade.info>,
	Conor Dooley <conor+dt@kernel.org>,
	devicetree@vger.kernel.org, Kevin Hilman <khilman@baylibre.com>,
	Krzysztof Kozlowski <krzk+dt@kernel.org>,
	linux-kernel@vger.kernel.org, linux-omap@vger.kernel.org,
	linux-rtc@vger.kernel.org, Roger Quadros <rogerq@kernel.org>,
	Tony Lindgren <tony@atomide.com>,
	daniel.baluta@nxp.com, simona.toaca@nxp.com,
	goledhruva@gmail.com, m-chawdhry@ti.com
Subject: Re: [PATCH 1/2] dt-bindings: rtc: Convert TI Palmas RTC to DT schema
Date: Tue, 21 Jul 2026 08:51:13 -0500	[thread overview]
Message-ID: <20260721135113.GA3438134-robh@kernel.org> (raw)
In-Reply-To: <202607191456398730de31@mail.local>

On Sun, Jul 19, 2026 at 04:56:39PM +0200, Alexandre Belloni wrote:
> On 19/07/2026 14:10:07+0000, Eduard Bostina wrote:
> > Convert the Texas Instruments Palmas RTC controller bindings
> > to DT schema.
> > 
> > As part of the conversion, declare 'wakeup-source: true'.
> > This documents the Palmas PMIC's capability to wake the system.
> > 
> > Signed-off-by: Eduard Bostina <egbostina@gmail.com>
> > ---
> >  .../devicetree/bindings/rtc/rtc-palmas.txt    | 32 -----------
> >  .../bindings/rtc/ti,palmas-rtc.yaml           | 57 +++++++++++++++++++
> >  2 files changed, 57 insertions(+), 32 deletions(-)
> >  delete mode 100644 Documentation/devicetree/bindings/rtc/rtc-palmas.txt
> >  create mode 100644 Documentation/devicetree/bindings/rtc/ti,palmas-rtc.yaml
> > 
> > diff --git a/Documentation/devicetree/bindings/rtc/rtc-palmas.txt b/Documentation/devicetree/bindings/rtc/rtc-palmas.txt
> > deleted file mode 100644
> > index c6cf37758a77..000000000000
> > --- a/Documentation/devicetree/bindings/rtc/rtc-palmas.txt
> > +++ /dev/null
> > @@ -1,32 +0,0 @@
> > -Palmas RTC controller bindings
> > -
> > -Required properties:
> > -- compatible:
> > -  - "ti,palmas-rtc" for palma series of the RTC controller
> > -- interrupts: Interrupt number of RTC submodule on device.
> > -
> > -Optional properties:
> > -
> > -- ti,backup-battery-chargeable: The Palmas series device like TPS65913 or
> > -	TPS80036 supports the backup battery for powering the RTC when main
> > -	battery is removed or in very low power state. The backup battery
> > -	can be chargeable or non-chargeable. This flag will tells whether
> > -	battery is chargeable or not. If charging battery then driver can
> > -	enable the charging.
> > -- ti,backup-battery-charge-high-current: Enable high current charging in
> > -	backup battery. Device supports the < 100uA and > 100uA charging.
> > -	The high current will be > 100uA. Absence of this property will
> > -	charge battery to lower current i.e. < 100uA.
> > -
> > -Example:
> > -	palmas: tps65913@58 {
> > -		...
> > -		palmas_rtc: rtc {
> > -			compatible = "ti,palmas-rtc";
> > -			interrupt-parent = <&palmas>;
> > -			interrupts = <8 0>;
> > -			ti,backup-battery-chargeable;
> > -			ti,backup-battery-charge-high-current;
> > -		};
> > -		...
> > -	};
> > diff --git a/Documentation/devicetree/bindings/rtc/ti,palmas-rtc.yaml b/Documentation/devicetree/bindings/rtc/ti,palmas-rtc.yaml
> > new file mode 100644
> > index 000000000000..ac64f0589c84
> > --- /dev/null
> > +++ b/Documentation/devicetree/bindings/rtc/ti,palmas-rtc.yaml
> > @@ -0,0 +1,57 @@
> > +# SPDX-License-Identifier: (GPL-2.0-only OR BSD-2-Clause)
> > +%YAML 1.2
> > +---
> > +$id: http://devicetree.org/schemas/rtc/ti,palmas-rtc.yaml#
> > +$schema: http://devicetree.org/meta-schemas/core.yaml#
> > +
> > +title: Texas Instruments Palmas RTC
> > +
> > +maintainers:
> > +  - Eduard Bostina <egbostina@gmail.com>
> > +
> > +allOf:
> > +  - $ref: /schemas/rtc/rtc.yaml#
> > +
> > +properties:
> > +  compatible:
> > +    const: ti,palmas-rtc
> > +
> > +  interrupts:
> > +    maxItems: 1
> > +
> > +  wakeup-source: true
> > +
> > +  ti,backup-battery-chargeable:
> > +    type: boolean
> > +    description:
> > +      The backup battery can be chargeable or non-chargeable. This flag
> > +      indicates whether the battery is chargeable. If present, the driver
> > +      can enable charging.
> > +
> 
> It would be great to convert to the genric proeprty which is
> aux-voltage-chargeable from rtc.yaml
> 
> > +  ti,backup-battery-charge-high-current:
> > +    type: boolean
> > +    description:
> > +      Enable high current charging in the backup battery.
> > +      Device supports the < 100uA and > 100uA charging. The high current will
> > +      be > 100uA. Absence of this property will charge battery to lower
> > +      current i.e. < 100uA.
> 
> 
> I guess we could make trickle-resistor-ohms fit or get a new generic
> property for this.

Would be nice, but this is an existing binding on old h/w. We're stuck 
with it.

Rob

  reply	other threads:[~2026-07-21 13:51 UTC|newest]

Thread overview: 6+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2026-07-19 14:10 [PATCH 0/2] dt-bindings: rtc: Convert to DT schema Eduard Bostina
2026-07-19 14:10 ` [PATCH 1/2] dt-bindings: rtc: Convert TI Palmas RTC " Eduard Bostina
2026-07-19 14:56   ` Alexandre Belloni
2026-07-21 13:51     ` Rob Herring [this message]
2026-07-21 13:51   ` Rob Herring (Arm)
2026-07-19 14:10 ` [PATCH 2/2] ARM: dts: ti: omap: Fix Palmas RTC node names Eduard Bostina

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20260721135113.GA3438134-robh@kernel.org \
    --to=robh@kernel.org \
    --cc=aaro.koskinen@iki.fi \
    --cc=alexandre.belloni@bootlin.com \
    --cc=andreas@kemnade.info \
    --cc=conor+dt@kernel.org \
    --cc=daniel.baluta@nxp.com \
    --cc=devicetree@vger.kernel.org \
    --cc=egbostina@gmail.com \
    --cc=goledhruva@gmail.com \
    --cc=khilman@baylibre.com \
    --cc=krzk+dt@kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-omap@vger.kernel.org \
    --cc=linux-rtc@vger.kernel.org \
    --cc=m-chawdhry@ti.com \
    --cc=rogerq@kernel.org \
    --cc=simona.toaca@nxp.com \
    --cc=tony@atomide.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox