From: Jakub Kicinski <kuba@kernel.org>
To: Thomas Huth <thuth@redhat.com>, oe-linux-nfc@lists.linux.dev
Cc: Bongsu Jeon <bongsu.jeon@samsung.com>,
netdev@vger.kernel.org, Shuah Khan <shuah@kernel.org>,
linux-kselftest@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH] selftests: nci: Fix wrong size of status variables in nci_dev test
Date: Tue, 21 Jul 2026 13:56:37 -0700 [thread overview]
Message-ID: <20260721135637.56b47743@kernel.org> (raw)
In-Reply-To: <20260710112300.512433-1-thuth@redhat.com>
On Fri, 10 Jul 2026 13:23:00 +0200 Thomas Huth wrote:
> From: Thomas Huth <thuth@redhat.com>
>
> pthread_join() stores the thread's return value (a "void *", i.e.
> 8 bytes on 64 bit computers) into the address of "status", but the
> "status" variable is declared as "int" with only 4 bytes. The extra
> four bytes clobber whatever is adjacent on the stack, which could
> silently corrupt other local variables. Use "intptr_t" to declare
> the "status" variables with the correct size.
>
> Signed-off-by: Thomas Huth <thuth@redhat.com>
This should go via nfc, I just sent a patch to update MAINTAINERS.
prev parent reply other threads:[~2026-07-21 20:56 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-07-10 11:23 [PATCH] selftests: nci: Fix wrong size of status variables in nci_dev test Thomas Huth
2026-07-21 20:56 ` Jakub Kicinski [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20260721135637.56b47743@kernel.org \
--to=kuba@kernel.org \
--cc=bongsu.jeon@samsung.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-kselftest@vger.kernel.org \
--cc=netdev@vger.kernel.org \
--cc=oe-linux-nfc@lists.linux.dev \
--cc=shuah@kernel.org \
--cc=thuth@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox