From: Jakub Kicinski <kuba@kernel.org>
To: Ibrahim Hashimov <security@auditcode.ai>
Cc: alex.aring@gmail.com, miquel.raynal@bootlin.com,
stefan@datenfreihafen.org, linux-wpan@vger.kernel.org,
netdev@vger.kernel.org, linux-kernel@vger.kernel.org,
stable@vger.kernel.org
Subject: Re: [PATCH v2] mac802154: hold an interface reference across the scan worker
Date: Tue, 21 Jul 2026 14:00:37 -0700 [thread overview]
Message-ID: <20260721140037.61bf4635@kernel.org> (raw)
In-Reply-To: <20260717105810.26226-1-security@auditcode.ai>
On Fri, 17 Jul 2026 12:58:09 +0200 Ibrahim Hashimov wrote:
> + /*
> + * sdata->dev is dereferenced below after rcu_read_unlock() and outside
> + * the rtnl, and a concurrent DEL_INTERFACE / PHY teardown can free it
> + * asynchronously from netdev_run_todo(). Pin it with a reference taken
> + * while the RCU read lock is still held, and drop it at every exit.
> + */
> + dev_hold(sdata->dev);
Please use netdev_hold() with a tracker on the stack.
Please don't post new versions in reply to old ones.
prev parent reply other threads:[~2026-07-21 21:00 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-07-10 14:09 [PATCH net] mac802154: hold an interface reference across the scan worker Ibrahim Hashimov
2026-07-17 8:57 ` Miquel Raynal
2026-07-17 10:58 ` [PATCH v2] " Ibrahim Hashimov
2026-07-17 11:37 ` Miquel Raynal
2026-07-21 21:00 ` Jakub Kicinski [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20260721140037.61bf4635@kernel.org \
--to=kuba@kernel.org \
--cc=alex.aring@gmail.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-wpan@vger.kernel.org \
--cc=miquel.raynal@bootlin.com \
--cc=netdev@vger.kernel.org \
--cc=security@auditcode.ai \
--cc=stable@vger.kernel.org \
--cc=stefan@datenfreihafen.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox