The Linux Kernel Mailing List
 help / color / mirror / Atom feed
From: Lance Yang <lance.yang@linux.dev>
To: atomlin@atomlin.com, pmladek@suse.com
Cc: lance.yang@linux.dev, akpm@linux-foundation.org,
	mhiramat@kernel.org, linux-kernel@vger.kernel.org,
	david.laight.linux@gmail.com, neelx@suse.com, sean@ashe.io,
	chjohnst@gmail.com, steve@abita.co, mproche@gmail.com,
	nick.lange@gmail.com
Subject: Re: [PATCH v6] hung_task: Deduplicate identical hang reports using explicit blocker tracking
Date: Wed, 22 Jul 2026 10:10:18 +0800	[thread overview]
Message-ID: <20260722021018.85583-1-lance.yang@linux.dev> (raw)
In-Reply-To: <n3jegf6u5273tbib5smuhbu4uqgc2z533x6bgahqi3bgovljek@ngzutdnen4dv>


On Tue, Jul 21, 2026 at 01:30:34PM -0400, Aaron Tomlin wrote:
>On Tue, Jul 21, 2026 at 03:28:48PM +0200, Petr Mladek wrote:
[...]
>
>> 3. We could prevent printing the same process again and again
>>    by adding "hung_task_reported" into struct task_struct.
>> 
>>    But then we should print some summary about how many hung tasks
>>    were found in the last round at least. So that we know that
>>    the problem persists.
>> 
>>    This should still be rather easy. But I am not sure if it is
>>    worth it.
>> 
>> 4. We could add the filtering of the duplicated backtraces. But
>>    it has to be handled by some helper function.
>> 
>>    It looks like to most complicated part. I would personally skip
>>    it for now. We could always add it later when the above proposed
>>    changes are not enough to tune the kernel.hung_task_warnings
>>    value in the real life.
>
>I do think this is worth doing to prevent the single-line spam if a task
>remains hung for hours, no?

Nope.

TBH, if a task is still stuck hours later, something is already gone
sideways. Seen that play out plenty of times: hung task, soft/hard lockup,
panic, reboot. Hard to call that one-liner spam :)

So yeah, I still think v7 should just go with Petr's two patches. That
should take care of the problems we're trying to solve ;)

@Aaron mind taking those, testing them out, and spinning a v7?

Cheers, Lance

      reply	other threads:[~2026-07-22  2:10 UTC|newest]

Thread overview: 9+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2026-07-19 16:13 [PATCH v6] hung_task: Deduplicate identical hang reports using explicit blocker tracking Aaron Tomlin
2026-07-20  6:02 ` Andrew Morton
2026-07-21  2:00   ` Aaron Tomlin
2026-07-21  5:08 ` Lance Yang
2026-07-21 13:01   ` Aaron Tomlin
2026-07-21 13:28   ` Petr Mladek
2026-07-21 14:35     ` Lance Yang
2026-07-21 17:30     ` Aaron Tomlin
2026-07-22  2:10       ` Lance Yang [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20260722021018.85583-1-lance.yang@linux.dev \
    --to=lance.yang@linux.dev \
    --cc=akpm@linux-foundation.org \
    --cc=atomlin@atomlin.com \
    --cc=chjohnst@gmail.com \
    --cc=david.laight.linux@gmail.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=mhiramat@kernel.org \
    --cc=mproche@gmail.com \
    --cc=neelx@suse.com \
    --cc=nick.lange@gmail.com \
    --cc=pmladek@suse.com \
    --cc=sean@ashe.io \
    --cc=steve@abita.co \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox