From: Eric Biggers <ebiggers@kernel.org>
To: linux-crypto@vger.kernel.org
Cc: linux-kernel@vger.kernel.org, Ard Biesheuvel <ardb@kernel.org>,
"Jason A . Donenfeld" <Jason@zx2c4.com>,
Herbert Xu <herbert@gondor.apana.org.au>,
Eric Biggers <ebiggers@kernel.org>,
kernel test robot <lkp@intel.com>
Subject: [PATCH] lib/crypto: aes-gcm: Fix CRYPTO_LIB_GF128HASH selection
Date: Tue, 21 Jul 2026 19:17:30 -0700 [thread overview]
Message-ID: <20260722021730.16897-1-ebiggers@kernel.org> (raw)
Move the selection of CRYPTO_LIB_GF128HASH from CRYPTO_LIB_AES_GCM to
CRYPTO_LIB_AES to avoid a build error when CRYPTO_LIB_AES=y &&
CRYPTO_LIB_AES_GCM=m. Like the other AES modes, AES-GCM is included in
libaes as an optional feature rather than a dedicated module.
Fixes: 2bbb64399435 ("lib/crypto: aes: Add GCM support")
Reported-by: kernel test robot <lkp@intel.com>
Closes: https://lore.kernel.org/oe-kbuild-all/202607220918.2RL0wGGS-lkp@intel.com/
Signed-off-by: Eric Biggers <ebiggers@kernel.org>
---
lib/crypto/Kconfig | 3 ++-
1 file changed, 2 insertions(+), 1 deletion(-)
diff --git a/lib/crypto/Kconfig b/lib/crypto/Kconfig
index 65a478f69715d..18cc911f79df6 100644
--- a/lib/crypto/Kconfig
+++ b/lib/crypto/Kconfig
@@ -8,6 +8,8 @@ config CRYPTO_LIB_UTILS
config CRYPTO_LIB_AES
tristate
+ # Select dependencies of modes that are part of libaes.
+ select CRYPTO_LIB_GF128HASH if CRYPTO_LIB_AES_GCM != n
select CRYPTO_LIB_UTILS
config CRYPTO_LIB_AES_ARCH
@@ -65,7 +67,6 @@ config CRYPTO_LIB_AES_GCM
tristate
select CRYPTO_LIB_AES
select CRYPTO_LIB_AES_CTR
- select CRYPTO_LIB_GF128HASH
help
The AES-GCM library functions.
base-commit: e4f23159c8d09b6b15d47f2c95e0a3e7c62f52a2
--
2.55.0
next reply other threads:[~2026-07-22 2:20 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-07-22 2:17 Eric Biggers [this message]
2026-07-22 19:04 ` [PATCH] lib/crypto: aes-gcm: Fix CRYPTO_LIB_GF128HASH selection Eric Biggers
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20260722021730.16897-1-ebiggers@kernel.org \
--to=ebiggers@kernel.org \
--cc=Jason@zx2c4.com \
--cc=ardb@kernel.org \
--cc=herbert@gondor.apana.org.au \
--cc=linux-crypto@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=lkp@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox