From: Wake Liu <wakel@google.com>
To: shuah@kernel.org, tglx@kernel.org, mingo@redhat.com
Cc: cmllamas@google.com, andrealmeid@igalia.com,
linux-kselftest@vger.kernel.org, linux-kernel@vger.kernel.org,
peterz@infradead.org, dvhart@infradead.org, dave@stgolabs.net,
Wake Liu <wakel@google.com>
Subject: [PATCH] selftests: futex: Restore support checks for futex2 and priv_hash
Date: Wed, 22 Jul 2026 07:08:01 +0000 [thread overview]
Message-ID: <20260722070801.2057634-1-wakel@google.com> (raw)
Older kernels may not support FUTEX2 syscalls or PR_FUTEX_HASH.
Removing these checks causes false failures when running the tests on
such kernels. Restore the checks so the tests can be gracefully
skipped when the features are not supported.
Signed-off-by: Wake Liu <wakel@google.com>
---
tools/testing/selftests/futex/functional/futex_numa_mpol.c | 2 ++
tools/testing/selftests/futex/functional/futex_priv_hash.c | 2 ++
2 files changed, 4 insertions(+)
diff --git a/tools/testing/selftests/futex/functional/futex_numa_mpol.c b/tools/testing/selftests/futex/functional/futex_numa_mpol.c
index 78c0f7a59e17..d215acf88120 100644
--- a/tools/testing/selftests/futex/functional/futex_numa_mpol.c
+++ b/tools/testing/selftests/futex/functional/futex_numa_mpol.c
@@ -103,6 +103,8 @@ static void __test_futex(void *futex_ptr, int err_value, unsigned int futex_flag
break;
}
if (ret < 0) {
+ if (errno == ENOSYS || (errno == EINVAL && (futex_flags & FUTEX2_NUMA)))
+ ksft_exit_skip("futex2 or FUTEX2_NUMA not supported by kernel\n");
ksft_exit_fail_msg("Failed futex2_wake(%d, 0x%x): %m\n",
to_wake, futex_flags);
}
diff --git a/tools/testing/selftests/futex/functional/futex_priv_hash.c b/tools/testing/selftests/futex/functional/futex_priv_hash.c
index e8079d7c65e8..27c3ea5ff3ed 100644
--- a/tools/testing/selftests/futex/functional/futex_priv_hash.c
+++ b/tools/testing/selftests/futex/functional/futex_priv_hash.c
@@ -145,6 +145,8 @@ TEST(priv_hash)
}
/* First thread, expect to be 0, not yet initialized */
ret = futex_hash_slots_get();
+ if (ret < 0 && errno == EINVAL)
+ ksft_exit_skip("PR_FUTEX_HASH not supported by kernel\n");
if (ret != 0)
ksft_exit_fail_msg("futex_hash_slots_get() failed: %d, %m\n", ret);
--
2.55.0.229.g6434b31f56-goog
next reply other threads:[~2026-07-22 7:08 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-07-22 7:08 Wake Liu [this message]
2026-07-22 15:20 ` [PATCH] selftests: futex: Restore support checks for futex2 and priv_hash André Almeida
2026-07-22 16:51 ` Carlos Llamas
2026-07-23 0:27 ` Wake Liu
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20260722070801.2057634-1-wakel@google.com \
--to=wakel@google.com \
--cc=andrealmeid@igalia.com \
--cc=cmllamas@google.com \
--cc=dave@stgolabs.net \
--cc=dvhart@infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-kselftest@vger.kernel.org \
--cc=mingo@redhat.com \
--cc=peterz@infradead.org \
--cc=shuah@kernel.org \
--cc=tglx@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox