From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail-ed1-f54.google.com (mail-ed1-f54.google.com [209.85.208.54]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 7DE41339391 for ; Wed, 22 Jul 2026 10:23:58 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.208.54 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1784715839; cv=none; b=iDQzW2aeEogADyacRera+fzuttHaKOl+Awifxp45GC1Xld8ky/5RSnlDGqTTbLVg/+VIdh9CmFkeHcvMEX3OF1a7z/FyDZf7s3OGydzA9PVwAMGGsUqV4gKTvlZO+cIWGi+Q47f6EuFqRVUW4sWGZnxeJ5UP/pPtmX6i3t0jGIM= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1784715839; c=relaxed/simple; bh=PjVQTQnquPIyhfa6NQOHnfbMIM85MAEZdQiapatx7IA=; h=From:To:Cc:Subject:Date:Message-Id:In-Reply-To:References; b=B0x0u178CuCBgrie1fZmDv/jsCF7vI9XbqSOZN5OlEQeUkFif9oz9qlS9rPpsqMPx3NcG7ZnESZd6sLtK+pWMAOadbIXDA266SYJ8w8Xi7f/BAZzyudNbKjDLKwUgXei7WTM30vjpcoovLvfbujmvxMv8aMvXYKzTiz876PEBEE= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com; spf=pass smtp.mailfrom=gmail.com; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b=R4dlOFqO; arc=none smtp.client-ip=209.85.208.54 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=gmail.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="R4dlOFqO" Received: by mail-ed1-f54.google.com with SMTP id 4fb4d7f45d1cf-6983d3dae7aso8570475a12.0 for ; Wed, 22 Jul 2026 03:23:58 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20251104; t=1784715837; x=1785320637; darn=vger.kernel.org; h=references:in-reply-to:message-id:date:subject:cc:to:from:from:to :cc:subject:date:message-id:reply-to:content-type; bh=fDyQ43DZ4ayy3UKtGwQz8F5jc04Dh6m9pPwr+FNqfZ0=; b=R4dlOFqOO82Zqxk/mCKXGa7nM3IVveEUJ46ru67ugSs7QMcCWg4A0PU2pTpC7D0HFu lENNretbd2BytaWs+Bx+4mw318D2m+5fZs9y8W73XzI/dOP1xsHmIEOeiJcLZO1SC9j1 7497uB6kKWWY9ajHxkHdBYCEsxpWA4ij4iCb9kzw08u/PbC/cplPwtlXT8idIkQVxpBg kPS6H3X6lo+jGviP1bBIUEzZnSn+iyhtaarGi07i9q2fu7y/6uVbdD+hMS3OMiyUQbYP wrPXBwxi6pQxEdDBSPYTx/xAzJKZKeNjm2e8D4ocfFxL4fSAEeQWU9imSx56FMPXcyxO 0LeA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1784715837; x=1785320637; h=references:in-reply-to:message-id:date:subject:cc:to:from:x-gm-gg :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to :content-type; bh=fDyQ43DZ4ayy3UKtGwQz8F5jc04Dh6m9pPwr+FNqfZ0=; b=OQ48Ay+RoMjtPwo7/S7ODFhAa11UXay9DPJREMgXiUZ69jZ2zrgMlA+/z7xKXk3ZEC kyDJnX7whrgKI33InT+cLIxA+39dqHuSKUZklvMnWGD/nCopZQtNKjpujXE7r9aoJdtB LX4pMVukketR0m2ZRVVYJGt29jETjrLmAUYm2Ppez9yK6QgQGx7+2QWI+sMcgkYbLstF nn3X9SBJ3KMwjJ2jYmqvhrh8JCeNwvthZ3oD5B6regOCLdp+VCJMS9qOQ8Qh2dm25+tm 5DQU38nv88O6BsadM8NP7RouhXrRe7N4uEN1Ej0MYxmLvrZj6oQuX6FM2ZEIEsA/9RXX z89g== X-Forwarded-Encrypted: i=1; AHgh+RpY9zYrbsPGik0YKHdkqBxYGkafpqWTRHczwo4eVqA6ZHygxIiFRYPuRQIWnj0mcajQufpfPy2S3SLSmF4=@vger.kernel.org X-Gm-Message-State: AOJu0YwWkDx+8wXBXNIPs4BZTLA0FEEsWv2RoD0xvYI7Ldqr3s3YLJ4Y aDvj0onlR3JaRcd2y1nlt+L0nGiwYPkweyk33DE7cFcy8kPy9dn6HYTR X-Gm-Gg: AR+sD126NJeTlrWqGtvefrs22FnjqrNFi2cBE5HKEDZaNaCtgbEdXHMjRGw8wLZGdwi 9yMpxQabY9y5tJe2gP6hfsnkSz6pqbCdkF6L8+6xmXZHv7R54v9MpsCr9R1yewOSswR5oQXtMcl b/TcwzBpPMvyOdOB+yX2InHgxKLcmeIbLMG/jBi0W1EnODrU0BoRsn08i3kR211ud6wju967OKG ZsKbijfP7HaE0cQYBezmPmtw5kofn6pAvfVjrx5ip3hynIe6oIoLq9ebOFPHDgBzIiJQExjdTNZ nhEtnFqzy9aYQWTjuIMYqpK+Josp1EuT3/IY3vb42tQnqaoyaMMmpf/hCQLCSwlo3fOgqaNJn0a Bcmz2MLwq9HwgDNwFXwVfEzyNTU/dhWRO9ewfCFl4YCxeUbKhAZOIqZCNnNCvi7Od9PtmHNxtZI X6Nww/MCQCfvMp/lQr3l0gLwL5JtQspA== X-Received: by 2002:a17:907:985:b0:c12:6280:33c9 with SMTP id a640c23a62f3a-c1c310059f5mr143556566b.28.1784715836648; Wed, 22 Jul 2026 03:23:56 -0700 (PDT) Received: from localhost (c-85-228-45-68.bbcust.telenor.se. [85.228.45.68]) by smtp.gmail.com with ESMTPSA id a640c23a62f3a-c1c32f19c57sm82225666b.58.2026.07.22.03.23.55 (version=TLS1_2 cipher=ECDHE-ECDSA-CHACHA20-POLY1305 bits=256/256); Wed, 22 Jul 2026 03:23:55 -0700 (PDT) From: Eli Billauer To: gregkh@linuxfoundation.org Cc: arnd@arndb.de, linux-kernel@vger.kernel.org, Eli Billauer Subject: [PATCH v2 2/7] char: xillybus: Remove duplicate error path code Date: Wed, 22 Jul 2026 12:23:02 +0200 Message-Id: <20260722102307.49090-3-eli.billauer@gmail.com> X-Mailer: git-send-email 2.17.1 In-Reply-To: <20260722102307.49090-1-eli.billauer@gmail.com> References: <20260722102307.49090-1-eli.billauer@gmail.com> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: No need for dedicated code for the error path. The removed dedicated error path code differs only in when the mutex is released, and that makes no difference in this context. Signed-off-by: Eli Billauer --- Notes: No change on v1->v2. drivers/char/xillybus/xillyusb.c | 6 +----- 1 file changed, 1 insertion(+), 5 deletions(-) diff --git a/drivers/char/xillybus/xillyusb.c b/drivers/char/xillybus/xillyusb.c index a28e6416cb01..ab5f9159aa17 100644 --- a/drivers/char/xillybus/xillyusb.c +++ b/drivers/char/xillybus/xillyusb.c @@ -1419,16 +1419,12 @@ static int xillyusb_open(struct inode *inode, struct file *filp) if (filp->f_mode & FMODE_WRITE) chan->open_for_write = 0; +unmutex_fail: mutex_unlock(&chan->lock); kref_put(&xdev->kref, cleanup_dev); return rc; - -unmutex_fail: - kref_put(&xdev->kref, cleanup_dev); - mutex_unlock(&chan->lock); - return rc; } static ssize_t xillyusb_read(struct file *filp, char __user *userbuf, -- 2.34.1