The Linux Kernel Mailing List
 help / color / mirror / Atom feed
From: Jakub Kicinski <kuba@kernel.org>
To: luoqing <l1138897701@163.com>
Cc: marcelo.leitner@gmail.com, lucien.xin@gmail.com,
	davem@davemloft.net, edumazet@google.com, pabeni@redhat.com,
	horms@kernel.org, linux-sctp@vger.kernel.org,
	netdev@vger.kernel.org, linux-kernel@vger.kernel.org,
	luoqing@kylinos.cn
Subject: Re: [PATCH 2/2] sctp: auth: Fix safety issue when skb_clone fails in auth_chunk handling
Date: Wed, 22 Jul 2026 11:38:42 -0700	[thread overview]
Message-ID: <20260722113842.631d51fa@kernel.org> (raw)
In-Reply-To: <20260716065259.872235-2-l1138897701@163.com>

On Thu, 16 Jul 2026 14:52:59 +0800 luoqing wrote:
> When processing AUTH + COOKIE-ECHO packets, if skb_clone fails due to
> memory pressure, chunk->auth_chunk is set to NULL but chunk->auth is
> still set to 1. This causes sctp_auth_chunk_verify to skip the AUTH
> validation (since auth_chunk is NULL), allowing unauthenticated
> COOKIE-ECHO packets to be accepted.

Fixes need Fixes tags; do not send patches in replies to existing
threads.

  reply	other threads:[~2026-07-22 18:38 UTC|newest]

Thread overview: 8+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2026-07-16  6:52 [PATCH 1/2] sctp: socket: Fix uninitialized error on socket shutdown luoqing
2026-07-16  6:52 ` [PATCH 2/2] sctp: auth: Fix safety issue when skb_clone fails in auth_chunk handling luoqing
2026-07-22 18:38   ` Jakub Kicinski [this message]
2026-07-16  7:42 ` [PATCH 1/2] sctp: socket: Fix uninitialized error on socket shutdown Jagielski, Jedrzej
2026-07-17  8:20   ` [PATCH net v3] sctp: socket: remove unused 'err' parameter from sctp_skb_recv_datagram luoqing
2026-07-17 15:10     ` Xin Long
2026-07-17 18:19       ` David Laight
2026-07-20 15:25         ` Xin Long

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20260722113842.631d51fa@kernel.org \
    --to=kuba@kernel.org \
    --cc=davem@davemloft.net \
    --cc=edumazet@google.com \
    --cc=horms@kernel.org \
    --cc=l1138897701@163.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-sctp@vger.kernel.org \
    --cc=lucien.xin@gmail.com \
    --cc=luoqing@kylinos.cn \
    --cc=marcelo.leitner@gmail.com \
    --cc=netdev@vger.kernel.org \
    --cc=pabeni@redhat.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox