From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail-pl1-f182.google.com (mail-pl1-f182.google.com [209.85.214.182]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 96DFA3939B9 for ; Thu, 23 Jul 2026 04:54:11 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.214.182 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1784782459; cv=none; b=nu3SYojrIq5IMqrOH6yY9rNFIWzUNgGCB42eWq7q31qYHlylk0eTyR5zOeoamdGog0QVZcjbWl4zN+qyDeY/PSK1i7MwrhBJ7yWDQW2e74JV/thgI3pEhtSRL519BUfWf9FYTyDrwoz4bNSvfEI+6sAzlxK4x2qMhmvyrlJsmlk= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1784782459; c=relaxed/simple; bh=zFW9Mx0ZXn7hF454QrxJfQtGJ47S/hYdOGWLyBiXIRg=; h=From:To:Cc:Subject:Date:Message-ID:In-Reply-To:References: MIME-Version; b=ouB10q7LwW1DjdgfWqnHA9HqfNTSnPix7AVcl618sWukHyKpkewx3hyuOn4sXfXnJjsNrHKiRykDCrunlH9oK9AkJVxO6Fsu7FRMdEacy7WE9Ii8hv2W+mp0QaKuGAyhRP+qh3h+WVusd5f7UW8CVuqMi4672XGJryGptr3wsb0= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com; spf=pass smtp.mailfrom=gmail.com; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b=QPt8o4oq; arc=none smtp.client-ip=209.85.214.182 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=gmail.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="QPt8o4oq" Received: by mail-pl1-f182.google.com with SMTP id d9443c01a7336-2cad8076b01so3352715ad.2 for ; Wed, 22 Jul 2026 21:54:11 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20251104; t=1784782449; x=1785387249; darn=vger.kernel.org; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to:content-type; bh=Sk8Pesmwy74AH7VxeJg8H8U9dR5/4hjKm/qPKsN7J90=; b=QPt8o4oqzuuKSoa5efoF5HOod045RJLqfKL8Tb3FPQl8W32S6xes/jwnAP1waARGxd 5oXYXOLzia4POVtfUOPy1rhRArgp32Ke+tL+05Ux23O36f75z9RaZM9CtPtNZQZKRY+m krdT7BFtE8SgEztcU6PYAyQcCIChv91fjpRil0FBGOT//HjXlFhwZQeJnf6+MujvZgd8 5VkJgRAUoy918scmJi4vl1wRCFw05/cZL/DbROHW+Hi+PYlr2BIkkn9wHzZ8/CoDcX5p pCJuBM3/5nBb4GRhgfj1Zx7/PobqN7xEd283BjE8O9imwTerbF78/ru+yghkjJUMehbC TplQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1784782449; x=1785387249; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-gg:x-gm-message-state:from :to:cc:subject:date:message-id:reply-to:content-type; bh=Sk8Pesmwy74AH7VxeJg8H8U9dR5/4hjKm/qPKsN7J90=; b=H2yfTO4OKEldQtINVOeh7lVOHxRDbbpehwXY4qifYFllZbm1LAuEZERZmGWiN6s04d /q1LwWTQ3gE0nnxnXynNlgCRfrHyP0037eZj/1rGuG5YFLiVGZJjX8rJj3cZ5x7/YPjD ZpmYDbivV5E2SO2eXhbqgGuJBuN6W4MifQsJag/Hu2Eab71Gkh7TtPTHhnq/gDwBXHi2 bc7cM5RaSAygcDtHSc95749KO2EmOZDslWFCsJklPjhbB7iwiEg6FKe73CUDSghIU8Ch pa+IvYWBH/eZ3b0WC2Me0vfnpZEfeNV9akibG1Fk9SXUK3zaPWTq6F6IQpspTJm6Vou9 ib0w== X-Forwarded-Encrypted: i=1; AHgh+Ro0LaphQCFlUM6oCGpQ46cHKQLm68K3vtn1EuPZ+o7LqiAvbxkCbzy4Pw+9QmGmE2V5nzHITussEsj0HuI=@vger.kernel.org X-Gm-Message-State: AOJu0Yw7UfpwLI99k7go+r8j8d5YSI5efTn6GvItOMSvxJ/O2b0WisvL NqH6He+brRPA3LXZvO9Qhyn8rjLv+HcZX6FQmQ+DNvLkt0XWQFZceHYD X-Gm-Gg: AR+sD114Jr4d8FBsQBgcLZOuwCW59hualiBuvw5voSTviOUhavSSBjZ/7Nya7J0E+Ef +UBduvl1gMuroiMQp0l47zOPNbmZkSVv7YKgJuK4ryBaL+mVBjX6w6A4XEl0SRALY90Sm6fW8uj JjZ2o19WQWx0TQ3Dlvgt7W8NvYpt3tqvb8SY1w6D76u0R2cUYPyFFc0WiE0K8b6zIZL2u05c2YP TOGT7O9EHvzbbkF1Rxrfmrtu1U3GOrVTOdUoXjAgbPbNT6GqaWuLaVwOPMdiR/0zRuPdWxMP2l8 UxxXq3wekYWrKbI93biDpS3X+nuWtqLIuKMBq2bP3gVSRuG+JaFCwfN+rhU6kMbsodAumY4dkL2 bCKxPda+s84WK/09hjb9Kf2jR3M3F/G+hTwsuDtm2iEjtVCJ0C6PQmmwo+H+eBtOy66Kf+I738T Y3XkpvnXF7X06DcFlUXcWSKFV8MpLj+oAnAdID X-Received: by 2002:a17:902:fd8d:b0:2c9:97a7:3289 with SMTP id d9443c01a7336-2cfa752eae6mr19408995ad.43.1784782448675; Wed, 22 Jul 2026 21:54:08 -0700 (PDT) Received: from phuc-desktop.. ([183.91.15.56]) by smtp.gmail.com with ESMTPSA id d9443c01a7336-2cfa57542e0sm7258365ad.67.2026.07.22.21.54.03 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Wed, 22 Jul 2026 21:54:08 -0700 (PDT) From: phucduc.bui@gmail.com To: Mark Brown , Liam Girdwood , Jaroslav Kysela , Takashi Iwai , Lars-Peter Clausen , nuno.sa@analog.com, Shenghao Ding , Kevin Lu Cc: Baojun Xu , Sen Wang , Steven Eckhoff , Srinivas Kandagatla , Kuninori Morimoto , Charles Keepax , Linus Walleij , u.kleine-koenig@baylibre.com, Thorsten Blum , Kees Cook , Chen Ni , Bartosz Golaszewski , Shengjiu Wang , Sebastian Krzyszkowiak , Pengpeng Hou , Richard Fitzgerald , patches@opensource.cirrus.com, linux-kernel@vger.kernel.org, linux-sound@vger.kernel.org, linux-arm-msm@vger.kernel.org, bui duc phuc Subject: [PATCH 03/26] ASoC: codecs: sta32x: Use guard() for mutex locks Date: Thu, 23 Jul 2026 11:53:04 +0700 Message-ID: <20260723045327.28260-4-phucduc.bui@gmail.com> X-Mailer: git-send-email 2.43.0 In-Reply-To: <20260723045327.28260-1-phucduc.bui@gmail.com> References: <20260723045327.28260-1-phucduc.bui@gmail.com> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: 8bit From: bui duc phuc Clean up the code using guard() for mutex locks. Merely code refactoring, and no behavior change. Signed-off-by: bui duc phuc --- sound/soc/codecs/sta32x.c | 21 +++++++++------------ 1 file changed, 9 insertions(+), 12 deletions(-) diff --git a/sound/soc/codecs/sta32x.c b/sound/soc/codecs/sta32x.c index 652c6e3a9e63..d6de739212f9 100644 --- a/sound/soc/codecs/sta32x.c +++ b/sound/soc/codecs/sta32x.c @@ -17,6 +17,7 @@ #include #include #include +#include #include #include #include @@ -269,9 +270,9 @@ static int sta32x_coefficient_get(struct snd_kcontrol *kcontrol, int numcoef = kcontrol->private_value >> 16; int index = kcontrol->private_value & 0xffff; unsigned int cfud, val; - int i, ret = 0; + int i; - mutex_lock(&sta32x->coeff_lock); + guard(mutex)(&sta32x->coeff_lock); /* preserve reserved bits in STA32X_CFUD */ regmap_read(sta32x->regmap, STA32X_CFUD, &cfud); @@ -283,24 +284,20 @@ static int sta32x_coefficient_get(struct snd_kcontrol *kcontrol, regmap_write(sta32x->regmap, STA32X_CFUD, cfud); regmap_write(sta32x->regmap, STA32X_CFADDR2, index); - if (numcoef == 1) { + if (numcoef == 1) regmap_write(sta32x->regmap, STA32X_CFUD, cfud | 0x04); - } else if (numcoef == 5) { + else if (numcoef == 5) regmap_write(sta32x->regmap, STA32X_CFUD, cfud | 0x08); - } else { - ret = -EINVAL; - goto exit_unlock; - } + else + return -EINVAL; + for (i = 0; i < 3 * numcoef; i++) { regmap_read(sta32x->regmap, STA32X_B1CF1 + i, &val); ucontrol->value.bytes.data[i] = val; } -exit_unlock: - mutex_unlock(&sta32x->coeff_lock); - - return ret; + return 0; } static int sta32x_coefficient_put(struct snd_kcontrol *kcontrol, -- 2.43.0