From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail-wm1-f49.google.com (mail-wm1-f49.google.com [209.85.128.49]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 218E23EE1D1 for ; Thu, 23 Jul 2026 21:53:16 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.128.49 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1784843599; cv=none; b=bPN1oa6GGeEp2U4lSCFktjhmr7KxHaQyfd1v38nG4wZ/CG31LHOViQqomJr9RivxqeFHsf5okb7NmSW3jfA9fIoRTvqH7atY0T/Qhykikcjbml91QL+qgPghlEG+YNy580GvqzcJF5EObFsOssY6NMuI1y2CJSQD8knNE5fLiN0= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1784843599; c=relaxed/simple; bh=CE6QbJ0Y4Qn43kigjIDwEp1Wnu9JSb5eRbdolqTw3oU=; h=Date:From:To:Cc:Subject:Message-ID:In-Reply-To:References: MIME-Version:Content-Type; b=uSwctxuIkYNDx0E9/NUimJj2oC9RCbkCWGVyk1FusuSWBt4MR0bv6gRIr/2opkbWdCSFtIV9h9mCwK1cCKRxOipenQOnKOo2MBW4SLQbpIhxJvHg+RQJ5WlDsx7/mWKYkClEY2js2UH6Ar2uB7+kZ57XdS7IH9w1Yn/kpdWyrHA= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com; spf=pass smtp.mailfrom=gmail.com; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b=SYQ7QG4d; arc=none smtp.client-ip=209.85.128.49 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=gmail.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="SYQ7QG4d" Received: by mail-wm1-f49.google.com with SMTP id 5b1f17b1804b1-4954f5e8020so5616435e9.2 for ; Thu, 23 Jul 2026 14:53:16 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20251104; t=1784843594; x=1785448394; darn=vger.kernel.org; h=content-transfer-encoding:content-type:mime-version:references :in-reply-to:message-id:subject:cc:to:from:date:from:to:cc:subject :date:message-id:reply-to:content-type; bh=XR6TYjEYPo/3LPYXPQ83VOvH1XRnBdy8p/CW2F6Qy3s=; b=SYQ7QG4d7lB8DSKFhXSQzW0RW09mQSWKNgmrWq877dcvkVtpXouZaWQVzedTtJu27+ KLbvOsPcl1X/jqg0rDcFwya86nB5/YCz74FoKQHvZW8WUhUNJ1eLvsGjZNMn4+Cu+0s0 cyvvqLBijYYctwnTEVub7H5aaD6aNDxOPpbomV/zMIpVgo8gFSqovhckMYYz+2R8TItf BNFrC8nO9G+S7i3Z62PrUSTkpXkYyHT5Ove1JnsvhlUtrmJtCyao1OEcp+kUbVRDsCxM 0+vCJCZiz3TgmO/D/pQc4pU2y4Wn9Kn2d62+KvXI9Alzoq/9NmY7NDzZLpiE0cZyMIFd dB+w== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1784843594; x=1785448394; h=content-transfer-encoding:content-type:mime-version:references :in-reply-to:message-id:subject:cc:to:from:date:x-gm-gg :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to :content-type; bh=XR6TYjEYPo/3LPYXPQ83VOvH1XRnBdy8p/CW2F6Qy3s=; b=IrmX/3nRXq8Ij3PBi0qP1678cn0AcMTinDsdfN9YC3KcouYnVH+6ERRr1ZRsfq+Zt5 TewlTHk8kfDsNYoCp+jwdxCHaxBM8R6EDHN/Y3Yjv0uaEBfkM9YlPyVLtmtV+rbgVdJj 8P3MPv5UJgD/scX7yzt0un26066D8/NimquK2wmX6RLcZUmQTBH/zIx8ShfShz7Ng9dr LBWF+w8MqK9D1/mDfds81yhJbs/pUtnZH5HBqdkhFN3FPN1jzXKDnT9QLThvtanL95fi 1NeaAnlSVtFxoqbI8aPiF8B0g9FRJ/YWIxmCaAIxCNEfGGg0nZjFw+V/92+f8JheauB1 wpDA== X-Forwarded-Encrypted: i=1; AHgh+RrWV0dix+mVhCgANDrp4DBM7WBbCZOmoRUO6rkQkN97BFGajKpvTyhj1faGX2VcjM+CMSAJmEPFi8IOZ3Y=@vger.kernel.org X-Gm-Message-State: AOJu0YxoXr5mXsH/C7kcN+pJ4MaaNvK1rhqbroAEXRJYrCi9emF6t8DT x8C58DxVhE2o5kN7/wAcR7w36tJwIevDlSDhoGxP2fxhrGqEECyeSYZS X-Gm-Gg: AR+sD11y0p8kngEyGJNcwxEq3AO8a9KZtL3vOyCWRvSb/9d0bFhwuEwY4+oR7ymrMie gqwkVipnGOjNnvk8xxv7p5m3VfOqWh4pUrm8PiggW9uALeO28YEoBbMAjkS7Qc9v49kMttTLZn5 p/b0MjIc02+YqXAF4u4jfrNry7hVI/A5BjHzkN+oDx8r0wVObWxrnaL6Rjs7Ggik23DF5gv+qsK QZDSgOrBAnkNqYQ/chLzrhG6ROZWDvQ0MG7iJ8hDIFqnKAOQ+eQp1LHGunRhi9bLPwabiq5lhsX WzxB4Xjea8xQL4NpUSxRt8YUkS9hdh8GbjzJ9Cn2BGJZSfEbD83yfFwABbZHuohe+g4xix2bh5i RD8dIZz5iNPIQMFxa5KCzMr49tP1w6orjKjSzYkfDQFrdcjk5MVv4xyfZO7vQp623qYiLEBfhQQ i/A1CWCPxLPfa6egAPTL7YkIOXRZ3bdIlhBDjOjDpEh9B2baKSQvZhPPbKSu49RtAm4gPltPfqT EZpYyqcDpvbLHuH5MlntwAX8npdivy80UEodCVm1+IicMNnvm7rroO1EkYcNzIFPR7NOgw36OLF Grzw3qtMVKQgn4Xhp1WP85alVaFL0OrbcBsznaAOh6zXMRjopp+6FvSds7WGbnQqhMaGgdQVFKX aucHnf24Rzpc= X-Received: by 2002:adf:e18f:0:b0:47f:5b52:5579 with SMTP id ffacd0b85a97d-47f8da7f56bmr5423874f8f.18.1784843593827; Thu, 23 Jul 2026 14:53:13 -0700 (PDT) Received: from systembl0wer (ip-86-49-244-181.bb.vodafone.cz. [86.49.244.181]) by smtp.gmail.com with ESMTPSA id ffacd0b85a97d-47f85b9a6d7sm20311407f8f.2.2026.07.23.14.53.13 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Thu, 23 Jul 2026 14:53:13 -0700 (PDT) Date: Thu, 23 Jul 2026 23:53:12 +0200 From: Joshua Crofts To: Adi Nata Cc: jic23@kernel.org, dlechner@baylibre.com, nuno.sa@analog.com, andy@kernel.org, mazziesaccount@gmail.com, email@sirat.me, u.kleine-koenig@baylibre.com, linux-iio@vger.kernel.org, linux-kernel@vger.kernel.org, linux-kernel-mentees@lists.linux.dev Subject: Re: [PATCH] iio: chemical: cleanup codestyle warning Message-ID: <20260723235312.432a895c@systembl0wer> In-Reply-To: <20260723235139.02fdab3f@systembl0wer> References: <20260723161040.20318-1-adinata.softwareengineer@gmail.com> <20260723235139.02fdab3f@systembl0wer> X-Mailer: Claws Mail 4.4.0 (GTK 3.24.52; x86_64-redhat-linux-gnu) Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit On Thu, 23 Jul 2026 23:51:39 +0200 Joshua Crofts wrote: > On Fri, 24 Jul 2026 00:10:38 +0800 > Adi Nata wrote: > > > Reported by checkpatch: > > FILE: drivers/iio/chemical/ccs811.c > > > > WARNING: Prefer __packed over __attribute__((__packed__)) > > +} __attribute__((__packed__)); > > Perhaps a nit, but I'd change the commit title to "prefer __packed" > and the commit message to something like: > > "Change instance of __attribute__((__packed__)) to __packed per > checkpatch.pl warning. > > Other than that: > > Reviewed-by: Joshua Crofts Additionally, you're missing the driver name in the subject/commit message, it should be something like "iio: chemical: ccs811: prefer __packed" -- Kind regards, Joshua Crofts