From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mx0a-0031df01.pphosted.com (mx0a-0031df01.pphosted.com [205.220.168.131]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 768EE360EC5 for ; Thu, 23 Jul 2026 23:07:34 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=205.220.168.131 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1784848055; cv=none; b=Lq3H7h2xTtDI9WsAEIeb2bCJfRxOpAXuqnWYyqUYqzTsb8w+XYGAK2uJ2rhBMbX/ROx98Gb7o08pruhq6Nfey4WarqNmG+b5NkZxQjUFlzGP/69I872tO8MlkKO0awtE2r9IRODhlY7suLb8Gtc0I0r9cM+Nk+5C3Untd8qYMnQ= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1784848055; c=relaxed/simple; bh=W3WAWfwjKm76x5cqeEv1mZOIhGORoHeLMYfdV0IahkU=; h=Date:From:To:Cc:Subject:Message-ID:In-Reply-To:References: MIME-Version:Content-Type; b=qlwHhF/FrO7Ay+JsDE7xGRi79AgnnttIMlk6fCeSGn84Xx6ZOdl1LZsY3MbpdS9p8iRqFhj+0PsszOaI7xpqTm+S8BvdxeSZz9QxcECMyhz/POlSAnTzRWwHt/0gC+0Pix7FrVyWwCbqhR9P6CEeq9w91t4/pJKDYJXJKyWnz7M= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=oss.qualcomm.com; spf=pass smtp.mailfrom=oss.qualcomm.com; dkim=pass (2048-bit key) header.d=qualcomm.com header.i=@qualcomm.com header.b=kKiGqtDv; dkim=pass (2048-bit key) header.d=oss.qualcomm.com header.i=@oss.qualcomm.com header.b=YdRWNh3X; arc=none smtp.client-ip=205.220.168.131 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=oss.qualcomm.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=oss.qualcomm.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=qualcomm.com header.i=@qualcomm.com header.b="kKiGqtDv"; dkim=pass (2048-bit key) header.d=oss.qualcomm.com header.i=@oss.qualcomm.com header.b="YdRWNh3X" Received: from pps.filterd (m0279865.ppops.net [127.0.0.1]) by mx0a-0031df01.pphosted.com (8.18.1.11/8.18.1.11) with ESMTP id 66NLeB751351100 for ; Thu, 23 Jul 2026 23:07:33 GMT DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=qualcomm.com; h= cc:content-transfer-encoding:content-type:date:from:in-reply-to :message-id:mime-version:references:subject:to; s=qcppdkim1; bh= F6JlrUHM8mWHgshlpDOWVeAhgGevmf7PFwXz3+xRVRU=; b=kKiGqtDvGGgIboQZ MoVtMg10Y7Lf8ehuVRwX4UWROBvZVse3QW//NjtRcF+RLxcXF2oTLt85k1D9zMXM wUxa1XtuMIs9BDmojQH1/si4plCQGDI/ERhkvNGYNV4atOgI9OPvGwBun9yD5FwQ wkpfRnB4dGNUx76CtvSYBTz8GzHDdemAgSww7fZ/E+ZCdIU2yQE7ulU8+iNGqCZJ tmdrcbL8Kyoo8RcNYgyOJaRnE+owQTp3Kr3Lpu0JGgCxI0ep4LpbkLiwWWXGuQQf 4FfbrPlP669ZiXrqeOliV74XFpJO+NvUyF9aDLq+8ypmsD+QH3CFAJSIipPlH5fe oV+FZw== Received: from mail-pl1-f199.google.com (mail-pl1-f199.google.com [209.85.214.199]) by mx0a-0031df01.pphosted.com (PPS) with ESMTPS id 4fkqa0950b-1 (version=TLSv1.3 cipher=TLS_AES_128_GCM_SHA256 bits=128 verify=NOT) for ; Thu, 23 Jul 2026 23:07:33 +0000 (GMT) Received: by mail-pl1-f199.google.com with SMTP id d9443c01a7336-2ce7dfd33ffso17782575ad.0 for ; Thu, 23 Jul 2026 16:07:33 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=oss.qualcomm.com; s=google; t=1784848053; x=1785452853; darn=vger.kernel.org; h=content-transfer-encoding:content-type:mime-version:organization :references:in-reply-to:message-id:subject:cc:to:from:date:from:to :cc:subject:date:message-id:reply-to:content-type; bh=F6JlrUHM8mWHgshlpDOWVeAhgGevmf7PFwXz3+xRVRU=; b=YdRWNh3XhkZoi2aBXC7cKFaOhWpATvCEEEBnjv2jf705lZ0z6CfqybDkHLmhtQ/AVv OVx7Sh+zuW5FyhuKLPZkG2mUYzgRv3zHmU/HeGhN/jvEMXZxXjMuS9OCCb3CeSvZVCnL K4Hfn56cEFWdwsNmmJwQhn16NLWDZKCHUvKxTJS6+pdePH/QyvpHRN3dDWr+KFh8FWmT 9xmGVRAZkL3J0gglk8118LAxfE4XBuIZ29t1aTGbgHz8c4LA4WmPxh5fL7qS4O5O6YNj kwi2K4vbxsJpQiKTvgVKRIRvaWMIb9Xs/uLeF2zOxdr1ABPVHsaAx4V+GW3uKJ4Un90E T8HQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1784848053; x=1785452853; h=content-transfer-encoding:content-type:mime-version:organization :references:in-reply-to:message-id:subject:cc:to:from:date:x-gm-gg :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to :content-type; bh=F6JlrUHM8mWHgshlpDOWVeAhgGevmf7PFwXz3+xRVRU=; b=WT9T/LleF6iKD4iTbNE2V6ayDYNyszhqg37Lp6MiWZ1+BqZvT9X6gGLK7Au5/+e0ez lLr0aGKxROhVqZNkAohYYuK5mXAk2Mce52nJ3/T72eDYEWW3ShSHJEygLk67VXTfdK8+ +ru8d5TwaNI8YVevaVu/pleEFBAiGDdQHTBTQkFnlJRy1MfyphibwuR5d8rJzc7fhbqs E7vaEe4wnuzlAzExYBkfdChbPJVuy2oau+eUiUJ5fYyW1zFCbpVZDRzE963grffiQ1Zl zIun0AXynJ4NeTFGD6wtiYlKJZtOW1DgpvBg9Ol8zKD90lUsTuC8Y4Osh7sWDWH0Ab95 UPTg== X-Forwarded-Encrypted: i=1; AHgh+RoioULvydT75W0HRAXBAJ7RXQI20e5RzIYLpcY2QZ5JTpEAjnyzoeziZKUp1BLUbewTsK7rBr5sio68hTc=@vger.kernel.org X-Gm-Message-State: AOJu0YwR/L9u/cvtRNXuBt9cow8d4F304U7G1v1TDruZ2Rq9gOnmoT3T MzKGBj0weI+HcbPSeKiANhUNrgijMlg3ecmGDnJO7bDkCNxloLslhodxSzvBB7k84UNzg05Acvl FqTN5vVj4am8ZGTSrQINl7/2q0/2LZLBcTKVCJbVkDAsml6ECvRyDT5KTKmQLyVSpaJc= X-Gm-Gg: AR+sD107jdh5aH8qRERDJPYH30/rUo2nXuSGvY9O5odUMHX2yyzDY+0R/XMW3uwMY63 9g1xMWUFgjB7aje+VOmtdxsyp0me4amw0DBlo/n5SFMH9H99+JGMwhf14sYMaCD1z2LedcVnnXE xrTi0ScxNpdEqeCljV0gIoxVJmK592Kd6r+Q1rwFR0pe6KYv9sYCqPjfAeAx3tcmJ+JHdB0Aj/v 6yu3kIYlTn67N5aA8q2VkwdQzwPeVhzVSGB27rB4jdrZCDSIP3uvJe/iBhqBNhl96F+V02aZHeO dUpUq/cM4zt9jTlDQCDJa02El89jkWH1LPn1i4pww7TzW+FP3tZz+rALVg0BY5Bu6QqPP6U5wRG 6SOoHDmBA/KfBqR9d X-Received: by 2002:a17:903:22cc:b0:2ca:caa5:9c04 with SMTP id d9443c01a7336-2cfa74e3bb7mr62120045ad.23.1784848053049; Thu, 23 Jul 2026 16:07:33 -0700 (PDT) X-Received: by 2002:a17:903:22cc:b0:2ca:caa5:9c04 with SMTP id d9443c01a7336-2cfa74e3bb7mr62119695ad.23.1784848052651; Thu, 23 Jul 2026 16:07:32 -0700 (PDT) Received: from jic23-huawei ([50.35.46.84]) by smtp.gmail.com with ESMTPSA id d9443c01a7336-2cf8f3be1ddsm41205935ad.84.2026.07.23.16.07.30 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Thu, 23 Jul 2026 16:07:32 -0700 (PDT) Date: Fri, 24 Jul 2026 00:07:26 +0100 From: Jonathan Cameron To: Rodrigo Alencar <455.rodrigo.alencar@gmail.com> Cc: Rodrigo Alencar via B4 Relay , Michael Auchter , linux@analog.com, linux-iio@vger.kernel.org, devicetree@vger.kernel.org, linux-kernel@vger.kernel.org, Michael Hennerich , David Lechner , Andy Shevchenko , Rob Herring , Krzysztof Kozlowski , Conor Dooley Subject: Re: [PATCH 3/4] iio: dac: ad5686: extend device support with new parts Message-ID: <20260724000726.6810f531@jic23-huawei> In-Reply-To: References: <20260719-ad5686-extend-dev-support-v1-0-841ec75cf5d8@analog.com> <20260719-ad5686-extend-dev-support-v1-3-841ec75cf5d8@analog.com> <20260719224351.1af8aef9@jic23-huawei> Organization: Qualcomm X-Mailer: Claws Mail 4.4.0 (GTK 3.24.52; x86_64-pc-linux-gnu) Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit X-Proofpoint-ORIG-GUID: NRjQ0GwQ3EHF5EvJSL0J2E0_p2UihR7Q X-Proofpoint-GUID: NRjQ0GwQ3EHF5EvJSL0J2E0_p2UihR7Q X-Authority-Analysis: v=2.4 cv=e/k2j6p/ c=1 sm=1 tr=0 ts=6a629eb5 cx=c_pps a=JL+w9abYAAE89/QcEU+0QA==:117 a=qC1CW/w66vtJz1P9yTJxNA==:17 a=kj9zAlcOel0A:10 a=RAioF0-LDSMA:10 a=s4-Qcg_JpJYA:10 a=VkNPw1HP01LnGYTKEx00:22 a=u7WPNUs3qKkmUXheDGA7:22 a=Um2Pa8k9VHT-vaBCBUpS:22 a=pGLkceISAAAA:8 a=VwQbUJbxAAAA:8 a=gAnH3GRIAAAA:8 a=LT-n39R2GKJzoR_0PBwA:9 a=CjuIK1q_8ugA:10 a=324X-CrmTo6CU4MGRt3R:22 X-Proofpoint-Spam-Details-Enc: AW1haW4tMjYwNzIzMDIyNCBTYWx0ZWRfXxqnGdaFp/cWe KcmnodvzIVcjpP7CDVliWqjtSDRm9ju5OTXAWu1HDhOB9KCqQSv5VmJB29m2zaGMDPNjxfJOGog QCyGSJ+PBcLS8NkqWOfH5E2kDDF8XNnn82/0zvzQgrNsbtS0Scg4OBupLrXYd3SgA5DPJ3CexZP uTnm1dtDlrFB9rrJTQQ/Ln8o+nu7Nael++164XWlzDLff1b+v0q0x9cIX8fEXIk8IQjGnNj0lJB avAszlYJ/wwWn0+paG6qpfTNEwd3ZOunANLQDxYQnw7gWrq9pAHQizrpaVG8NLDFIAgpHD+vI5z U7ztGbRy56S0s/avtU6VcH8s15C3NfUHlpmWB2b8VdW65aiCKiL3WXC21yVNrth4piQVbATi3+h dMYzJFUZmzSe6QznujpSk9VsEag9BS4WCw6rZYI003PeuG07MmCwL3cJxuAzF31n5/qYtOESxwL BbTd5NZwHxFcWxCpp0w== X-Proofpoint-Spam-Info: AW1haW4tMjYwNzIzMDIyNCBTYWx0ZWRfX5MOg0N1VrCCi PEpdWKwRzKI3qvudoHxQvBQjlIbAzyiJ1jrEH1ZiuVJk4J/sIWpSsu98Pok1ZKVFIb1D5/hGs/v hiCHzas0BHoGamS6lRZPN7VmXvLXJA8= X-Proofpoint-Virus-Version: vendor=baseguard engine=ICAP:2.0.293,Aquarius:18.0.1143,Hydra:6.1.134,FMLib:17.12.100.49 definitions=2026-07-23_07,2026-07-22_02,2025-10-01_01 X-Proofpoint-Spam-Details: rule=outbound_notspam policy=outbound score=0 suspectscore=0 priorityscore=1501 lowpriorityscore=0 impostorscore=0 malwarescore=0 clxscore=1015 spamscore=0 phishscore=0 bulkscore=0 adultscore=0 classifier=typeunknown authscore=0 authtc= authcc= route=outbound adjust=0 reason=mlx scancount=1 engine=8.22.0-2606150000 definitions=main-2607230224 On Mon, 20 Jul 2026 12:16:29 +0100 Rodrigo Alencar <455.rodrigo.alencar@gmail.com> wrote: > On 19/07/26 22:43, Jonathan Cameron wrote: > > On Sun, 19 Jul 2026 10:51:59 +0100 > > Rodrigo Alencar via B4 Relay wrote: > > > > > From: Rodrigo Alencar > > > > > > Add support for AD5313R, AD5317R, AD5674, AD5679, AD5687, AD5687R, AD5689, > > > AD5689R to the AD5686 SPI driver. Also adding support for AD5316R, AD5675, > > > AD5697R to the AD5696 I2C driver. AD5673R and AD5677R were missing from > > > the of_match table. > > > > Given I'm asking for a v2 anyway, please break out the missing of_match > > table entries as a precursor. > > checkpatch complains adding stuff to of_match table without having the entry in > the dt-binding. I suppose the desired order for the changes would be: With a good reason it is fine to ignore checkpatch. The sequence you have is indeed the ideal patch break up. > > clean ups: > > - ad5696 dt-binding: adding support for the 'missing' entries. > - ad5696-i2c: add missing of_match entries > - Adjust reformat device list in file-comment headers and Kconfig > > extend dev support: > > - ad5686 dt-binding changes (new devices) > - ad5696 dt-binding changes (new devices) > - create new chip info's and populated device tables > - Add new devices to Kconfig option description > > Does it sound reasonable? >