The Linux Kernel Mailing List
 help / color / mirror / Atom feed
From: Tao Cui <cui.tao@linux.dev>
To: Johannes Weiner <hannes@cmpxchg.org>,
	Suren Baghdasaryan <surenb@google.com>
Cc: Peter Zijlstra <peterz@infradead.org>,
	Ingo Molnar <mingo@redhat.com>,
	linux-kernel@vger.kernel.org, Tao Cui <cuitao@kylinos.cn>,
	cui.tao@linux.dev
Subject: [PATCH 2/2] sched/psi: convert trigger window/threshold to ns in u64
Date: Fri, 24 Jul 2026 12:11:46 +0800	[thread overview]
Message-ID: <20260724041146.510027-3-cui.tao@linux.dev> (raw)
In-Reply-To: <20260724041146.510027-1-cui.tao@linux.dev>

From: Tao Cui <cuitao@kylinos.cn>

psi_trigger_create() scales the trigger threshold and window from
microseconds to nanoseconds as

    t->threshold = threshold_us * NSEC_PER_USEC;
    t->win.size  = window_us   * NSEC_PER_USEC;

NSEC_PER_USEC is 1000L, so on 32-bit the multiply is done in 32 bits and
wraps for windows larger than ~4.29s (WINDOW_MAX_US is 10s): a 10s window
is stored as ~1.41s and the trigger fires much too eagerly.  Cast to u64
before multiplying.

Fixes: 0e94682b73bf ("psi: introduce psi monitor")
Signed-off-by: Tao Cui <cuitao@kylinos.cn>
---
 kernel/sched/psi.c | 4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)

diff --git a/kernel/sched/psi.c b/kernel/sched/psi.c
index 6514b44222cf..7fbe9b94fafa 100644
--- a/kernel/sched/psi.c
+++ b/kernel/sched/psi.c
@@ -1390,8 +1390,8 @@ struct psi_trigger *psi_trigger_create(struct psi_group *group, char *buf,
 
 	t->group = group;
 	t->state = state;
-	t->threshold = threshold_us * NSEC_PER_USEC;
-	t->win.size = window_us * NSEC_PER_USEC;
+	t->threshold = (u64)threshold_us * NSEC_PER_USEC;
+	t->win.size = (u64)window_us * NSEC_PER_USEC;
 	window_reset(&t->win, sched_clock(),
 			group->total[PSI_POLL][t->state], 0);
 
-- 
2.43.0


      parent reply	other threads:[~2026-07-24  4:12 UTC|newest]

Thread overview: 3+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2026-07-24  4:11 [PATCH 0/2] sched/psi: fix trigger window arithmetic Tao Cui
2026-07-24  4:11 ` [PATCH 1/2] sched/psi: fix trigger window growth interpolation for large windows Tao Cui
2026-07-24  4:11 ` Tao Cui [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20260724041146.510027-3-cui.tao@linux.dev \
    --to=cui.tao@linux.dev \
    --cc=cuitao@kylinos.cn \
    --cc=hannes@cmpxchg.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=mingo@redhat.com \
    --cc=peterz@infradead.org \
    --cc=surenb@google.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox