From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail-wm1-f51.google.com (mail-wm1-f51.google.com [209.85.128.51]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 74603367B6F for ; Fri, 24 Jul 2026 04:14:23 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.128.51 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1784866467; cv=none; b=Ka95jTBKreDEYVUjXevOkGrqX7EetI2KFgSDoqQUljPsQXQ7XDw4SIcBl/tw3y9q+FD+4ysRlCxlMq8Ed2rLO7eURhkitRXRZu9QuS788fkvS/9jnTeMY0hSyvN3vRCQEH9hKCKkmLCjUlJeO4aPmhDPxYyO0z0z0xs4MJketa0= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1784866467; c=relaxed/simple; bh=tb7LJRwhFKQIMZEc6WXlcZXKcn0QsC3CujOv4fzGNQk=; h=From:To:Cc:Subject:Date:Message-ID:MIME-Version; b=Gs2M8bdHRLOWJiN47GVbSoY72GYy0feMrxEBloHSKP3RiQmOO1Slp31ozcnp1W0vQFbxE8pYAS+BMOkQ8aQ8OQaR0fsA791+l5q5rbvB6f/P1VitMICLvxqri6sUEEglL/+pE5BHDKlrArNO8/aMlx/g82WRlKkNvxr7Ta8OS3w= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com; spf=pass smtp.mailfrom=gmail.com; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b=a7YHoCGx; arc=none smtp.client-ip=209.85.128.51 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=gmail.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="a7YHoCGx" Received: by mail-wm1-f51.google.com with SMTP id 5b1f17b1804b1-493b966dd74so425e9.3 for ; Thu, 23 Jul 2026 21:14:22 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20251104; t=1784866460; x=1785471260; darn=vger.kernel.org; h=content-transfer-encoding:mime-version:message-id:date:subject:cc :to:from:from:to:cc:subject:date:message-id:reply-to:content-type; bh=+CMdfBeyqiMFs/ZMRXbCFt3Qfbb+CwGIeVxKI3ayU34=; b=a7YHoCGxJF0wYTNZJiSn2sjehSZGWDD4/FPPIrn5RjO2IsER/GTZ9CJPwCaOPas0+A jHO3i/jE/nSEkqTrarLLLDXvD/7otZxZ0B+XT4vPpoCp6sHpkqOa+0gFP2twk/sf/Fxz YyXG4UFCoEw6MM1m7exg+QQS6386jmeZ+Eu24fYxTcLtviprbMFgQW9kAsEr02KX0KuB edVQwCHwA8NcrkEQwd7E6cZ7JPokfWciibcT5JeCHrXjCwoYlzNw9luBr6/OISAqJdg7 QhbyRPyHleQHGjGc/2zQ7Emvf9P6+n5tHgtdIYghXAOi7ddXH4L6hAA2uz8YVdT/PRDZ cTyw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1784866460; x=1785471260; h=content-transfer-encoding:mime-version:message-id:date:subject:cc :to:from:x-gm-gg:x-gm-message-state:from:to:cc:subject:date :message-id:reply-to:content-type; bh=+CMdfBeyqiMFs/ZMRXbCFt3Qfbb+CwGIeVxKI3ayU34=; b=NXtrfDNGzPymZ1XBRIaX0/K5ZzQdr2UQqiAI5PBhnX65Na0Z4s5PW3gsDnvnuFVRgb TbIGA61pjy06OQzbccdVUpV0xvAZ8DKQYXrtmUknFpERV3Bm9Yhivk7Qb5XHJFs/b/TB 3RnajI4nyYGe4bleHjFYaV6svdq+ejvIjU06BbNa3ISjgNv2q9iuR5b9b0LMpKbHgKxL zrvmYa76SgfaiCdCGzn68tRuz/M0UaGe6GN1+BaJlvUzhCvcGrpY+Y7CQPE5zcXfFuPV 2+NAsdaLmQK0v6GwYq2RAWYKzIX54PMbW5kEPbh1ym3uV5rRQBIoGzQL/ZDi2+YZWfRL j42Q== X-Forwarded-Encrypted: i=1; AHgh+Rp4Nii6mynkAJG0/cq5cRSDKGec6Q//xT5S3r0T62H4BoYPKVZmzIblj26zvqG0WUcq8R/c4t8oGvy+RLc=@vger.kernel.org X-Gm-Message-State: AOJu0YzAm4f6pzpZ63JJOVLGcO0hRmM610XPlmXDzCB1gLgo7r7sC/jp 19QjWCCLM8rbShmfYHEzAkudXMjP9HmrXojNBlcbjQPI8PPjbkNHi4Wx X-Gm-Gg: AR+sD13x5i34PACETP7Yl5UWa0nK+Bb4w7t+aE3hU3cjJtuOKBiJ2WHL7G/J7MhTXox D6ACbTuV9IRxqPYiVLz0lG8n0uLFla7DPr9IIjYFNrdd1vwdtcKV48NIfHEF3oTSMwfF0L01YlE 3jCdzAUnDF/cpai55Rot3QihMoq2poQ4+9Z4XFoVljjmVWNLRpjb8Q3h2mX4A3S7MUd9/p5/UDk ewx0w32c3krFU/GS9vp8UEHRJX2S/9IM3o9Nx2N5j8FnHQ/hoqEx4jDeQJ0JLovVWTLAo+0QL46 /BBIv1BEY78ycq6IZ/r1yAIOtc7F3XOFmpaimNPZws/pM4xBNXLrEQnW8I0es4djf4amV1ZHIxQ WTaHQP5hdcZGAKx485OEu55SyUCEJfjJJLvczosX0CarbAyxvQWYwSP6g4DNqOeiTcUa67uAE/t m6AoCBHzVBIpW17UL1kolGF7jO57/d4HeO6yaAR68nAU/3y8qERgECUiIXs6rj5EUrRWb89Bnd X-Received: by 2002:a05:600c:4687:b0:495:5dcc:52ae with SMTP id 5b1f17b1804b1-49573cc2eb8mr66808285e9.3.1784866459843; Thu, 23 Jul 2026 21:14:19 -0700 (PDT) Received: from dohko.chello.ie (188-141-5-72.dynamic.upc.ie. [188.141.5.72]) by smtp.gmail.com with ESMTPSA id 5b1f17b1804b1-4957af6adbbsm38761435e9.6.2026.07.23.21.14.18 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Thu, 23 Jul 2026 21:14:19 -0700 (PDT) From: David Carlier To: hpa@redhat.com Cc: sakari.ailus@linux.intel.com, mchehab@kernel.org, tarang.raval@siliconsignals.io, linux-media@vger.kernel.org, linux-kernel@vger.kernel.org, David Carlier Subject: [PATCH] media: i2c: imx471: Fix uninitialized error value in imx471_set_ctrl() Date: Fri, 24 Jul 2026 05:14:16 +0100 Message-ID: <20260724041417.9921-1-devnexen@gmail.com> X-Mailer: git-send-email 2.53.0 Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: 8bit The exposure control write passes the address of the local ret variable to cci_write() as its error pointer while ret is still uninitialized. cci_write() returns early without touching the hardware when the error value it is handed is already non-zero, so a non-zero garbage value on the stack silently skips programming the exposure register and makes the control write return a bogus, possibly positive, status. This path runs on every stream start and on every exposure update from userspace. Initialize ret to zero so the exposure register is always written and a correct status is returned. Fixes: be1589e567ae ("media: i2c: imx471: Add Sony IMX471 image sensor driver") Signed-off-by: David Carlier --- drivers/media/i2c/imx471.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/media/i2c/imx471.c b/drivers/media/i2c/imx471.c index 6d358b11e96d..5aca5f2355d6 100644 --- a/drivers/media/i2c/imx471.c +++ b/drivers/media/i2c/imx471.c @@ -306,7 +306,7 @@ static int imx471_set_ctrl(struct v4l2_ctrl *ctrl) v4l2_subdev_get_locked_active_state(&sensor->sd); const struct v4l2_mbus_framefmt *format = v4l2_subdev_state_get_format(state, 0); - int ret; + int ret = 0; if (ctrl->id == V4L2_CID_VBLANK) { s64 exposure_max = format->height + ctrl->val - -- 2.53.0