The Linux Kernel Mailing List
 help / color / mirror / Atom feed
From: dongxuyang@eswincomputing.com
To: ukleinek@kernel.org, robh@kernel.org, krzk+dt@kernel.org,
	conor+dt@kernel.org, ben-linux@fluff.org,
	ben.dooks@codethink.co.uk, linux-pwm@vger.kernel.org,
	devicetree@vger.kernel.org, linux-kernel@vger.kernel.org,
	p.zabel@pengutronix.de, daniel.lezcano@kernel.org,
	tglx@kernel.org
Cc: ningyu@eswincomputing.com, linmin@eswincomputing.com,
	xuxiang@eswincomputing.com, wangguosheng@eswincomputing.com,
	pinkesh.vaghela@einfochips.com,
	Xuyang Dong <dongxuyang@eswincomputing.com>
Subject: [PATCH v13 5/5] clocksource: dw_apb_timer: Use reset array API to handle all resets
Date: Fri, 24 Jul 2026 16:44:37 +0800	[thread overview]
Message-ID: <20260724084437.1850-1-dongxuyang@eswincomputing.com> (raw)
In-Reply-To: <20260724084153.1473-1-dongxuyang@eswincomputing.com>

From: Xuyang Dong <dongxuyang@eswincomputing.com>

timer_get_base_and_rate() only ever fetched a single, index-0 reset
control via of_reset_control_get(np, NULL), which does not consult
reset-names and always resolves to the first entry. With the binding
now allowing a second entry, a device tree that lists both lines would
leave the second entry permanently unasserted, since the driver never
touches it.

Replace it with devm_reset_control_array_get_optional_exclusive() to
fetch and control all reset lines listed in the device tree, ensuring
every line is properly asserted and deasserted rather than only the first.

Signed-off-by: Xuyang Dong <dongxuyang@eswincomputing.com>
---
 drivers/clocksource/dw_apb_timer_of.c | 6 ++++--
 1 file changed, 4 insertions(+), 2 deletions(-)

diff --git a/drivers/clocksource/dw_apb_timer_of.c b/drivers/clocksource/dw_apb_timer_of.c
index 3245eb0c602d..ffe495a8416a 100644
--- a/drivers/clocksource/dw_apb_timer_of.c
+++ b/drivers/clocksource/dw_apb_timer_of.c
@@ -29,9 +29,11 @@ static int __init timer_get_base_and_rate(struct device_node *np,

 	/*
 	 * Reset the timer if the reset control is available, wiping
-	 * out the state the firmware may have left it
+	 * out the state the firmware may have left it.
+	 * Use array variant to handle multiple resets (e.g., timer
+	 * and APB interface resets) if specified in the device tree.
 	 */
-	rstc = of_reset_control_get(np, NULL);
+	rstc = of_reset_control_array_get_optional_exclusive(np);
 	if (!IS_ERR(rstc)) {
 		reset_control_assert(rstc);
 		reset_control_deassert(rstc);
--
2.34.1


  parent reply	other threads:[~2026-07-24  8:45 UTC|newest]

Thread overview: 13+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2026-07-24  8:41 [PATCH v13 0/5] Update designware pwm driver dongxuyang
2026-07-24  8:43 ` [PATCH v13 1/5] dt-bindings: pwm: dwc: Document optional resets property dongxuyang
2026-07-25 15:05   ` Krzysztof Kozlowski
     [not found]   ` <20260724085345.E530D1F000E9@smtp.kernel.org>
2026-07-27  9:25     ` Xuyang Dong
2026-07-24  8:43 ` [PATCH v13 2/5] dt-bindings: pwm: dwc: Add eswin compatible dongxuyang
2026-07-25 15:06   ` Krzysztof Kozlowski
2026-07-27  9:26     ` Xuyang Dong
     [not found]   ` <20260724085639.A7E841F000E9@smtp.kernel.org>
2026-07-27  9:25     ` Xuyang Dong
2026-07-24  8:43 ` [PATCH v13 3/5] pwm: dwc: add of/platform support dongxuyang
     [not found]   ` <20260724085715.9847C1F00A3F@smtp.kernel.org>
2026-07-27  9:25     ` Xuyang Dong
2026-07-24  8:44 ` [PATCH v13 4/5] dt-bindings: timer: dwc: Update resets property items dongxuyang
2026-07-24  8:44 ` dongxuyang [this message]
     [not found]   ` <20260724085527.D31BC1F000E9@smtp.kernel.org>
2026-07-27  9:26     ` Re: [PATCH v13 5/5] clocksource: dw_apb_timer: Use reset array API to handle all resets Xuyang Dong

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20260724084437.1850-1-dongxuyang@eswincomputing.com \
    --to=dongxuyang@eswincomputing.com \
    --cc=ben-linux@fluff.org \
    --cc=ben.dooks@codethink.co.uk \
    --cc=conor+dt@kernel.org \
    --cc=daniel.lezcano@kernel.org \
    --cc=devicetree@vger.kernel.org \
    --cc=krzk+dt@kernel.org \
    --cc=linmin@eswincomputing.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-pwm@vger.kernel.org \
    --cc=ningyu@eswincomputing.com \
    --cc=p.zabel@pengutronix.de \
    --cc=pinkesh.vaghela@einfochips.com \
    --cc=robh@kernel.org \
    --cc=tglx@kernel.org \
    --cc=ukleinek@kernel.org \
    --cc=wangguosheng@eswincomputing.com \
    --cc=xuxiang@eswincomputing.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox