The Linux Kernel Mailing List
 help / color / mirror / Atom feed
From: Heiko Carstens <hca@linux.ibm.com>
To: Alexander Gordeev <agordeev@linux.ibm.com>
Cc: Sven Schnelle <svens@linux.ibm.com>,
	Vasily Gorbik <gor@linux.ibm.com>,
	Christian Borntraeger <borntraeger@linux.ibm.com>,
	Janosch Frank <frankja@linux.ibm.com>,
	Claudio Imbrenda <imbrenda@linux.ibm.com>,
	David Hildenbrand <david@kernel.org>,
	linux-s390@vger.kernel.org, kvm@vger.kernel.org,
	linux-kernel@vger.kernel.org
Subject: Re: [PATCH v2 2/4] s390/mm: Fix handling of secure storage access exceptions in vmalloc area
Date: Fri, 24 Jul 2026 11:21:09 +0200	[thread overview]
Message-ID: <20260724092109.22621Cbf-hca@linux.ibm.com> (raw)
In-Reply-To: <c10b144d-22fc-45f3-b684-2adf88dbbceb-agordeev@linux.ibm.com>

On Fri, Jul 24, 2026 at 10:40:16AM +0200, Alexander Gordeev wrote:
> On Fri, Jul 17, 2026 at 11:24:13AM +0200, Heiko Carstens wrote:
> > Secure storage access exceptions in vmalloc area need to be handled
> > separately since folio_try_get() or virt_to_phys() do not work on such
>                    ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
> virt_to_phys() is not called here directly while folio_try_get() does
> not accept the addr parameter. Did you mean just virt_to_folio() or do
> you imply something outside of the context of this patch? 

> >  	if (is_kernel_fault(regs)) {
> > +		if (is_vmalloc_addr((void *)addr))
> > +			return handle_fault_error_nolock(regs, 0);
> >  		folio = virt_to_folio((void *)addr);
> >  		if (unlikely(!folio_try_get(folio)))

I don't remember anymore. Probably a left-over from something else I
tried. Could simply be changed to "...virt_to_folio() does not work
on..." while applying.

  reply	other threads:[~2026-07-24  9:47 UTC|newest]

Thread overview: 7+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2026-07-17  9:24 [PATCH v2 0/4] s390: Reintroduce support for DCACHE_WORD_ACCESS Heiko Carstens
2026-07-17  9:24 ` [PATCH v2 1/4] KVM: s390: pv: Use VM_SPARSE area for guest variable storage area Heiko Carstens
2026-07-17  9:24 ` [PATCH v2 2/4] s390/mm: Fix handling of secure storage access exceptions in vmalloc area Heiko Carstens
2026-07-24  8:40   ` Alexander Gordeev
2026-07-24  9:21     ` Heiko Carstens [this message]
2026-07-17  9:24 ` [PATCH v2 3/4] s390/mm: Remove folio handling for secure storage access exceptions Heiko Carstens
2026-07-17  9:24 ` [PATCH v2 4/4] s390: Add support for DCACHE_WORD_ACCESS (again) Heiko Carstens

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20260724092109.22621Cbf-hca@linux.ibm.com \
    --to=hca@linux.ibm.com \
    --cc=agordeev@linux.ibm.com \
    --cc=borntraeger@linux.ibm.com \
    --cc=david@kernel.org \
    --cc=frankja@linux.ibm.com \
    --cc=gor@linux.ibm.com \
    --cc=imbrenda@linux.ibm.com \
    --cc=kvm@vger.kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-s390@vger.kernel.org \
    --cc=svens@linux.ibm.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox