From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail-ed1-f51.google.com (mail-ed1-f51.google.com [209.85.208.51]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 683713D9DB6 for ; Fri, 24 Jul 2026 09:44:27 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.208.51 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1784886269; cv=none; b=KPNX8n23fL64068jY+sOtGg8Wed9MdraNFQNzY/GutHrc3RxdBqTtAaMh3VMNyGiowO0ON9Pr4m/mYNCZDXHsfb/fVlusKrwDmCyUvEVwbuG3r3zFTY22N0EgOzMq/fon55CwhtnJJq8+VyZjQEOCo0a3pI7pOeDHpTDRf3xjYg= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1784886269; c=relaxed/simple; bh=sUA7FHukNsScIZLQP0xgI8THUUyLT/6hRDoo2eCKr6g=; h=From:To:Cc:Subject:Date:Message-Id:In-Reply-To:References; b=AHVuPOl7UW9P+OeXinXFn2e3uZXCC/kqMIvg+mml8BSzyBLhMrDlxMpUFDOjthoHPZaKDyJw/5Zqwt0UdoOVpQYoIz2ViVUaPjkdMwfYln0HWauC2kUoUldt4arp4r1BFbmBjvUF7BehvMKrVRUchdI6e4el66u5mQk2U4KB/nU= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com; spf=pass smtp.mailfrom=gmail.com; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b=dlnowHqv; arc=none smtp.client-ip=209.85.208.51 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=gmail.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="dlnowHqv" Received: by mail-ed1-f51.google.com with SMTP id 4fb4d7f45d1cf-69c1220bd51so323102a12.3 for ; Fri, 24 Jul 2026 02:44:26 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20251104; t=1784886265; x=1785491065; darn=vger.kernel.org; h=references:in-reply-to:message-id:date:subject:cc:to:from:from:to :cc:subject:date:message-id:reply-to:content-type; bh=Z4UYRb5GP95XbbKS3BzXHzHeJsPryg5Ef3ntWHW+d0s=; b=dlnowHqvTR6OXy87YWDD1mBCUje9KSqy7ZTmG5LjRcA0kzFd1oxoK2vqmGP6k5MSbI iMf6rIlwxj3nRYekF9iDt8w/cxiDHuXH98kU9moy6acVD8jgfjWc+VApdSlEh5RcCCvs gyPOPh+UMInUnHc7opB0ana/XY2/vt4a7hEmxKBlZS2AlGqdeqge8b41oKpdATic/tMp VBUO9l9Xx9U0MNn7BdERi0YjWjwMbPJiwlfosU/aVIb2pb9LyXC4ixqpMXyGlwrkfBXB HtgFKKt+cmrfjW1q/hLsisSkWQtuuQ/veN0xnbxmr4Pht6O3NAYPzThIPj/vX0i+A1Bb 5scA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1784886265; x=1785491065; h=references:in-reply-to:message-id:date:subject:cc:to:from:x-gm-gg :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to :content-type; bh=Z4UYRb5GP95XbbKS3BzXHzHeJsPryg5Ef3ntWHW+d0s=; b=h7A7JfcgOYpWVZoxKYiuG4I2WksWdeMO4y/wHuo9xeff9iv1HCnFBY1oXKfVYxL+R1 PlZsd5bIGtad8UHfd1m47uZo1CCpuSL/UDRYQkIwwN1jKQF+swjfX1rE86yBns+uaAsc oCkyJxbtCCcUMPTfQc8Zu+noxN9DhMh69j12rIFfR6ZrSBLHXphCDmb4RKuBgA8spLRR 9iSAPBBYrmM5mwJYig0Y0s6j2skQURsH2bC+hmC3XlVPcMHtt9CHAgoTKKsnZJrJdgYG teDYCgUTHBKo2d8KhxQx860/Xe8bGWzYWTc6u96iYHTTt0wr3JnvY/SHtiwngWLsr7G2 zmBA== X-Forwarded-Encrypted: i=1; AHgh+RrYicEm3i4xzXDGk1kXElGEiJTzvx4g+mbzKQI/l25mzLdjlw/ijzskH8iDUExx0gc7fpT8O455a0L5KQk=@vger.kernel.org X-Gm-Message-State: AOJu0Yxb5zG8wGNOrdPWh3AANpj9ctvROhHIFkaTHwv/XiFZxuaM+4I6 7gl993BaxysERnoFX4BRGFCL4xTwXMMTA0tlTgdMwWn8UYaN+Id+Wh2v X-Gm-Gg: AR+sD13vUew8/munwfy7u9WKmm5m/ybKizAS19MhQwsiSibT7vYVdeHRpyw7wVbXYX2 Vl1nHv8kQ5bxTZq6Xv52uPOgbBF/sxLkxGzxsGKtAVDci7OVLbQ/Sk4ewPOM761V/pRRHJguQgx 93xgGzjmOmfYyjND6C0EmIDMlQXoZhwjdWP9+r28AXKj6ADUakj24gEuWhEV9p19oDRmlYQWBie 6ifscYesWc0qBALkWsQB0vFabzGGn/frjKCJN4VG6Zd4W+NMBHf3pPlFICTieOduAFMDsQiVJbD 2W5lQFCLNhZaEotjdTLnAOpjWI2FF73P5/med3Sb6L9Qd9+DkeU3kcfLRyKiBoC/+9isanT8rnj BfqXuxRNS1Y32ggfOxJ2fZTK+devGZr16eJBToAdGpRIqYGGtPg32xU07cbif2Dg1tQY8rIRtVN 0+9dFxrTTJOKW0Z6QB+jzurAtdPXPNoGQmDlSnfLQY X-Received: by 2002:a05:6402:5053:b0:698:3b7b:e48a with SMTP id 4fb4d7f45d1cf-69f6c5e4fa9mr2860977a12.32.1784886265087; Fri, 24 Jul 2026 02:44:25 -0700 (PDT) Received: from localhost (c-85-228-45-68.bbcust.telenor.se. [85.228.45.68]) by smtp.gmail.com with ESMTPSA id 4fb4d7f45d1cf-69f35026b10sm3070405a12.25.2026.07.24.02.44.23 (version=TLS1_2 cipher=ECDHE-ECDSA-CHACHA20-POLY1305 bits=256/256); Fri, 24 Jul 2026 02:44:24 -0700 (PDT) From: Eli Billauer To: gregkh@linuxfoundation.org Cc: arnd@arndb.de, linux-kernel@vger.kernel.org, corbet@lwn.net, Eli Billauer Subject: [PATCH v3 2/7] char: xillybus: Remove duplicate error path code Date: Fri, 24 Jul 2026 11:42:57 +0200 Message-Id: <20260724094302.50761-3-eli.billauer@gmail.com> X-Mailer: git-send-email 2.17.1 In-Reply-To: <20260724094302.50761-1-eli.billauer@gmail.com> References: <20260724094302.50761-1-eli.billauer@gmail.com> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: No need for dedicated code for the error path. The removed dedicated error path code differs only in when the mutex is released, and that makes no difference in this context. Assisted-by: Deepseek:v4-pro Kimi:K2.6 ChatGPT:GPT-5.5 Claude:Sonnet-4.6 Signed-off-by: Eli Billauer --- Notes: Changes v2->v3: -- Add Assisted-by tag to description No change on v1->v2. drivers/char/xillybus/xillyusb.c | 6 +----- 1 file changed, 1 insertion(+), 5 deletions(-) diff --git a/drivers/char/xillybus/xillyusb.c b/drivers/char/xillybus/xillyusb.c index a28e6416cb01..ab5f9159aa17 100644 --- a/drivers/char/xillybus/xillyusb.c +++ b/drivers/char/xillybus/xillyusb.c @@ -1419,16 +1419,12 @@ static int xillyusb_open(struct inode *inode, struct file *filp) if (filp->f_mode & FMODE_WRITE) chan->open_for_write = 0; +unmutex_fail: mutex_unlock(&chan->lock); kref_put(&xdev->kref, cleanup_dev); return rc; - -unmutex_fail: - kref_put(&xdev->kref, cleanup_dev); - mutex_unlock(&chan->lock); - return rc; } static ssize_t xillyusb_read(struct file *filp, char __user *userbuf, -- 2.34.1