The Linux Kernel Mailing List
 help / color / mirror / Atom feed
From: Eric Biggers <ebiggers@kernel.org>
To: Bartosz Golaszewski <brgl@kernel.org>
Cc: Greg Kroah-Hartman <gregkh@linuxfoundation.org>,
	linux-crypto@vger.kernel.org,
	Herbert Xu <herbert@gondor.apana.org.au>,
	linux-arm-msm@vger.kernel.org,
	linux-arm-kernel@lists.infradead.org,
	linux-kernel@vger.kernel.org,
	Demi Marie Obenour <demiobenour@gmail.com>,
	Kuldeep Singh <kuldeep.singh@oss.qualcomm.com>,
	Dmitry Baryshkov <dmitry.baryshkov@oss.qualcomm.com>
Subject: Re: [PATCH] crypto: qce - Remove driver
Date: Fri, 24 Jul 2026 07:14:14 -0700	[thread overview]
Message-ID: <20260724141414.GB1876@sol> (raw)
In-Reply-To: <CAMRc=MeFoG0UXYOAqYhCiKBTs12EjX2-Bz4wDnbeYXmQA3-OaQ@mail.gmail.com>

On Fri, Jul 24, 2026 at 11:29:30AM +0200, Bartosz Golaszewski wrote:
> It can't be used *accidentally*. It can still be used by in-kernel
> users if you bump its priority via netlink.

dm-verity, fscrypt, fsverity, and blk-crypto-fallback don't support this
driver.  The QCE driver itself has bugs that make it not work with
dm-crypt and IPsec.

That's all regardless of any theoretical tweaking via NETLINK_CRYPTO.

That doesn't leave many upstream kernel features that could even
*theoretically* be using the QCE driver if someone were to do the
NETLINK_CRYPTO thing.  Maybe SMB or kTLS?  (But not with AES-GCM, as the
QCE driver doesn't support AES-GCM.  It would have to be AES-CCM.)

However, over the years it's become extremely clear that virtually no
one actually uses NETLINK_CRYPTO to tweak the algorithm priorities.

It's part of the excessive "flexibility" of the crypto framework that is
just not used in practice.  Users actually just use the defaults.

And with the defaults QCE is *never* used.

So I think the NETLINK_CRYPTO thing is a red herring.  There's just no
credible upstream use case justifying this driver's retention.

- Eric

  reply	other threads:[~2026-07-24 14:16 UTC|newest]

Thread overview: 13+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2026-07-24  5:06 [PATCH] crypto: qce - Remove driver Eric Biggers
2026-07-24  5:28 ` Greg Kroah-Hartman
2026-07-24  7:36   ` Bartosz Golaszewski
2026-07-24  8:41     ` Greg Kroah-Hartman
2026-07-24  9:29       ` Bartosz Golaszewski
2026-07-24 14:14         ` Eric Biggers [this message]
2026-07-24 14:47           ` Bartosz Golaszewski
2026-07-24 15:04             ` Greg Kroah-Hartman
2026-07-24 15:09               ` Eric Biggers
2026-07-24 15:25                 ` Greg Kroah-Hartman
2026-07-24 15:51                   ` Eric Biggers
2026-07-24  9:56 ` Sumit Garg
2026-07-24 13:51   ` Eric Biggers

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20260724141414.GB1876@sol \
    --to=ebiggers@kernel.org \
    --cc=brgl@kernel.org \
    --cc=demiobenour@gmail.com \
    --cc=dmitry.baryshkov@oss.qualcomm.com \
    --cc=gregkh@linuxfoundation.org \
    --cc=herbert@gondor.apana.org.au \
    --cc=kuldeep.singh@oss.qualcomm.com \
    --cc=linux-arm-kernel@lists.infradead.org \
    --cc=linux-arm-msm@vger.kernel.org \
    --cc=linux-crypto@vger.kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox