From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from smtp.kernel.org (aws-us-west-2-korg-mail-alma10-1.taild15c8.ts.net [100.103.45.18]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 0FCBC392803; Fri, 24 Jul 2026 21:48:27 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=100.103.45.18 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1784929717; cv=none; b=lmE59OT/cc2rq/lI2LdfzBtVYT4hzbls+hc/puzRBhJuGm5j3xEmP2kIvVItV5pC2Rbi4lxgGHbhKrDYEeTMrCN1eC8XOcA3xGjJrP+l+yZU9CCMN/DkacPClBgHbF7NqUdmEDbAb+4Nfiq1T1e5DIcnUFOO5ofjo7aK41epYhc= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1784929717; c=relaxed/simple; bh=GTdZSgSwBlfAlIxva5M6ZU/kD9VYoe26BBxVBJ5WdPE=; h=Date:From:To:Cc:Subject:Message-ID:In-Reply-To:References: MIME-Version:Content-Type; b=f0dWPJXuJkkHlQ5NLOuD9Ax5Gho1OuqyiVb7t0nd5oWleu8UvKWZ0I9ZwliB4KZE49TmmB6QFpuZUZCvhsdQzWUJFHk39L78Jrb5jzWdYLl7N97uSjvi3jiv7Dfm4rIqq0HGBt3VlUk4FDbtEfdYIBkLNyeZ2WbbL7Xj7V2F1Co= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org header.b=bhpTuvSZ; arc=none smtp.client-ip=100.103.45.18 Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org header.b="bhpTuvSZ" Received: by smtp.kernel.org (Postfix) with ESMTPSA id 0A6FC1F000E9; Fri, 24 Jul 2026 21:48:23 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=kernel.org; s=k20260515; t=1784929705; bh=GTdZSgSwBlfAlIxva5M6ZU/kD9VYoe26BBxVBJ5WdPE=; h=Date:From:To:Cc:Subject:In-Reply-To:References; b=bhpTuvSZWBV7iq9keKc8+pixk18qLEuyMz3ZTlqKcB81KF/CnyeLGI6JSyvHGt9tA E+SxQVBXcXsXsZgtn3HAr+6nPULrU5HRAYu13tTfnL5ffRJr3w0sXxS3y6FSy3SRlS Qe3XQkADPgbjY9nioQHCBPR4pvKP4dL5d3HxM/ORX/63JYStNE+wqJy61XHcdbEpWF xaZAuoqTpynwYjXBJP4BY73AhLP471MMWjcWFGi91teQEabAfmboMZJJ2AI9mVl919 5Vj52Ap+SYxCLa6sCvz56w/tCisRBng0kD6I+yiTKpyHAoJV1VexiywmsHK9mBuUsB 8QLvkwcrgPftA== Date: Fri, 24 Jul 2026 14:48:22 -0700 From: Jakub Kicinski To: Sang-Heon Jeon Cc: Julia.Lawall@inria.fr, Alex Deucher , Alexander Shishkin , Alexandre Belloni , Andrew Lunn , Andrew Morton , Arkadiusz Kubalewski , Borislav Petkov , Christian =?UTF-8?B?S8O2bmln?= , Daniel Lezcano , David Airlie , "David S. Miller" , Dmitry Torokhov , Eric Dumazet , Florian Westphal , Greg Kroah-Hartman , Hans de Goede , Hans Verkuil , Heikki Krogerus , Herbert Xu , Ilpo =?UTF-8?B?SsOkcnZpbmVu?= , "James E.J. Bottomley" , Jani Nikula , Jaroslav Kysela , Jason Gunthorpe , Jiri Pirko , "Joerg Roedel (AMD)" , Johan Hovold , Jonathan Cameron , Joonas Lahtinen , Julian Anastasov , Leon Romanovsky , Liam Girdwood , Linus Walleij , Maarten Lankhorst , Mark Brown , "Martin K. Petersen" , Matthew Sakai , Mauro Carvalho Chehab , Maxime Ripard , Michael Turquette , Mike Rapoport , Miri Korenblit , Nicolas Palix , Pablo Neira Ayuso , Paolo Abeni , Ping-Ke Shih , "Rafael J. Wysocki" , Rodrigo Vivi , Sebastian Reichel , Shuah Khan , Simona Vetter , Simon Horman , Stephen Boyd , Steve French , Takashi Iwai , Thomas Renninger , Thomas Zimmermann , Tony Luck , Tvrtko Ursulin , Vadim Fedorenko , Vinod Koul , Will Deacon , Yazen Ghannam , cocci@inria.fr, amd-gfx@lists.freedesktop.org, dmaengine@vger.kernel.org, dm-devel@lists.linux.dev, dri-devel@lists.freedesktop.org, intel-gfx@lists.freedesktop.org, intel-wired-lan@lists.osuosl.org, iommu@lists.linux.dev, linux-cifs@vger.kernel.org, linux-clk@vger.kernel.org, linux-crypto@vger.kernel.org, linux-edac@vger.kernel.org, linux-gpio@vger.kernel.org, linux-iio@vger.kernel.org, linux-input@vger.kernel.org, linux-kernel@vger.kernel.org, linux-media@vger.kernel.org, linux-mm@kvack.org, linux-pm@vger.kernel.org, linux-rdma@vger.kernel.org, linux-rtc@vger.kernel.org, linux-s390@vger.kernel.org, linux-scsi@vger.kernel.org, linux-sound@vger.kernel.org, linux-usb@vger.kernel.org, linux-wireless@vger.kernel.org, lvs-devel@vger.kernel.org, netdev@vger.kernel.org, netfilter-devel@vger.kernel.org, nouveau@lists.freedesktop.org, platform-driver-x86@vger.kernel.org Subject: Re: [PATCH 00/36] treewide: remove conditional returns with no effect Message-ID: <20260724144822.6af8213f@kernel.org> In-Reply-To: <20260723184538.3888637-1-ekffu200098@gmail.com> References: <20260723184538.3888637-1-ekffu200098@gmail.com> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit On Fri, 24 Jul 2026 03:45:02 +0900 Sang-Heon Jeon wrote: > Patch 1 adds a Coccinelle script that matches the pattern, including > negation and constant-comparison variants. Where a local variable is > assigned right before the check, the assignment and the two returns > turn into a single return of the assigned expression. Huh, I thought we already had such script. Various script children have been sending such "cleanups" in the past. > Patches 2-36 are generated by the script, with hand fixes to restore > unexpectedly removed comments and to fix the formatting checkpatch.pl > complained about. Please post patches 4,7,8,9 as a separate series. Since you only CCed netdev on subset of the series patchwork thinks there are patches missing and doesn't kick off any CI.