From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail-qt1-f176.google.com (mail-qt1-f176.google.com [209.85.160.176]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 266FD3812F6 for ; Fri, 24 Jul 2026 21:47:05 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.160.176 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1784929630; cv=none; b=hoxB3AGC7mrdx/43JeFQ34fQQf8rD7D7u89LsE6sRO4ov/rszdj77CH+mZLYKw1bZHYlX3Zw8cCSF551fgN4Yirfp96CiPLSW0bfinb0ECLVFJs9PclxZnzP0MlO9lO1r/MEfaoJKuB0DOp9+19ocyVnKQHAAPZ1/v1CTY1XqJA= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1784929630; c=relaxed/simple; bh=JOTMTHvNXNnDMv8cbytpWkBwOfL6IylIUcituYRfXKQ=; h=From:To:Cc:Subject:Date:Message-ID:In-Reply-To:References: MIME-Version; b=m2aWlbe8Kl9KmGhUVmtDfCAoT+Sz1xiol0Egi0Um9hNqWIR9F39xeV22IeEb9y8lWuYsRYv7gQQlbTa9b5izcQFKQuO9HJf6KL7QBqIA33EAJyc/qbDsx9c98daBAhHLaz0b+xu2aGlLbTkP6sZnimbn1QNim3Gloez1MsAWnbM= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com; spf=pass smtp.mailfrom=gmail.com; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b=FhG50KbA; arc=none smtp.client-ip=209.85.160.176 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=gmail.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="FhG50KbA" Received: by mail-qt1-f176.google.com with SMTP id d75a77b69052e-51c2cce930cso8495371cf.0 for ; Fri, 24 Jul 2026 14:47:05 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20251104; t=1784929624; x=1785534424; darn=vger.kernel.org; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to:content-type; bh=P1VNwYcQpb9WDj6KVSyLpNd/oPBMCMFNw+HEtq66+P0=; b=FhG50KbAES9Xcz+clA+Gb9RhVhvutwyqW+sG20+rANtAZHRZ21l37d4BPqx4BYMd9p 77RGJ112PgEFIhUV9jqB3JtfTBgNH4QAXGkTIAcY0312ualNEcPsI1KxYD6QNX9i+0D+ moLDoCB8Gu4r6qHDGX7d/7HAkuubeHSjD+VwnZI6ihr3ebjcZu2+05LVZ9e4kSGxDKRH MwK1JkcYU0hTDx0pWWR0B6JVTKzFmM3g/uLrr1+O0WNaN0na0zju/p1c1gaaVppgCBii zt7+/lBBKxkzyljSFeHFlFiathPwxVdFtAE/MIsMa8XP5bKYj9ufHHM8LkdwcW28NBBy O9rg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1784929624; x=1785534424; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-gg:x-gm-message-state:from :to:cc:subject:date:message-id:reply-to:content-type; bh=P1VNwYcQpb9WDj6KVSyLpNd/oPBMCMFNw+HEtq66+P0=; b=l6WGjTJZcBmNZvrw8O0IkCsQidjtN67ZfuowTVXvnGBPUfsPkkpMYTlvK9CZUgsy0c UitD441L6y9hav9A3V7QL6LFBgxIETaFFDaIK5OkH04QpBCWeN0b5xtUAauk9hLasV7s vCoV/ryuOxDb+fPpmffXN6UQkwzOIvSxZZGYOj5luuadv0rqO0/2HrC1OQQp+7oLWzxP 4P0DyX6ZhNQw51pG1MjuDP+OIMooEMwHphVZ8LIx4lIN7ubDLX54u0TClvi/Y8QR18zy bmuyEpSK4tdbgidjZLGAchLO5pJ3KjXakC16Ee849vA6v5r9/Cg0TDwu4NMQJWBwRa3N +PsA== X-Forwarded-Encrypted: i=1; AHgh+RpvybcGkWcD+4kh9vrbDcalUQ8rPrtRS3tJW2ciUMzRPeiA686xRkP0KpD/P0xh+xmX4Z313OBXaikTATA=@vger.kernel.org X-Gm-Message-State: AOJu0YzmUDRfhkU5qnA8Vq1Hsw+FG7uOWhjTLlG55gzW8pZV3FNNzGFt MDthbfWO6FwnX1ScFzYtUYSixnfm0EsDSSCM6f1bXTnmXfxhjXNvUurU X-Gm-Gg: AR+sD138+6/MIN/slbgUG525a+Nq+pbUwox3+FpBN0cKebp8V1H+2wbLbnp5VA+ntU4 6l3QtiOPo4GmApC5AGTg+nKOng2jWdzK94yBk2gxF93brBl2GWFVMQAFCDGMEsc1KajShOaipnd HPR7hf2e85gb2E/qg9o2NsfoCZFVfH6Mb94djgjWL+WPCwYZSCekPsA9y4X4MScNLGScUUqEbaN bIj04ol+TlWWSwAmYl1/bXpiFJreSQlRycz8H9OXLZ2UI+I63/BKVDAXVNJd3LXWZS3/nLlV6FX 4KHTltLwdpBs+fKTZhqNm50MlKx9OEcm0MmFNoINK19Bs1vduMrG5zwDzvOe4sppwJjhs1YSMLv wPUvJE/tC9tlPTR11cK+3DReWsB0yx57nrY0xVE8PE4FBPW88UBiNMn/BozW9Rv2UkLO1Jjdea4 kOfuAn9KTyvXs7A4fCve6wI0Jh4A== X-Received: by 2002:ac8:5e51:0:b0:51c:1568:3a53 with SMTP id d75a77b69052e-529a8337825mr1442741cf.16.1784929624076; Fri, 24 Jul 2026 14:47:04 -0700 (PDT) Received: from FredPC.lan ([2600:382:311b:26:c204:8bd0:9563:8b5f]) by smtp.gmail.com with ESMTPSA id d75a77b69052e-529a29cf785sm7916771cf.21.2026.07.24.14.47.01 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Fri, 24 Jul 2026 14:47:03 -0700 (PDT) From: Fredric Cover To: sfrench@samba.org Cc: pc@manguebit.org, ronniesahlberg@gmail.com, sprasad@microsoft.com, tom@talpey.com, bharathsm@microsoft.com, linux-cifs@vger.kernel.org, linux-kernel@vger.kernel.org, Fredric Cover , stable@vger.kernel.org Subject: [PATCH v2 2/2] smb: client: clear ce->tgthint in free_tgts() Date: Fri, 24 Jul 2026 14:44:35 -0700 Message-ID: <20260724214435.1850384-3-fredric.cover.lkernel@gmail.com> X-Mailer: git-send-email 2.53.0 In-Reply-To: <20260724214435.1850384-1-fredric.cover.lkernel@gmail.com> References: <20260724023539.1596955-1-fredric.cover.lkernel@gmail.com> <20260724214435.1850384-1-fredric.cover.lkernel@gmail.com> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: 8bit When free_tgts() frees all structures in ce->tlist, ce->tgthint is left pointing to one of the freed cache_dfs_tgt structures. If ce->tgthint is not reset before it is used later, it results in a use-after-free. Set ce->tgthint to NULL in free_tgts() after the elements are freed to reflect that no elements remain. Fixes: 54be1f6c1c37 ("cifs: Add DFS cache routines") Cc: stable@vger.kernel.org # depends on: smb: client: harden DFS cache against invalid target hints Signed-off-by: Fredric Cover --- fs/smb/client/dfs_cache.c | 2 ++ 1 file changed, 2 insertions(+) diff --git a/fs/smb/client/dfs_cache.c b/fs/smb/client/dfs_cache.c index c9ace4326a35..86dba25b7a5a 100644 --- a/fs/smb/client/dfs_cache.c +++ b/fs/smb/client/dfs_cache.c @@ -122,6 +122,8 @@ static inline void free_tgts(struct cache_entry *ce) kfree(t->name); kfree(t); } + + WRITE_ONCE(ce->tgthint, NULL); } static inline void flush_cache_ent(struct cache_entry *ce) -- 2.53.0