From: Joshua Crofts <joshua.crofts1@gmail.com>
To: Jonathan Cameron <jic23@kernel.org>
Cc: "David Lechner" <dlechner@baylibre.com>,
"Nuno Sá" <nuno.sa@analog.com>,
"Andy Shevchenko" <andy@kernel.org>,
"Rob Herring" <robh@kernel.org>,
"Krzysztof Kozlowski" <krzk+dt@kernel.org>,
"Conor Dooley" <conor+dt@kernel.org>,
linux-iio@vger.kernel.org, devicetree@vger.kernel.org,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH 2/2] iio: dac: mcp47a1: add support for new device
Date: Sat, 25 Jul 2026 12:17:28 +0200 [thread overview]
Message-ID: <20260725121728.17ddbc7a@systembl0wer> (raw)
In-Reply-To: <20260725001417.159653b8@jic23-huawei>
On Sat, 25 Jul 2026 00:14:17 +0100
Jonathan Cameron <jic23@kernel.org> wrote:
> Given the really small number of registers, regmap does seem like
> it might be overkill
My thought was that regmap is preferred over i2c_smbus_* functions,
but that is a simple enough move.
...
> > + /*
> > + * This is a volatile DAC which doesn't have an ID register, instead
> > + * the value register is set to 0x20 every Power-on-Reset (table 4-1).
> > + * Any other read value at startup could indicate that the device is
> > + * damaged etc.
>
> or some earlier software wrote it and the all the regulators are stubs
> provided as they can't be turned off by software.
>
> I'd drop this test - it is a bit too flakey as a way to tell the chip
> is there and working.
Yeah, fair enough, there's a reason why it just reports it as dev_info().
--
Kind regards,
Joshua Crofts
prev parent reply other threads:[~2026-07-25 10:17 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-07-21 18:24 [PATCH 0/2] iio: dac: mcp47a1: add support for new device Joshua Crofts
2026-07-21 18:24 ` [PATCH 1/2] dt-bindings: iio: dac: add support for mcp47a1 Joshua Crofts
2026-07-22 16:47 ` Conor Dooley
2026-07-24 23:04 ` Jonathan Cameron
2026-07-24 23:04 ` Jonathan Cameron
2026-07-25 8:12 ` Joshua Crofts
2026-07-25 15:41 ` David Lechner
2026-07-21 18:24 ` [PATCH 2/2] iio: dac: mcp47a1: add support for new device Joshua Crofts
2026-07-21 20:47 ` Andy Shevchenko
2026-07-22 6:30 ` Joshua Crofts
2026-07-24 23:14 ` Jonathan Cameron
2026-07-25 10:17 ` Joshua Crofts [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20260725121728.17ddbc7a@systembl0wer \
--to=joshua.crofts1@gmail.com \
--cc=andy@kernel.org \
--cc=conor+dt@kernel.org \
--cc=devicetree@vger.kernel.org \
--cc=dlechner@baylibre.com \
--cc=jic23@kernel.org \
--cc=krzk+dt@kernel.org \
--cc=linux-iio@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=nuno.sa@analog.com \
--cc=robh@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox