From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mx0b-001b2d01.pphosted.com (mx0b-001b2d01.pphosted.com [148.163.158.5]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 68CAF2C0296; Sun, 26 Jul 2026 04:01:38 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=148.163.158.5 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1785038501; cv=none; b=J5M6IRmaA99tDRhid5l+fmGn4g1xBf3tcmgTvdMXOPoVk6Ishaz24lrNMb06UFXDL5WND5tMVIg7S2mjH2XnRi4KYRKgjXhUbnIokmV/jVvY0OosX3D4Ev64cQtB+4J+C+o28APwJ2sWJoCjIUPo0afnIX0GBsNC6y05EF263Z4= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1785038501; c=relaxed/simple; bh=lVjpjGvCnCtg6znm54RXtp0Nwu0azhoegBpcI0PIeIo=; h=From:To:Cc:Subject:Date:Message-ID:In-Reply-To:References: MIME-Version; b=aGu3DkkPoPSXcx8S5yv3+0cCSAdTynetKTTDg7tBUsEQ6MgAP4nHpuE+N9el5lMP4Ey/ppr6s+lMRa4WksmXNZ3TlSRrEcBx9Keojs/TowUC054gR8PhI4sdhuLBTrY3GopibaTq6UCXh1vxQvEE52T8bz0We78S+H/X1CUNgFw= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=linux.ibm.com; spf=pass smtp.mailfrom=linux.ibm.com; dkim=pass (2048-bit key) header.d=ibm.com header.i=@ibm.com header.b=oVex1++1; arc=none smtp.client-ip=148.163.158.5 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=linux.ibm.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=linux.ibm.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=ibm.com header.i=@ibm.com header.b="oVex1++1" Received: from pps.filterd (m0356516.ppops.net [127.0.0.1]) by mx0a-001b2d01.pphosted.com (8.18.1.11/8.18.1.11) with ESMTP id 66PNHrOT1833800; Sun, 26 Jul 2026 04:01:37 GMT DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=ibm.com; h=cc :content-transfer-encoding:date:from:in-reply-to:message-id :mime-version:references:subject:to; s=pp1; bh=04a/oSfpUZSMQvvmM iSha2GTCDoHC/1awVKtqsvbuas=; b=oVex1++1e+zF1fgmX2BgZNicp2K/9Vzui A2BkJbH9ezDDpiSQ2REFYgGHcYdhhu93rWtMR1YO30VbIkuTnHXS0yx/Icq8VgOl mRrWQOQpp8q7JLMc+tpcXln3QUph3KTpCQf1iGtkEtTpS5RPBFd3utI6GnLqB2sQ 1/V+yx5pdR8GMT8ezNuGCFinlSyHVmE8mktBxWFYvqpArLJDieqESB43U535iYgi DWlYfv2sIYY7qsuxH24bONKRGvswWZv6MC+GiPk+WnZoDCz2K/E5lGABD3Ldywcl jxfpeiIRIAAfHaMzhYJaSfEEDSAQg+ObFat8KL2n97drZ/oR1fCxA== Received: from ppma22.wdc07v.mail.ibm.com (5c.69.3da9.ip4.static.sl-reverse.com [169.61.105.92]) by mx0a-001b2d01.pphosted.com (PPS) with ESMTPS id 4fmuyht7st-1 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=NOT); Sun, 26 Jul 2026 04:01:37 +0000 (GMT) Received: from pps.filterd (ppma22.wdc07v.mail.ibm.com [127.0.0.1]) by ppma22.wdc07v.mail.ibm.com (8.18.1.7/8.18.1.7) with ESMTP id 66Q3uQTh009478; Sun, 26 Jul 2026 04:01:36 GMT Received: from smtprelay05.fra02v.mail.ibm.com ([9.218.2.225]) by ppma22.wdc07v.mail.ibm.com (PPS) with ESMTPS id 4fn7uvrepk-1 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=NOT); Sun, 26 Jul 2026 04:01:36 +0000 (GMT) Received: from smtpav04.fra02v.mail.ibm.com (smtpav04.fra02v.mail.ibm.com [10.20.54.103]) by smtprelay05.fra02v.mail.ibm.com (8.14.9/8.14.9/NCO v10.0) with ESMTP id 66Q41Ww049480188 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-GCM-SHA384 bits=256 verify=OK); Sun, 26 Jul 2026 04:01:32 GMT Received: from smtpav04.fra02v.mail.ibm.com (unknown [127.0.0.1]) by IMSVA (Postfix) with ESMTP id 9E965200FB; Sun, 26 Jul 2026 04:01:32 +0000 (GMT) Received: from smtpav04.fra02v.mail.ibm.com (unknown [127.0.0.1]) by IMSVA (Postfix) with ESMTP id 7108720101; Sun, 26 Jul 2026 04:01:32 +0000 (GMT) Received: from tuxmaker.boeblingen.de.ibm.com (unknown [9.87.85.9]) by smtpav04.fra02v.mail.ibm.com (Postfix) with SMTP; Sun, 26 Jul 2026 04:01:32 +0000 (GMT) Received: by tuxmaker.boeblingen.de.ibm.com (Postfix, from userid 4958) id 30379162824; Sun, 26 Jul 2026 06:01:32 +0200 (CEST) From: Eric Farman To: linux-s390@vger.kernel.org, kvm@vger.kernel.org, linux-kernel@vger.kernel.org Cc: Matthew Rosato , Halil Pasic , Christian Borntraeger , Eric Farman , stable@vger.kernel.org, Farhan Ali Subject: [PATCH v5 10/10] s390/vfio_ccw: implement a crw lock Date: Sun, 26 Jul 2026 06:01:29 +0200 Message-ID: <20260726040129.2946151-11-farman@linux.ibm.com> X-Mailer: git-send-email 2.53.0 In-Reply-To: <20260726040129.2946151-1-farman@linux.ibm.com> References: <20260726040129.2946151-1-farman@linux.ibm.com> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable X-TM-AS-GCONF: 00 X-Proofpoint-Spam-Info: AW1haW4tMjYwNzI2MDAzMyBTYWx0ZWRfX9UpETY0fa7hE 3BBNaXCJb40RvUdMVLmkSe6fue64t/GB89MtnjrOFfbqgVVjtBZkxtdWl5Or6erKd3OC4VK9Q4d zULdkbf/O07XELTOeqbLU+kxLt6+rok= X-Proofpoint-GUID: XE8DuyYFJvv5SVI-I0i2rLE1JaY4b0Uu X-Proofpoint-ORIG-GUID: XE8DuyYFJvv5SVI-I0i2rLE1JaY4b0Uu X-Proofpoint-Spam-Details-Enc: AW1haW4tMjYwNzI2MDAzMyBTYWx0ZWRfXzOndAf6RSLqY Nch+/+LUU3tYuUv5mnYK0ECBsNyRYHa2/kUaBPc+Olg/Oq6KqecJVEHsUGPVUMKk0iGcmtl3wkC 09Z/SZSr8oAlw7Il5drPf1xmdynWg2/1yFuow4gEPTyO9jJ2c+ZWniCZfkMRkrCEkmWYp9R/Jou +mDEz22RcDYPP9xof6d4UVb894ixEh6FuvO797+aQTpwf48Znlz4k4vMUR5GQXHu762dNVtPPac azzGkA6fXLqTBP8U5N+ClhlkD68R49ZVwxgbhjijln3bI3I9Sx83qUePje34J8X8xxikv0gFluW 4qiTpS2btq6q1aQQuFVz3ux50ivo3Il+DfgucyXXddkLwJbkWwEGR+az/Bh4gg+Y0zp8mreB9qv P04KckcYH54bPUkRx+6WURSWoSDJ9aujeHdOXCjP7dChlmeqrbzQ6wawFZmbOcFqxW+yo2O57AV rDdkNWrJ203KQtPgYYA== X-Authority-Analysis: v=2.4 cv=X5Vi7mTe c=1 sm=1 tr=0 ts=6a6586a1 cx=c_pps a=5BHTudwdYE3Te8bg5FgnPg==:117 a=5BHTudwdYE3Te8bg5FgnPg==:17 a=RAioF0-LDSMA:10 a=VkNPw1HP01LnGYTKEx00:22 a=RnoormkPH1_aCDwRdu11:22 a=Y2IxJ9c9Rs8Kov3niI8_:22 a=VwQbUJbxAAAA:8 a=VnNF1IyMAAAA:8 a=huIa1HNm52ewcn7HQvQA:9 X-Proofpoint-Virus-Version: vendor=baseguard engine=ICAP:2.0.293,Aquarius:18.0.1143,Hydra:6.1.134,FMLib:17.12.100.49 definitions=2026-07-25_07,2026-07-24_02,2025-10-01_01 X-Proofpoint-Spam-Details: rule=outbound_notspam policy=outbound score=0 clxscore=1015 impostorscore=0 lowpriorityscore=0 phishscore=0 priorityscore=1501 malwarescore=0 spamscore=0 suspectscore=0 bulkscore=0 adultscore=0 classifier=typeunknown authscore=0 authtc= authcc= route=outbound adjust=0 reason=mlx scancount=1 engine=8.22.0-2606150000 definitions=main-2607260033 Unlike the channel_program struct, which covers synchronous I/O submissions and asynchronous interrupts, the CRW region relies exclusively on asynchronous events coming from hardware. Implement a lock to manage the list of those payloads, to ensure they are read cohesively. Fixes: 3f02cb2fd9d2 ("vfio-ccw: Wire up the CRW irq and CRW region") Cc: stable@vger.kernel.org Cc: Farhan Ali Reviewed-by: Matthew Rosato Signed-off-by: Eric Farman --- drivers/s390/cio/vfio_ccw_chp.c | 26 ++++++++++++++++---------- drivers/s390/cio/vfio_ccw_drv.c | 6 ++++++ drivers/s390/cio/vfio_ccw_ops.c | 4 ++++ drivers/s390/cio/vfio_ccw_private.h | 4 ++++ 4 files changed, 30 insertions(+), 10 deletions(-) diff --git a/drivers/s390/cio/vfio_ccw_chp.c b/drivers/s390/cio/vfio_ccw_= chp.c index f3015132d4b5..7708eb4d6de0 100644 --- a/drivers/s390/cio/vfio_ccw_chp.c +++ b/drivers/s390/cio/vfio_ccw_chp.c @@ -93,17 +93,12 @@ static ssize_t vfio_ccw_crw_region_read(struct vfio_c= cw_private *private, loff_t pos =3D *ppos & VFIO_CCW_OFFSET_MASK; struct ccw_crw_region *region; struct vfio_ccw_crw *crw; + unsigned long flags; int ret; =20 if (pos + count > sizeof(*region)) return -EINVAL; =20 - crw =3D list_first_entry_or_null(&private->crw, - struct vfio_ccw_crw, next); - - if (crw) - list_del(&crw->next); - mutex_lock(&private->io_mutex); if (i >=3D private->num_regions) { ret =3D -EINVAL; @@ -113,6 +108,16 @@ static ssize_t vfio_ccw_crw_region_read(struct vfio_= ccw_private *private, i =3D array_index_nospec(i, private->num_regions); region =3D private->region[i].data; =20 + spin_lock_irqsave(&private->crw_lock, flags); + crw =3D list_first_entry_or_null(&private->crw, + struct vfio_ccw_crw, next); + + if (crw) + list_del(&crw->next); + + /* Drop CRW lock while copying to userspace */ + spin_unlock_irqrestore(&private->crw_lock, flags); + if (crw) memcpy(®ion->crw, &crw->crw, sizeof(region->crw)); =20 @@ -122,15 +127,16 @@ static ssize_t vfio_ccw_crw_region_read(struct vfio= _ccw_private *private, ret =3D count; =20 region->crw =3D 0; - -out: - mutex_unlock(&private->io_mutex); - kfree(crw); =20 /* Notify the guest if more CRWs are on our queue */ + spin_lock_irqsave(&private->crw_lock, flags); if (!list_empty(&private->crw) && private->crw_trigger) eventfd_signal(private->crw_trigger); + spin_unlock_irqrestore(&private->crw_lock, flags); + +out: + mutex_unlock(&private->io_mutex); =20 return ret; } diff --git a/drivers/s390/cio/vfio_ccw_drv.c b/drivers/s390/cio/vfio_ccw_= drv.c index 4830f0dd9c3a..437d7709b4a5 100644 --- a/drivers/s390/cio/vfio_ccw_drv.c +++ b/drivers/s390/cio/vfio_ccw_drv.c @@ -122,11 +122,14 @@ void vfio_ccw_sch_io_todo(struct work_struct *work) void vfio_ccw_crw_todo(struct work_struct *work) { struct vfio_ccw_private *private; + unsigned long flags; =20 private =3D container_of(work, struct vfio_ccw_private, crw_work); =20 + spin_lock_irqsave(&private->crw_lock, flags); if (!list_empty(&private->crw) && private->crw_trigger) eventfd_signal(private->crw_trigger); + spin_unlock_irqrestore(&private->crw_lock, flags); } =20 void vfio_ccw_notoper_todo(struct work_struct *work) @@ -290,6 +293,7 @@ static void vfio_ccw_queue_crw(struct vfio_ccw_privat= e *private, unsigned int rsid) { struct vfio_ccw_crw *crw; + unsigned long flags; =20 /* * If unable to allocate a CRW, just drop the event and @@ -307,7 +311,9 @@ static void vfio_ccw_queue_crw(struct vfio_ccw_privat= e *private, crw->crw.erc =3D erc; crw->crw.rsid =3D rsid; =20 + spin_lock_irqsave(&private->crw_lock, flags); list_add_tail(&crw->next, &private->crw); + spin_unlock_irqrestore(&private->crw_lock, flags); queue_work(vfio_ccw_work_q, &private->crw_work); } =20 diff --git a/drivers/s390/cio/vfio_ccw_ops.c b/drivers/s390/cio/vfio_ccw_= ops.c index b8e702f36106..2e2b05b78073 100644 --- a/drivers/s390/cio/vfio_ccw_ops.c +++ b/drivers/s390/cio/vfio_ccw_ops.c @@ -61,6 +61,7 @@ static int vfio_ccw_mdev_init_dev(struct vfio_device *v= dev) INIT_WORK(&private->io_work, vfio_ccw_sch_io_todo); INIT_WORK(&private->crw_work, vfio_ccw_crw_todo); INIT_WORK(&private->notoper_work, vfio_ccw_notoper_todo); + spin_lock_init(&private->crw_lock); =20 private->cp.guest_cp =3D kzalloc_objs(struct ccw1, CCWCHAIN_LEN_MAX); if (!private->cp.guest_cp) @@ -138,11 +139,14 @@ static void vfio_ccw_mdev_release_dev(struct vfio_d= evice *vdev) struct vfio_ccw_private *private =3D container_of(vdev, struct vfio_ccw_private, vdev); struct vfio_ccw_crw *crw, *temp; + unsigned long flags; =20 + spin_lock_irqsave(&private->crw_lock, flags); list_for_each_entry_safe(crw, temp, &private->crw, next) { list_del(&crw->next); kfree(crw); } + spin_unlock_irqrestore(&private->crw_lock, flags); =20 cancel_work_sync(&private->io_work); cancel_work_sync(&private->crw_work); diff --git a/drivers/s390/cio/vfio_ccw_private.h b/drivers/s390/cio/vfio_= ccw_private.h index b595fd81f370..dd8efa9ee64e 100644 --- a/drivers/s390/cio/vfio_ccw_private.h +++ b/drivers/s390/cio/vfio_ccw_private.h @@ -98,6 +98,8 @@ struct vfio_ccw_parent { * @cp: channel program for the current I/O operation * @irb: irb info received from interrupt * @scsw: scsw info + * @crw_lock: serialization of CRW list information + * @crw: list of Channel Report Word elements * @io_trigger: eventfd ctx for signaling userspace I/O results * @crw_trigger: eventfd ctx for signaling userspace CRW information * @req_trigger: eventfd ctx for signaling userspace to return device @@ -122,6 +124,8 @@ struct vfio_ccw_private { =20 struct irb irb; union scsw scsw; + + spinlock_t crw_lock; struct list_head crw; =20 struct eventfd_ctx *io_trigger; --=20 2.53.0