From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail-pj1-f46.google.com (mail-pj1-f46.google.com [209.85.216.46]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 0D4DA37BE7B for ; Sun, 26 Jul 2026 07:22:09 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.216.46 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1785050531; cv=none; b=TZsv2sGpqg4cQNP7FqavBSSbItmqkehtCpRJ68iUqjhOIfemescLoLr6vi4r1TDu5BG/HEQkgtz7zLWU5ydmC3w+BoxhgiGYCugQv2XR+2Uk9bi/ZVJJteDxTei2+TRq9pYjlfVbYSNmu7mRYxZE2zqpqyCFnaeSG6vqzsa2zl8= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1785050531; c=relaxed/simple; bh=9YdF7VtUk93wE3RUV2zubH7yeqANqyDs1m7M72OfWvY=; h=From:To:Cc:Subject:Date:Message-ID:In-Reply-To:References: MIME-Version; b=g8OH49nRE0UAmPS4rPsHod0e/ea8vR/jdb+x1GwvyfjcQehUcWIAZLU9x3/iNpz5XdUsBbIsNMiMH5PtGxls2Dvdel56Q/T2zMuS0H2A64L1XmTf1htFa9lq8aVJ7IPsAtU1kiDRaD8zc5AV1PIbMyYdeNqSILsWlPE9XUtrpv4= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com; spf=pass smtp.mailfrom=gmail.com; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b=Bm0AjHF2; arc=none smtp.client-ip=209.85.216.46 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=gmail.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="Bm0AjHF2" Received: by mail-pj1-f46.google.com with SMTP id 98e67ed59e1d1-381c51fde6bso1859830a91.2 for ; Sun, 26 Jul 2026 00:22:09 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20251104; t=1785050529; x=1785655329; darn=vger.kernel.org; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to:content-type; bh=7ENoTudciWfZXDbiO/tf9eCRNiHySqLhLqWo+aRa4n4=; b=Bm0AjHF2me3cjPdbG6kc06GzyhNG3lvmY6xjCUmk28DLrJSEZe3o/MNWSSAW82b7Mx oluZ+Cr5zWqr543iJ/XEsBZGO8xddF6wyUU09e9vDrSIGLukEUyODQMkbKyD7lEfub6q obcjbUDMnKIHaUExsFyH6q0EAvLc6/9z337lBC7qh9j7GATqS+DLhAvd7cSjltkk0R+q 4p0Niu0HR6pid+UoBxoMbNuj6kRj9eWZYEb9JKpyA+fzPb6IOi29u3PJmtFMMTyc5w7+ RAq4Hij3u4BkYPZod5X20A/sVp1cefzkUw4xHu2kSyKqoOx06GEkW2LFGJX+JfMt44HR QLjQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1785050529; x=1785655329; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-gg:x-gm-message-state:from :to:cc:subject:date:message-id:reply-to:content-type; bh=7ENoTudciWfZXDbiO/tf9eCRNiHySqLhLqWo+aRa4n4=; b=WLVNGrTDs6tQ/usyFMZNo6uTiTmizng7H3YCrXpFzPtoKVIR7NZHYuua2PBjG5I8VW CrIl/tGIbicsOKgUM0D1k39f/zD/14NBssAK/8Ij5X1umBPoIP+xPrPkmy+hzH1LNlUB LcoRATTFmN8l0DRHImX1EFIoBWkz7lDhIQior2B+mKY1ltFJTIgA/nVXFWt4T7W0EN6p 0Qp1Y1mBQx5//F0cBIMKi1NPriXgoxn4gvleO3ayIS2OnoLT/TrULtWxhtr77gn0yXKw yC+g9WfqWjeevrCM5+mVkt2rcH1BZKzHkwIOQlEal5LiG6Z6AautFDi2JQDW5Z8D+vAa QqCw== X-Forwarded-Encrypted: i=1; AHgh+RqZGDnbmd0E8Q5ZUBinSzioz8u30Yhvzt/XbdWEUq+NutBAlHpM3DkW2RcL49N8E02RVlp87CFRRcTAwFQ=@vger.kernel.org X-Gm-Message-State: AOJu0YzxE0yNRL7hmabvVmrMXldHTsj0bpl9niSzqPThM9TJqEVtCijT H98NqgqwpPMhyqlzf/4x1rdS/AiOB4zPl9QlRj8JW5btwfspmKiC1Lkh X-Gm-Gg: AR+sD10o8qxPccD8KdAAA3NktSA7sY89k7/k1IO0NgX9iMTRmwEwA/w33C91u8pLamv 0fjxqrv8yDMUZ/luCwNwnWnrwcAu66DLDGrQrLFiuyG+/VEjPXKzQPjsliLmIRH0F2wsf2KNuSR iMknq9fERvqnTqIMGgt5Zx+xTpvJYztoytvdEHE9t7h48Z7l8bKQzlOxELCw0n17keeSCDCdoYR ZUlJMyIw5rNsRJPjpjqba7c9IuwQ7JPcJwH8CUqxZ4Adp5NxkP1pmM4KLYBs0EUt5lS6Q2X7Akw Pnt4flFId1Y9bWvf9Co9EmiDMBuOc1P60ENF3gbDbbyuXdtfuENRYTq3Ovt8fUlKk06iDk7b9lf 9CYfigIKP9wYu4d8Xy2lWZfTFEB9RN3nkTnYcCv2Bu7YIXzurpLGPApyFNCykIY8W7gJACq3eXG n2Eg== X-Received: by 2002:a17:90a:e7d2:b0:38d:e5d0:9bd with SMTP id 98e67ed59e1d1-38f296189d8mr4644570a91.26.1785050529254; Sun, 26 Jul 2026 00:22:09 -0700 (PDT) Received: from kdev.. ([108.180.130.139]) by smtp.gmail.com with ESMTPSA id 98e67ed59e1d1-38f294e1ab1sm1489074a91.10.2026.07.26.00.22.08 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Sun, 26 Jul 2026 00:22:09 -0700 (PDT) From: Babanpreet Singh To: Sebastian Reichel Cc: linux-pm@vger.kernel.org, linux-kernel@vger.kernel.org, Babanpreet Singh Subject: [PATCH 2/2] power: supply: sbs-battery: Bound the serial number conversion to 16 bits Date: Sun, 26 Jul 2026 07:22:06 +0000 Message-ID: <20260726072206.7-3-bbnpreetsingh@gmail.com> X-Mailer: git-send-email 2.47.3 In-Reply-To: <20260726072206.7-1-bbnpreetsingh@gmail.com> References: <20260726072206.7-1-bbnpreetsingh@gmail.com> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: 8bit The SBS SerialNumber register is a 16-bit word and chip->serial[] is sized for its four hex digits plus the NUL terminator. The value is carried in an int, though, and only the negative half of that range is rejected before the conversion, so the compiler has to assume [0, INT_MAX] - up to eight digits: drivers/power/supply/sbs-battery.c:835:32: warning: '%04x' directive writing between 4 and 8 bytes into a region of size 5 [-Wformat-overflow=] drivers/power/supply/sbs-battery.c:835:31: note: directive argument in the range [0, 2147483647] drivers/power/supply/sbs-battery.c:835:9: note: 'sprintf' output between 5 and 9 bytes into a destination of size 5 The overflow is not reachable: sbs_read_word_data() returns the result of i2c_smbus_read_word_data(), which yields at most 0xffff on success, and negative returns are rejected just above. Cast to u16 to state the register width at the point of use, which also lets the compiler prove the buffer is large enough. No functional change. This is the only W=1 warning in this driver. Assisted-by: Claude:claude-opus-5 Signed-off-by: Babanpreet Singh --- drivers/power/supply/sbs-battery.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/power/supply/sbs-battery.c b/drivers/power/supply/sbs-battery.c index 9bdb6c599c5f..8f839b2cc353 100644 --- a/drivers/power/supply/sbs-battery.c +++ b/drivers/power/supply/sbs-battery.c @@ -832,7 +832,7 @@ static int sbs_get_battery_serial_number(struct i2c_client *client, if (ret < 0) return ret; - sprintf(chip->serial, "%04x", ret); + sprintf(chip->serial, "%04x", (u16)ret); val->strval = chip->serial; return 0; -- 2.43.0