From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail-wr1-f54.google.com (mail-wr1-f54.google.com [209.85.221.54]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 43F65309DB5 for ; Mon, 27 Jul 2026 07:07:24 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.221.54 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1785136045; cv=none; b=toMF0kZH0c9TBfqQRTpq0D8/wO99Mfh27LbXtWj/Mum31KJSuqmmcaLXGrufqd9fFeDD/EwtVhANOxtz7CuQUpEh1UliKbHwdmyYQncu/QV6zX1qyz8j/w/u6NywQz9qKzc3E+AVQ+MpDphGPpD7t2jZAvJU9mYAG9hgBn5liuc= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1785136045; c=relaxed/simple; bh=9pTGhlTmlIKGhwr3wvxYizndPJLOqZo1bmmXWszlNcA=; h=Date:From:To:Cc:Subject:Message-ID:In-Reply-To:References: MIME-Version:Content-Type; b=C6Pz575ULsQRi/lqZLGhU9BQayDz6XTJQ1oqlMJPPjFBA/r/5BYHBO1kQ1Zd6xNnRlFL93y/l1J89yyDKeHNrs3ppsMPblZJl5VaCenJkqRYgLqaUlCMLeU0q6ooixxWymtYj05C4hEbNZ4t9VvD/F6HytktCaMUgLCYgK+qdzE= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com; spf=pass smtp.mailfrom=gmail.com; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b=g62AQfyR; arc=none smtp.client-ip=209.85.221.54 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=gmail.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="g62AQfyR" Received: by mail-wr1-f54.google.com with SMTP id ffacd0b85a97d-47ddf7b09e5so2414176f8f.1 for ; Mon, 27 Jul 2026 00:07:24 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20251104; t=1785136042; x=1785740842; darn=vger.kernel.org; h=content-transfer-encoding:content-type:mime-version:references :in-reply-to:message-id:subject:cc:to:from:date:from:to:cc:subject :date:message-id:reply-to:content-type; bh=oUPot/fwY6gLD+qftqL8dQWQ2hoz4VMz3cCKQQaaJdU=; b=g62AQfyRn5Js2/cUFpnDwfrvjo7GBRXsMxJC5be1CIaTHfrdetjSNNL99cimOUwXqK u1+uIA17uv+7wPL3kn91MmnIijtjYny+CsHYgsV+HGXIzlOn9dsI/qQZIxD72PWejgWs IKwfCwwxEE4nW8EuJmn4NTXk+hNdsk6L4OMFkw5NEU0PWWrafZ4y3/lmSM8BPPbev2uE H+FQe9UvvSCYd+BRnxqYKdzEu1lxyhZ+zhnhYbhpw8z2G4wxr3U74VSXsf2YFjCm2TBP /J0I9ML/LFnM+kGYM9zrxRnO90P9lbLpj1xaJiKhVFmLLRtpzjealb9wIeSStCgyCU5d yKTg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1785136042; x=1785740842; h=content-transfer-encoding:content-type:mime-version:references :in-reply-to:message-id:subject:cc:to:from:date:x-gm-gg :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to :content-type; bh=oUPot/fwY6gLD+qftqL8dQWQ2hoz4VMz3cCKQQaaJdU=; b=JqHwqdbQtzeYsjt6ucWtUrbB110RfU5VRk+l8sIbOV3jD86c04YjvwDg9BqElDKYJB I7fwRGpY+1NfNDIR9opoSUfwGQxAaGI2rkecLBi7m2kkh1N/TicpDUbnQS7wvYyQPdqT m5AYu1+PiKaOriizKKM8PHmHeJrF4m7fWZCJ3fEgTfyTggagyDdEO5mYPVWJhhX5DfAJ AunOC7yquAtGjPttvt09OSwqroT8CdQYgxdCpSH9+gdf/D0Y7VCQSXjf0BkjninQHa3i +STCMKjPvJ/69E1dJyl11Z3LoGdgQ7006tiAGPvkr11ciLK7Iz86Vr1Rg3HufrYE0LQX qTDQ== X-Forwarded-Encrypted: i=1; AHgh+RpI3hAJs3vYswhsjkoLwpBjQ/V7rotauSbbc2HejTSmLGaBqdUUsdl5y05j2cZOcbb5b4xgWICse8V1O6g=@vger.kernel.org X-Gm-Message-State: AOJu0Yyl87RCnMwy3wHNiyR/XEoYAx20X3qTKRvL/eQcRXopoiSc8GeV vhtGUPjdgfi/snt+Fqz1wy9pTgpqgE2nsdMt2DVwS/WO9UXuqdqBt4JdfNC/tg== X-Gm-Gg: AR+sD1305KRlzEqDH1u5IekhoGF3G9o3FfUjqT6KCveQyIGz0TCye3p1G/dWxevAOQJ Piz6FBSqjUG6BFLM5deFt3+JNPAPU2CfMhqLGHijIkeojQGp6uMhsJ5t/LgrcskLb43S0ajW1lI kaZ9coZxT1YTXrLA/TqVOn9ooDR7VcsvgFRJEjftdUmj0CIe9gydaFbYW461yg8fFnf+buHgSXq L0Qb7XXwaoJpQngpYrNViuOKPAfxVtVMOuVx0oLOu4okLgFD+woKF+A1Hh0Dm+09LykCU72Gast agH1STvWzd7hipnK0l2nmBzIsBJOlU1yq8UHTyI5SOtmOstLP4pp9mDhUFTQitL//+hJHmE5koZ TvmzwxSzKqCYH7jD2j+1t0ZT8Cofz5QXl/DPT0cda381lm+uoFF5sk0+jx56FvWrkH6iJ6KQe3r 3SGjvmcaJRXjx+2IEB48qLuS11E5zXWAJnEZr62SeAGd69vA7jA9ibZ4YIC9OF2CjufE7xccic3 O2W2jeYdvpRwiGMGGUZoG5WWuO9d/x+ReHoKfDXbcbgj7u4bBpmvW3JL3X6v4EzmceROgyoht/E RwMy3hTtV4T+N5DZlE9g6evs3GscyqKnoXBKDSzlaCgk/ed6TH7NkUVBhABf/FCf7lwAKHzVFMk IxAy51KngSjf9 X-Received: by 2002:a05:6000:2508:b0:47f:7427:8ce9 with SMTP id ffacd0b85a97d-47f9fea2a71mr9363447f8f.51.1785136042358; Mon, 27 Jul 2026 00:07:22 -0700 (PDT) Received: from localhost (90-182-112-124.rcp.o2.cz. [90.182.112.124]) by smtp.gmail.com with ESMTPSA id ffacd0b85a97d-47f85b9a6d7sm46444037f8f.2.2026.07.27.00.07.21 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 27 Jul 2026 00:07:22 -0700 (PDT) Date: Mon, 27 Jul 2026 09:07:22 +0200 From: Joshua Crofts To: Jonathan Cameron Cc: David Lechner , Nuno =?ISO-8859-1?Q?S=E1?= , Andy Shevchenko , linux-iio@vger.kernel.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH 1/2] iio: light: veml3328: remove unused i2c_set_clientdata() Message-ID: <20260727090722.0000031f@gmail.com> In-Reply-To: <20260726201525.0aec2c28@jic23-huawei> References: <20260724-veml3328-cleanup-v1-0-240ecf3e5097@gmail.com> <20260724-veml3328-cleanup-v1-1-240ecf3e5097@gmail.com> <20260726201525.0aec2c28@jic23-huawei> X-Mailer: Claws Mail 4.4.0 (GTK 3.24.51; x86_64-w64-mingw32) Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit On Sun, 26 Jul 2026 20:15:25 +0100 Jonathan Cameron wrote: > On Fri, 24 Jul 2026 00:07:08 +0200 > Joshua Crofts wrote: > > > The I2C client data is set but never used. Remove the unnecessary > > function call. > Yes it is. Take another look at how that works and how else the resulting > data is accessed (or just look at Sashiko) > > I was hoping it would catch this one :) > > The combination of different interfaces to access the same data has > been much debated over time but we never came to a conclusion on whether > it was worth the effort of stopping doing so given i2c driver reviewers > are far too familiar with this particular hole. > Ugh, I was too hasty - I read Sashiko's review a few hours later and realized what (very stupid) mistake I made. -- Kind regards, Joshua Crofts