From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail-pf1-f170.google.com (mail-pf1-f170.google.com [209.85.210.170]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 2DD713EFD3D for ; Mon, 27 Jul 2026 09:42:55 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.210.170 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1785145382; cv=none; b=Cyr9ynIIlfVJNhj+9KJkYleDFp8RNtqFK3QgN+PBIuaetGu5T4yjKYIffQCJBgsGDxEBfuQHaJpCswcuzTq198XcGg+JGw1RwsyhFj8RcX66DrOihF0JY1+SFj7+DPyp/02aJ1mUu8LVVPQIBafGeEJ9vTwzMSECEGuSlAhXCJ4= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1785145382; c=relaxed/simple; bh=CR/lpIz867Ge5SfVg0BgnctkBifwpEVSwmWaNcKvrvs=; h=From:To:Cc:Subject:Date:Message-ID:In-Reply-To:References: MIME-Version; b=GIdTpqJPorwgeJ8LNeDQWouR7It5xyMjR0hH1gL8WJwpYrggygbrEkKRBinCnESvnYtq0VDxLwwYHQ5sX5OFN3g2xdZ/VQtpBpov1tFgd38yPx0RUUbSA3OGO5mvJkBUZfbcpPpk6Om4+O8Tr4Vyzz7AVSH3x4jOWkrQ9PvO39w= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com; spf=pass smtp.mailfrom=gmail.com; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b=bSda0Q3q; arc=none smtp.client-ip=209.85.210.170 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=gmail.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="bSda0Q3q" Received: by mail-pf1-f170.google.com with SMTP id d2e1a72fcca58-84a652535dcso1384297b3a.3 for ; Mon, 27 Jul 2026 02:42:55 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20251104; t=1785145373; x=1785750173; darn=vger.kernel.org; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to:content-type; bh=tK2T+D6HuV5arLji/rG4gtI0GorQ1z1dx7hf11H1P5k=; b=bSda0Q3qT4RWQcMU1f2socxFPzSoCmRVoHMaQ8Icr2YvA0VWEe+BCd8XMvCJOMY+Xi WUfnwQ7qcqvzPGaZxaqDxUwvjjhRmYfDn1Yynvi1PZ8LcF/OMKM3dkNXdioGGcxtjtCU xh8oHs8vvSPy35xlc8gsqAXT3rQKDFaK5BYaB838zK3hwJXW7qC32SmMFLkSF64MUw4o sdZSjfK5IsTmS/IVoVaEffg29duvi7LdtZO66za+3f4E2yEjZs9Di9kS5ECxa279CCYq YNhoQmqyMAqpgLZmgJTiPaNZBg/9o4bz77i51qhjy02mv9aVwV7J7kUXP7dsqLqZ7poR xMgQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1785145373; x=1785750173; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-gg:x-gm-message-state:from :to:cc:subject:date:message-id:reply-to:content-type; bh=tK2T+D6HuV5arLji/rG4gtI0GorQ1z1dx7hf11H1P5k=; b=eAneNaom4lhF2Z82sRMndY2H4zB8RU9j07oPXM4tBlCspK9BF2TkTxD85w/5++znEX JJRligF5OSgcmf+8yhAPsun27mAPdtWEIVdzHMNbt+neK9Te20/KcAy0srGmJuOpn0Mb adopKawu/esVCCbL1NQaMYzeXlw26CtOyP46oau99sv1shyTHoM42YAsoQGNtyCDxu4r Oo34vPA3RcWtWs3rip1pog9emNzN4cI4Isp193gSCOJZGZEnsxjR19jeupZs3Q+/8vOD UVMw7czaLtZKTA2phL345kF8pOcTvVYaj9YefVC+g4DrrtHpKkjBghXo48sexY2+2Osz bMSg== X-Forwarded-Encrypted: i=1; AHgh+RpxVXkgdR926r7ZVJ1gqU0SCxaQzlazMPS6vx+QPezXw/Ko/bfoo56jJFwhGFhgPCCDMAnXirdr/S5soDc=@vger.kernel.org X-Gm-Message-State: AOJu0Ywfy+UA6FLDR2gCEsWb1hX7IIeh8jLxgtd1NzEHg2DKLX1XxB/S 9J51ax4SJsHTijKV3WxJq0NJIHFaOsgxPonJCeDwDWKOXNFmU7kWPbEn X-Gm-Gg: AR+sD10zVKxySB39Egi+lQktpBpY946aw9jNyMNhKH9cmUyxEoKQAja6t4IqKhXEppi 0KLTIVepg3T8BsaGT7aLy00CKiuSXLD0rjUxqIUM1pCTntom5Ly2hb5oYgvfaqRVha6ywDdXKq1 BrCaLtifKcnu1AhgjTCdLQDUMDDbow0z4GbyrcpTzFky2BEsjRZgC6OfK6l9gUhMEv636puwcu6 hjF/kkM/Db4r5XwqueQ/2TtpthMvVTSErPV3d5roTCj2X0WoFkQXUkzCdPOftHedvlhxoGjI/6P 0UQCv5PxnoJxo+OwjzXGkWf9kuNnSNAAtC4Lt24JWSnfOzDtKvdT9eDPRl+/cVqWe9/FLZoFqkW NQZBQWmtVt+4eNkS7ju9EgiGqQw18oEIhAUjuhxPV5My+0wtHheRJiMk6kihlLVBubZ2Db1TDD6 6uLYle58YnPiXwtm3Nhv3EaMu8zlcZFgLgEyCJHTe92oFBEWdMiORUUasD8GZhGsJclv9Azr1x5 xweg33kyVzWdG+L0ERIrw== X-Received: by 2002:a05:6a21:2d8a:b0:3c3:a3f4:5485 with SMTP id adf61e73a8af0-3c67d9b1dc7mr7512589637.6.1785145373092; Mon, 27 Jul 2026 02:42:53 -0700 (PDT) Received: from phuc-desktop.. ([183.91.15.56]) by smtp.gmail.com with ESMTPSA id 41be03b00d2f7-cbbb66b5ffesm2959018a12.19.2026.07.27.02.42.46 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 27 Jul 2026 02:42:52 -0700 (PDT) From: phucduc.bui@gmail.com To: Mark Brown , Liam Girdwood , Jaroslav Kysela , Takashi Iwai , Lars-Peter Clausen , nuno.sa@analog.com, Shenghao Ding , Kevin Lu Cc: Baojun Xu , Sen Wang , Steven Eckhoff , Srinivas Kandagatla , Kuninori Morimoto , Charles Keepax , Linus Walleij , u.kleine-koenig@baylibre.com, Thorsten Blum , Kees Cook , Chen Ni , Bartosz Golaszewski , Shengjiu Wang , Sebastian Krzyszkowiak , Pengpeng Hou , Richard Fitzgerald , patches@opensource.cirrus.com, linux-kernel@vger.kernel.org, linux-sound@vger.kernel.org, linux-arm-msm@vger.kernel.org, bui duc phuc Subject: [PATCH v2 05/26] ASoC: codecs: tas2783: Use guard() for mutex locks Date: Mon, 27 Jul 2026 16:40:25 +0700 Message-ID: <20260727094046.23001-6-phucduc.bui@gmail.com> X-Mailer: git-send-email 2.43.0 In-Reply-To: <20260727094046.23001-1-phucduc.bui@gmail.com> References: <20260727094046.23001-1-phucduc.bui@gmail.com> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: 8bit From: bui duc phuc Clean up the code using guard() for mutex locks. Merely code refactoring, and no behavior change. Signed-off-by: bui duc phuc --- sound/soc/codecs/tas2783-sdw.c | 60 ++++++++++++++++------------------ 1 file changed, 29 insertions(+), 31 deletions(-) diff --git a/sound/soc/codecs/tas2783-sdw.c b/sound/soc/codecs/tas2783-sdw.c index db58c50e8a83..8ebed797acb5 100644 --- a/sound/soc/codecs/tas2783-sdw.c +++ b/sound/soc/codecs/tas2783-sdw.c @@ -12,6 +12,7 @@ // Author: Baojun Xu // Author: Kevin Lu +#include #include #include #include @@ -693,12 +694,12 @@ static s32 tas2783_update_calibdata(struct tas2783_prv *tas_dev) return 0; } - mutex_lock(&tas_dev->calib_lock); - ret = tas2783_validate_calibdata(tas_dev, tas_dev->cali_data.data, - tas_dev->cali_data.read_sz); - if (!ret) - tas2783_set_calib_params_to_device(tas_dev, tmp_val); - mutex_unlock(&tas_dev->calib_lock); + scoped_guard(mutex, &tas_dev->calib_lock) { + ret = tas2783_validate_calibdata(tas_dev, tas_dev->cali_data.data, + tas_dev->cali_data.read_sz); + if (!ret) + tas2783_set_calib_params_to_device(tas_dev, tmp_val); + } return ret; } @@ -927,22 +928,23 @@ static s32 tas_sdw_hw_params(struct snd_pcm_substream *substream, dev_err(tas_dev->dev, "clear latch failed, err=%d", ret); - mutex_lock(&tas_dev->pde_lock); - /* - * Sometimes, there is error returned during power on. - * So added retry logic to ensure power on so that - * port prepare succeeds - */ - do { - ret = regmap_write(tas_dev->regmap, - SDW_SDCA_CTL(1, TAS2783_SDCA_ENT_PDE23, - TAS2783_SDCA_CTL_REQ_POW_STATE, 0), - TAS2783_SDCA_POW_STATE_ON); - if (!ret) - break; - usleep_range(2000, 2200); - } while (retry--); - mutex_unlock(&tas_dev->pde_lock); + scoped_guard(mutex, &tas_dev->pde_lock) { + /* + * Sometimes, there is error returned during power on. + * So added retry logic to ensure power on so that + * port prepare succeeds + */ + do { + ret = regmap_write(tas_dev->regmap, + SDW_SDCA_CTL(1, TAS2783_SDCA_ENT_PDE23, + TAS2783_SDCA_CTL_REQ_POW_STATE, 0), + TAS2783_SDCA_POW_STATE_ON); + if (!ret) + break; + usleep_range(2000, 2200); + } while (retry--); + } + if (ret) return ret; @@ -966,7 +968,6 @@ static s32 tas_sdw_hw_params(struct snd_pcm_substream *substream, static s32 tas_sdw_pcm_hw_free(struct snd_pcm_substream *substream, struct snd_soc_dai *dai) { - s32 ret; struct snd_soc_component *component = dai->component; struct tas2783_prv *tas_dev = snd_soc_component_get_drvdata(component); @@ -975,14 +976,11 @@ static s32 tas_sdw_pcm_hw_free(struct snd_pcm_substream *substream, sdw_stream_remove_slave(tas_dev->sdw_peripheral, sdw_stream); - mutex_lock(&tas_dev->pde_lock); - ret = regmap_write(tas_dev->regmap, - SDW_SDCA_CTL(1, TAS2783_SDCA_ENT_PDE23, - TAS2783_SDCA_CTL_REQ_POW_STATE, 0), - TAS2783_SDCA_POW_STATE_OFF); - mutex_unlock(&tas_dev->pde_lock); - - return ret; + guard(mutex)(&tas_dev->pde_lock); + return regmap_write(tas_dev->regmap, + SDW_SDCA_CTL(1, TAS2783_SDCA_ENT_PDE23, + TAS2783_SDCA_CTL_REQ_POW_STATE, 0), + TAS2783_SDCA_POW_STATE_OFF); } static const struct snd_soc_dai_ops tas_dai_ops = { -- 2.43.0