From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail-pl1-f176.google.com (mail-pl1-f176.google.com [209.85.214.176]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 9B1573C1412 for ; Mon, 27 Jul 2026 10:11:37 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.214.176 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1785147099; cv=none; b=qc4i3xRXSHubP9EhIZth80MZZP+Wj8q+mpQT0jZXelg4t1EVVoxGPsvHzVTdybyGjTIROveBdmjz1FwaLfdLAn/vcAR060XHvCopiYvD771CEFoK47bRDd7bPsJHWZUMwkbGt5B++0PlCnUSaAXbX7dmfwsd319XOQHYzCqivOI= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1785147099; c=relaxed/simple; bh=W4kKHuYIhn0a0CzjI58hAjUFZcNrXpir/68Zy+q6ZWE=; h=From:To:Cc:Subject:Date:Message-ID:MIME-Version; b=fge5MvPXJ+RFMcDYVksnVAtMKg2BRGv5Hwd/VuALGHJDHLSsyLGolPYcUzJ4yJYUq2O68lBaXBeP9uw2R68oqpgpZ9HG4ckF8yb0G+ohHAQWOzxElgK9MDpoEm3CLUD+3HqWBcZAzDB/KFjQnycqhHpsFxfPOjW23HWnmEM2h2Q= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com; spf=pass smtp.mailfrom=gmail.com; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b=VRhRpbvz; arc=none smtp.client-ip=209.85.214.176 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=gmail.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="VRhRpbvz" Received: by mail-pl1-f176.google.com with SMTP id d9443c01a7336-2ceab75934dso30766365ad.2 for ; Mon, 27 Jul 2026 03:11:37 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20251104; t=1785147097; x=1785751897; darn=vger.kernel.org; h=content-transfer-encoding:mime-version:message-id:date:subject:cc :to:from:from:to:cc:subject:date:message-id:reply-to:content-type; bh=CqxpEyBKTfjNC2pGfm3K4mlLSsR7OW6H572VDTFwp8E=; b=VRhRpbvzYVCAWBCWIcjTVHq9fvTaAgL2WOVw4WoCLFBGOFkxlABQ4wwbr24dDQHj9w o7XmqhjA/5kPls90RcYbvWjYx7X33fBxTv7aZv6/7ZSae5TW0D/XOBWk1ehikMeNtj19 ONdErz29/NtYMCZkWy/QZfosriE4byX81noqj+XvvA5PgkTa54k2IhXiHzAUwjpS3iXA 9xYgBudD0yrmc7VRUZCRSrIgurUEPdhZazmO6wKgX4etEAEurgU+yrC9Sr9qjzZ25Mtu CPK1GWSOea1rH0x6AW4oGyvGqE1mGclj5Ca5y4vWL6K8hXXbug3tf1hrW7s0mDydErG/ CjIg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1785147097; x=1785751897; h=content-transfer-encoding:mime-version:message-id:date:subject:cc :to:from:x-gm-gg:x-gm-message-state:from:to:cc:subject:date :message-id:reply-to:content-type; bh=CqxpEyBKTfjNC2pGfm3K4mlLSsR7OW6H572VDTFwp8E=; b=i5fgTf1dthoLRcT94gF+9zjXgiupuYpPb3zmU6TCNK1ax/Hlu6A7iEWRLnp3xxWwj/ bHP/snNzAHWRLTqep4Uj6qsQwpCL6wDm4IMtjM3Im8MMwo+Vu3UWFulYzsMVuQUDVNd0 h+3WoVXOewYHLoysITAygpfHTg4pQIwI34So1gnjJaustidP1xrrqmUnVyi8wmRKU83k 5wr+gJGHhVQbdt6muDF8dezKIQn76en8aDV2QdYa4tQKBXCHBUmB2m9HQ2QcCOhhO+MZ 9N9Fak9XqJeilMBTSLw9ycBly7U+YfaSmkIrTNZfwqHlHRW3ZsdtRyxIePdWmf46wqQV 3Jzg== X-Forwarded-Encrypted: i=1; AHgh+RppYSSas/Qog/m3Z0VuCCmbwMALmbfNRI1vhDW7krquWeVGX6HjkaJgtndJ6ulg7r9celeeMVSM3+FA7H8=@vger.kernel.org X-Gm-Message-State: AOJu0YxN0IzwVRiQCcwdrjX0N9hxjoPxFYGpy+86X8vVn5ZupJQR6d75 tOxMFDWXtDDHHykLjoxwMv8O2bHWPgJxhmQKXGGQhc1oXp62Kx/DY9+L X-Gm-Gg: AR+sD13yzjdVA+GApC3uDFfLIf7gC+CgIwfA44MSxD6eEZuEYL1IqLDsN9ofVKPelmB AY4DweT8LDumMMhUzvixGOUdlZRIAAAHjtI1Ep1r6cOmV5ImBuhc6DwspQJjcg0ba0TUH85B1/6 u06c/SmPpYrIGTc86wXF38NJvcMkDQGq+qrtrPfhNRf4VhbqX9YlKmvTPjVR6epBN9ypnLA6i6Z pCyjxCnSzZjQAr+Q2mJdA9W+JNhTU4QJoycBYphP/OmN7PQ3LWVWSWGdnK5oBz5VzlbSdjI2ZrO d10ju3VK9qD/7WTimAIOZ+7G+v/1NN1TGohw6PwKuGHRg3lkApoY4Uzl2TIwGk/M0Nldow/Ll6S QRN/oQhn4lZa5I8258jvLoTTSNQVCw4D1sz9K7gswJNN3lrq1rzDDRwECv5pvFztwCph4YvAsLq JxKpCyhS4Oe5Y/R797qDGlxejhTIKiTD0/PayXkMlqGHQYugkZLH7eXNXMUfHRWx2NUQ25e2nX1 ZCeYA+rAJu6OBsoE+OSJk0343GTUQe1 X-Received: by 2002:a17:902:d485:b0:2c9:cf5d:d9bc with SMTP id d9443c01a7336-2cfde88614emr75673535ad.35.1785147096942; Mon, 27 Jul 2026 03:11:36 -0700 (PDT) Received: from phuc-desktop.. ([183.91.15.56]) by smtp.gmail.com with ESMTPSA id d9443c01a7336-2cfde59bb5asm32371125ad.8.2026.07.27.03.11.35 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 27 Jul 2026 03:11:36 -0700 (PDT) From: phucduc.bui@gmail.com To: Dmitry Torokhov Cc: linux-input@vger.kernel.org, linux-kernel@vger.kernel.org, bui duc phuc Subject: [PATCH v2 1/2] Input: snvs_pwrkey: Improve probe error handling Date: Mon, 27 Jul 2026 17:11:24 +0700 Message-ID: <20260727101125.28291-1-phucduc.bui@gmail.com> X-Mailer: git-send-email 2.43.0 Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: 8bit From: bui duc phuc Use dev_err_probe() for devm_clk_get() to prevent log spam when probe returns -EPROBE_DEFER. Return the original error from platform_get_irq() instead of replacing it with -EINVAL. Drop the redundant error message after devm_request_irq(), as the helper already reports request failures internally. Signed-off-by: bui duc phuc --- Changes in v2: - Clarify the commit message to better describe the purpose of using dev_err_probe() drivers/input/keyboard/snvs_pwrkey.c | 13 +++++-------- 1 file changed, 5 insertions(+), 8 deletions(-) diff --git a/drivers/input/keyboard/snvs_pwrkey.c b/drivers/input/keyboard/snvs_pwrkey.c index 954055aaf6e2..fa08ac561bf2 100644 --- a/drivers/input/keyboard/snvs_pwrkey.c +++ b/drivers/input/keyboard/snvs_pwrkey.c @@ -142,16 +142,15 @@ static int imx_snvs_pwrkey_probe(struct platform_device *pdev) } clk = devm_clk_get_optional_enabled(&pdev->dev, NULL); - if (IS_ERR(clk)) { - dev_err(&pdev->dev, "Failed to get snvs clock (%pe)\n", clk); - return PTR_ERR(clk); - } + if (IS_ERR(clk)) + return dev_err_probe(&pdev->dev, PTR_ERR(clk), + "Failed to get snvs clock\n"); pdata->wakeup = of_property_read_bool(np, "wakeup-source"); pdata->irq = platform_get_irq(pdev, 0); if (pdata->irq < 0) - return -EINVAL; + return pdata->irq; error = of_property_read_u32(np, "power-off-time-sec", &val); if (!error) { @@ -209,10 +208,8 @@ static int imx_snvs_pwrkey_probe(struct platform_device *pdev) error = devm_request_irq(&pdev->dev, pdata->irq, imx_snvs_pwrkey_interrupt, 0, pdev->name, pdev); - if (error) { - dev_err(&pdev->dev, "interrupt not available.\n"); + if (error) return error; - } error = input_register_device(input); if (error < 0) { -- 2.43.0