From: Jakub Kicinski <kuba@kernel.org>
To: luoqing <l1138897701@163.com>
Cc: marcelo.leitner@gmail.com, lucien.xin@gmail.com,
davem@davemloft.net, edumazet@google.com, pabeni@redhat.com,
horms@kernel.org, linux-sctp@vger.kernel.org,
netdev@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH net-next v4] sctp: socket: set *err = 0 on receive shutdown
Date: Mon, 27 Jul 2026 16:29:44 -0700 [thread overview]
Message-ID: <20260727162944.64697fba@kernel.org> (raw)
In-Reply-To: <20260721022522.178618-1-l1138897701@163.com>
On Tue, 21 Jul 2026 10:25:22 +0800 luoqing wrote:
> From: Qing Luo <luoqing@kylinos.cn>
>
> When sctp_skb_recv_datagram() detects RCV_SHUTDOWN, it breaks out
> of the loop and returns NULL without setting *err. While current
> callers happen to work correctly (sctp_recvmsg pre-initializes
> err to 0, sctp_ulpevent_read_nxtinfo doesn't use err), this is
> inconsistent with the generic __skb_wait_for_more_packets() in
> net/core/datagram.c which explicitly sets *err = 0 on shutdown.
>
> Set *err = 0 explicitly for correctness and robustness against
> future callers.
>
> Signed-off-by: Qing Luo <luoqing@kylinos.cn>
AFAICT Xin Long asked you to toss this patch:
https://lore.kernel.org/all/CADvbK_e4StN7-vSRjYC_FPMN-_3xjwhCxYUb+Jddz-akO-ryPw@mail.gmail.com/
so I'm dropping it from our queue.
prev parent reply other threads:[~2026-07-27 23:29 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-07-21 2:25 [PATCH net-next v4] sctp: socket: set *err = 0 on receive shutdown luoqing
2026-07-27 23:29 ` Jakub Kicinski [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20260727162944.64697fba@kernel.org \
--to=kuba@kernel.org \
--cc=davem@davemloft.net \
--cc=edumazet@google.com \
--cc=horms@kernel.org \
--cc=l1138897701@163.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-sctp@vger.kernel.org \
--cc=lucien.xin@gmail.com \
--cc=marcelo.leitner@gmail.com \
--cc=netdev@vger.kernel.org \
--cc=pabeni@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox