From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from out-173.mta0.migadu.com (out-173.mta0.migadu.com [91.218.175.173]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 9A02512D1F1 for ; Tue, 28 Jul 2026 03:21:47 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=91.218.175.173 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1785208910; cv=none; b=Z5VXB5pRqSnkpJDvI+lEp3PruS2OI7IWxF4S6/PqUlZHqRs6yIgYo1LMYzL2MO73SVNHfJmsZ+4hsFM2LRNVQvz/k4peFoSMZAD/qvCiSCGcZkt0Xb5pzR/IbWx5Ij1cxezvyXeU6NhDijhCo2RTIxnjoomwjbo/0AoJH8NtVfc= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1785208910; c=relaxed/simple; bh=VFQlGMA+SG3rxr5DeXQ1N3jze2JDCTNZtGAdV8EGzUg=; h=From:To:Cc:Subject:Date:Message-ID:In-Reply-To:References: MIME-Version; b=UrRorxRscD8N3ZPDiQOBdjfSsRVdRNUZvD5XL6TmX/tLY9laGHVExfjTYj3D2lMLvQvpgaykd/osD5C4jcSoldhXiMMgnMuVE49EYreObH9367AnEB3spe491aml6vFMIgGzT+7a8cDi+t66elBjzz9GfhbZhFN+PkwgyMVE3aw= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=linux.dev; spf=pass smtp.mailfrom=linux.dev; dkim=pass (1024-bit key) header.d=linux.dev header.i=@linux.dev header.b=DUH5VBJo; arc=none smtp.client-ip=91.218.175.173 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=linux.dev Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=linux.dev Authentication-Results: smtp.subspace.kernel.org; dkim=pass (1024-bit key) header.d=linux.dev header.i=@linux.dev header.b="DUH5VBJo" X-Report-Abuse: Please report any abuse attempt to abuse@migadu.com and include these headers. DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linux.dev; s=key1; t=1785208905; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=SOUrqvoxCz+7e5hlI2+qhp7FLHW1ZnUKoyhsbE1eVfE=; b=DUH5VBJoxuHFy3wowuNMvH59RblgGSz9zjcp1q1HcR38UXPqWoTH+iQvvXha50A66TTa2C YClNohua+edkbMJTlsqGVy9HSmJZDW5IK5zuAmkvjQ2PC1uIzrHnmsEmbJ2VllXksH7M4+ ms43c7r9t+CqbhVPdV2fQ49bG5oWR+M= From: Hongfu Li To: david@kernel.org Cc: akpm@linux-foundation.org, hongfu.li@linux.dev, liam@infradead.org, lihongfu@kylinos.cn, linux-kernel@vger.kernel.org, linux-mm@kvack.org, ljs@kernel.org, mhocko@suse.com, rppt@kernel.org, surenb@google.com, vbabka@kernel.org Subject: Re: [PATCH v2 2/2] mm: Extract non-swap page handling to do_non_swap_page() Date: Tue, 28 Jul 2026 11:21:19 +0800 Message-ID: <20260728032119.34053-1-hongfu.li@linux.dev> In-Reply-To: References: Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-Migadu-Flow: FLOW_OUT > >> Or sth like that. Then, maybe in the future, we can just move do_swap_entry() > >> out of memory.c > >> > >> So we're factoring the wrong thing out in this patch. > > > > Thank you very much for the detailed review, your analysis makes perfect sense to me. > > > > I'm glad to send out v3 shortly for your further review, with > > do_non_swap_page renamed to do_nonswap_softleaf. > > Read again, that's not what I meant. Sorry, I completely misunderstood your intention. I mistakenly sent v3 without checking your follow-up email, which was my oversight. I'll drop the second patch entirely in v4, and carefully go through all comments before resending next time. Thank you for your patience. Best regards, Hongfu