From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail-wm1-f51.google.com (mail-wm1-f51.google.com [209.85.128.51]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id F0D464279E9 for ; Tue, 28 Jul 2026 12:55:15 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.128.51 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1785243318; cv=none; b=EFdWeA+aF7VwK1uvYLSBJc1RvGBZBnSsWiDrWz2XG570/t7KTOcfxwaMi+u2o5einthVb0aTqxWLZvIjZ7+hpRjFvBEmFOQ6Gab/6F/Z6FNXsFuicHYdr9H754Nh2rv/OhfdeAzPSnvghunutJwKEovYxFxbdeizcOf1NaulJXo= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1785243318; c=relaxed/simple; bh=7igi6JgfyV7UtI5KhWMltwcUSiXutkp84qo2icc/bR0=; h=From:To:Cc:Subject:Date:Message-ID:In-Reply-To:References: MIME-Version; b=LXWmy34PZi+Kzpuax+iU7sVYRgcvYUZscBkJh9u6FzGeJRXetREug7J9kJBLEAlFaTTxh/DxuUI987Gj1/JL1aCQwss2Iu9m+KGPTr+tFn93UrTBAJbVSp66C6QbPykuN5e/1oMR9DVmVBeUXoxVkYGa4a6vf9uUqp2h3PLF9uc= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com; spf=pass smtp.mailfrom=gmail.com; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b=P6Z4NczK; arc=none smtp.client-ip=209.85.128.51 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=gmail.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="P6Z4NczK" Received: by mail-wm1-f51.google.com with SMTP id 5b1f17b1804b1-495757ccbc1so34945625e9.2 for ; Tue, 28 Jul 2026 05:55:15 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20251104; t=1785243314; x=1785848114; darn=vger.kernel.org; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to:content-type; bh=amhXqSP3saN85/NqS6GeuPvXXhbdKvSiHBtrXRJeyQM=; b=P6Z4NczKOKocYnQJZKNoOyiIgceHjCRZhPlKzdB3miy5MUfrfKNKgFOHayIY4YlHLR h3xlNHyvzBi61zNNTrGrjduqkqgYQUhI+TArYckqcUfLZIyhVAQun5NQIzcRz9Eo87FR fEdRaLQLQBorNykyYal/5bhMqAKCtat438pOyPJr6pMN9+qdc0PsQKDRBVHABS2Kp0Id /TM8A7ffBWvFmD5wDUyTDl7Qk91vONk9jXmC1vTt33XL2kSHxRO6TLEdJaDMIocHzFrZ 7LPU30ZFWwwfzkY2CuSMwSE7zzgQoaFjXzDgm1vpOZeOAv+4AzVB6YbVkrE5ExWdi3D4 uZmw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1785243314; x=1785848114; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-gg:x-gm-message-state:from :to:cc:subject:date:message-id:reply-to:content-type; bh=amhXqSP3saN85/NqS6GeuPvXXhbdKvSiHBtrXRJeyQM=; b=OQwPcuMWKyTdNNiHox4zRatpxajv34BaF7Q9969+ri+pVGUK7CQEsihuKD0g3PN+BB WqSHJe3Tef4kveaBdYO2CadTkDBuA/QgvH/J+7DVjHYahRnZZHTobKLWCjP2WI+TJfpv lFwQZEZmBmMjOCX8C0J1QVI6WvjiI/wvhTXjWHlAqk5YBRVBuvGTQio7gfnkc8OmoZGC nwGq1FppZNZ95rlr0PeeiilyD6CgGf09huI3xUHZnJsSPTnD4KUvYFTQWwFsfRrvZpc3 qmFs5gCF8yhdRL33nbF0OFTc8Me8eVJC23OFvlMomRLVzogBjTqZqAHGOLNWrPQo5ON6 uzmg== X-Forwarded-Encrypted: i=1; AHgh+RpN+35oQAA2Sj1xllPeWnQuBTneBKfBEKuwBsJJZ7/BXDy8dNd2Aj6szxJtFqS0dwkbLbEJwlE4XQs1QFk=@vger.kernel.org X-Gm-Message-State: AOJu0Yz+oL5Vt3hT1voN5b4gr0WpRD7MDah/bKIo+F4SvaH2taFv6oOG baBledUDbQPbb7Wmu9WoS0PwNlTJHcQCIifdjFAUJfDdI85/z8MtD4ek X-Gm-Gg: AR+sD10ar1XrGTIE6KLPWYDEvXeiUleGRoJfSt29fRsjVpW8XjMmNhIZ2GPI0gYkbOE ahDQE1qWAZQClhCYi2JW5hwznQYgx2SfSK2hdufrJvVSt3BPjrPUIZZLwo8Tsk/D+kBJKRcpV6Z 6sJwdMfoxpozSuyC6ZI08KKu5HLwERKH56mSCRAShM33E1j781F/ZfqDa0dElkRWEYw7lrUfNvP 5+Wu7P8lO6NXESDDODAYqaTnw++nJThQIFNV16EtmbOG9CqLAec0cWdZ6HXWtQAWahJ1j95+GoF PS6R4mVrZNlAygR/iErZ/gb6zJfVmi2XF682MS88WdIFd+/c7436OltTdAiDyb6IJIhEAUaogZp Vy/ytz/0NPdD833W9RuTHYkZRBnJ4GJPNutPp/M8IANDD9KFrCEn5LTPvsBbfbXW4UyFKmaSxo+ gw4QgYJ1jMmCy0PjasZ7wnUgypVd44JMKwKY+jmGExfkDhUZdBidg2nKsG30V0T1UGIA== X-Received: by 2002:a05:600c:6986:b0:495:3aac:1098 with SMTP id 5b1f17b1804b1-496c6591311mr27027405e9.32.1785243314092; Tue, 28 Jul 2026 05:55:14 -0700 (PDT) Received: from fedora ([202.47.63.86]) by smtp.gmail.com with ESMTPSA id 5b1f17b1804b1-496c444304esm74096505e9.0.2026.07.28.05.55.12 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 28 Jul 2026 05:55:13 -0700 (PDT) From: Muhammad Bilal To: linux-staging@lists.linux.dev, linux-kernel@vger.kernel.org Cc: gregkh@linuxfoundation.org, stable@vger.kernel.org, Muhammad Bilal Subject: [PATCH v2 2/3] staging: rtl8723bs: fix OOB read in rtw_action_frame_parse() Date: Tue, 28 Jul 2026 17:54:55 +0500 Message-ID: <20260728125456.32359-3-meatuni001@gmail.com> X-Mailer: git-send-email 2.55.0 In-Reply-To: <20260728125456.32359-1-meatuni001@gmail.com> References: <20260728125456.32359-1-meatuni001@gmail.com> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: 8bit rtw_action_frame_parse() takes a frame_len parameter but never actually checks it before indexing into the frame body: const u8 *frame_body = frame + sizeof(struct ieee80211_hdr_3addr); ... c = frame_body[0]; ... a = frame_body[1]; frame_body already points 24 bytes (sizeof(struct ieee80211_hdr_3addr)) into frame, so reading frame_body[0] and frame_body[1] requires frame_len >= 26. A management action frame shorter than that (e.g. exactly 24 bytes, the minimum a malicious peer can send) causes a 1-2 byte out-of-bounds read. This is reachable from rtw_cfg80211_monitor_if_xmit_entry() and cfg80211_rtw_mgmt_tx() in ioctl_cfg80211.c, both of which pass attacker/user-influenced frame buffers and lengths straight through. Add the missing length check before frame_body is dereferenced. Fixes: 554c0a3abf216 ("staging: Add rtl8723bs sdio wifi driver") Cc: stable@vger.kernel.org Signed-off-by: Muhammad Bilal --- drivers/staging/rtl8723bs/core/rtw_ieee80211.c | 3 +++ 1 file changed, 3 insertions(+) diff --git a/drivers/staging/rtl8723bs/core/rtw_ieee80211.c b/drivers/staging/rtl8723bs/core/rtw_ieee80211.c index be374d222c55..e02b54131633 100644 --- a/drivers/staging/rtl8723bs/core/rtw_ieee80211.c +++ b/drivers/staging/rtl8723bs/core/rtw_ieee80211.c @@ -1145,6 +1145,9 @@ int rtw_action_frame_parse(const u8 *frame, u32 frame_len, u8 *category, u8 *act u8 c; u8 a = ACT_PUBLIC_MAX; + if (frame_len < sizeof(struct ieee80211_hdr_3addr) + 2) + return false; + fc = le16_to_cpu(((struct ieee80211_hdr_3addr *)frame)->frame_control); if ((fc & (IEEE80211_FCTL_FTYPE | IEEE80211_FCTL_STYPE)) != -- 2.55.0