From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from casper.infradead.org (casper.infradead.org [90.155.50.34]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 069D9378D64 for ; Tue, 28 Jul 2026 16:49:17 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=90.155.50.34 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1785257360; cv=none; b=a2LhbsmpLpcNrfrTVRUYyjDumZ+cC1fFqFKbADCiiN/MQ9Vh/9U/6DPvNz/x9bzCrPPW9FURQB6Mq918x3mGBfuD4oghVlLYO4a8ueEOEYLKu3SDRrcA2B7qWPu8bo/k5GUr3Oa7Hb1ZPEXrnbVdbKcq3qogyZXRU6rBjIVdT6E= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1785257360; c=relaxed/simple; bh=dvMURGaMSTeIRfweGYRrsDfoAXsn9nh8eefSMXAWskY=; h=Date:From:To:Cc:Subject:Message-ID:References:MIME-Version: Content-Type:Content-Disposition:In-Reply-To; b=hv8yBO+WWxsqt2qaftQ6ZftTMstvQaIT30vz9GfLf9uWGksTvfhpfUaE9wwToGSuuVx1+G7O8qcxDtZcHDlK9/zcaq0KmtHDfF8L966qQlPwYyRaqwzTac4IXWe9CBvQCEwSplZL1U9YuuyF4vJAbdQEwQ4wVB4kJ+Jp9hW/8EE= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=infradead.org; spf=pass smtp.mailfrom=infradead.org; dkim=pass (2048-bit key) header.d=infradead.org header.i=@infradead.org header.b=PL7Ktb8G; arc=none smtp.client-ip=90.155.50.34 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=infradead.org Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=infradead.org Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=infradead.org header.i=@infradead.org header.b="PL7Ktb8G" DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=infradead.org; s=casper.20170209; h=In-Reply-To:Content-Type:MIME-Version: References:Message-ID:Subject:Cc:To:From:Date:Sender:Reply-To: Content-Transfer-Encoding:Content-ID:Content-Description; bh=W3F1LuqqqT/GImPaHY8Z5JFr1IouKO1/vrQjKx3HEb4=; b=PL7Ktb8GV+fW9Tly1R/1yIi2n/ R0N7/Pf0UkJCkqEXpoXOMWGEQKzaqp/Nq6hB9aOgkCYTqsg/ukqDXnWW8IiZQEyJhyV/hyhGm9soE YwiPMzvOBctBqB9bSQ8U5lInC7UixqdYqyU0blgnuuEBjdEX/yxKKT8GYnZ4dkvo0k6rIyi0n+eek G9ic8s5jFP7/r9DUSaca4u/VbAKzFFN28NLIOhEVUZZ+Oz3cFjGMrrT/EkRo0yerqrCSeMA4LsiTe nsesOq8nfyJn22tvGyWUkuKHjZMqQ/jJaOW3kcldKUWTessbFmi2kOVSJz/9ElLGahbOeomiJWI52 iobwGc5A==; Received: from 77-249-17-252.cable.dynamic.v4.ziggo.nl ([77.249.17.252] helo=noisy.programming.kicks-ass.net) by casper.infradead.org with esmtpsa (Exim 4.99.1 #2 (Red Hat Linux)) id 1wokzR-0000000DkKs-1Sow; Tue, 28 Jul 2026 16:49:13 +0000 Received: by noisy.programming.kicks-ass.net (Postfix, from userid 1000) id E129C300F47; Tue, 28 Jul 2026 18:49:12 +0200 (CEST) Date: Tue, 28 Jul 2026 18:49:12 +0200 From: Peter Zijlstra To: Mark Rutland Cc: linux-arm-kernel@lists.infradead.org, ada.coupriediaz@arm.com, ardb@kernel.org, catalin.marinas@arm.com, hca@linux.ibm.com, linux-kernel@vger.kernel.org, maz@kernel.org, ruanjinjie@huawei.com, vladimir.murzin@arm.com, will@kernel.org, yang@os.amperecomputing.com Subject: Re: [RFC PATCH 06/13] arm64: percpu: Add infrastructure for preemptible this_cpu_*() ops Message-ID: <20260728164912.GK651302@noisy.programming.kicks-ass.net> References: <20260728123859.2911495-1-mark.rutland@arm.com> <20260728123859.2911495-7-mark.rutland@arm.com> <20260728141958.GV751831@noisy.programming.kicks-ass.net> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: On Tue, Jul 28, 2026 at 04:53:52PM +0100, Mark Rutland wrote: > > > +#define ____PCPU_GPRS_BEGIN(gprs, pcp, off, addr) \ > > > + __DEFINE_ASM_GPR_NUMS \ > > > + __DEFINE_ASM_GPR_ALIASES \ > > > + " mov w" off ", #" __VAL_PCPU_GPRS(pcp, off, addr) "\n" \ > > > + " strh w" off ", " gprs "\n" \ > > > + __KERN_ASM_CPU_OFFSET(off) "\n" > > > > Can this macro also generate a readable comment for those few of us > > building the .i file ? > > Do you mean for __VAL_PCPU_GPRS, or ____PCPU_GPRS_BEGIN() ? I was thinking BEGIN, but whatever is easiest, the __VAL thing is only ever used in BEGIN anyway. > I can happily add comments for either (and the corresponding ENDs). Not sure the comment makes sense for end, that's simply storing 0 and seems clear enough.