From: Jakub Kicinski <kuba@kernel.org>
To: Maxime Chevallier <maxime.chevallier@bootlin.com>
Cc: Zxyan Zhu <zxyan0222@gmail.com>,
netdev@vger.kernel.org, Andrew Lunn <andrew+netdev@lunn.ch>,
"David S . Miller" <davem@davemloft.net>,
Eric Dumazet <edumazet@google.com>,
Paolo Abeni <pabeni@redhat.com>,
Maxime Coquelin <mcoquelin.stm32@gmail.com>,
Alexandre Torgue <alexandre.torgue@foss.st.com>,
Russell King <linux@armlinux.org.uk>,
Russell King <rmk+kernel@armlinux.org.uk>,
Serge Semin <fancer.lancer@gmail.com>,
Romain Gantois <romain.gantois@bootlin.com>,
Hariprasad Kelam <hkelam@marvell.com>,
linux-stm32@st-md-mailman.stormreply.com,
linux-arm-kernel@lists.infradead.org,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH net-next v2 0/2] net: stmmac: Fix PHY attach when custom PCS is in use
Date: Tue, 28 Jul 2026 19:12:05 -0700 [thread overview]
Message-ID: <20260728191205.53e347c0@kernel.org> (raw)
In-Reply-To: <f14a1712-8315-4e64-b23b-ac00d7f82c3a@bootlin.com>
On Mon, 27 Jul 2026 08:49:11 +0200 Maxime Chevallier wrote:
> On 7/26/26 15:26, Zxyan Zhu wrote:
> > This series fixes the issue where stmmac platforms using a custom PCS
> > via the pcs_init callback fail to probe when no phy-handle is specified
> > in the device tree.
> >
> > Patch 1 is Russell King's phylink patch that relaxes phylink_expects_phy()
> > to allow PHYs to be attached in 802.3z inband mode.
> >
> > Patch 2 skips the PHY attach in stmmac when a custom PCS is already
> > configured via priv->hw->phylink_pcs, avoiding the "no phy found" error
> > for platforms that manage link state entirely through the PCS.
>
> I've tested this series on the board that saw the regression from Russell's
> first attempt, and now with the associated stmmac patch, it works :)
Both Sashikos see a risk of regression here, could you TAL and confirm
it's not real / unlikely?
prev parent reply other threads:[~2026-07-29 2:12 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-07-26 13:26 [PATCH net-next v2 0/2] net: stmmac: Fix PHY attach when custom PCS is in use Zxyan Zhu
2026-07-26 13:26 ` [PATCH net-next v2 1/2] net: phylink: allow PHYs to be attached in 802.3z inband mode Zxyan Zhu
2026-07-26 13:26 ` [PATCH net-next v2 2/2] net: stmmac: Skip PHY attach if custom PCS is in use Zxyan Zhu
2026-07-27 6:49 ` [PATCH net-next v2 0/2] net: stmmac: Fix PHY attach when " Maxime Chevallier
2026-07-29 2:12 ` Jakub Kicinski [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20260728191205.53e347c0@kernel.org \
--to=kuba@kernel.org \
--cc=alexandre.torgue@foss.st.com \
--cc=andrew+netdev@lunn.ch \
--cc=davem@davemloft.net \
--cc=edumazet@google.com \
--cc=fancer.lancer@gmail.com \
--cc=hkelam@marvell.com \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-stm32@st-md-mailman.stormreply.com \
--cc=linux@armlinux.org.uk \
--cc=maxime.chevallier@bootlin.com \
--cc=mcoquelin.stm32@gmail.com \
--cc=netdev@vger.kernel.org \
--cc=pabeni@redhat.com \
--cc=rmk+kernel@armlinux.org.uk \
--cc=romain.gantois@bootlin.com \
--cc=zxyan0222@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox