From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail-wm1-f43.google.com (mail-wm1-f43.google.com [209.85.128.43]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 981333AF66D for ; Tue, 28 Jul 2026 22:09:27 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.128.43 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1785276570; cv=none; b=oQAIf+jKCiJHZzOLjeDUyOe5c2ozoMO72P7S63xnXyxoQHrI22VFidzD+YehrmgGF3lUr6gFWhA44ciAUaKvwa6NrtW/+gT5zZb3XyUmCxsDK0x6AKfPTC7evZoEQL61TTQHym7xXYk+cUmCZmS6PKPZCIE5e+nu9abM4rkX37M= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1785276570; c=relaxed/simple; bh=j80OaiyabeTrH77BUKHDAdD7kmA0i/geLRAKjvivSLg=; h=Date:From:To:Cc:Subject:Message-ID:In-Reply-To:References: MIME-Version:Content-Type; b=uH/n7BMXSdLV3GxVbS/we1UAhWZlTMDFCUriiyT8hln352Sm33dM0gFE8JN4MP0QoVSvZZPBah8y6AnmZ5AK3VY4QNYqRSyOexeVCMfAKEANr2jbffOHI9rnYzkw1HA+1fwojS1iFWeipZGW/mToECeYj+OcT8Pd2ijHXGCVUBE= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com; spf=pass smtp.mailfrom=gmail.com; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b=B+57ZYdY; arc=none smtp.client-ip=209.85.128.43 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=gmail.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="B+57ZYdY" Received: by mail-wm1-f43.google.com with SMTP id 5b1f17b1804b1-4954aff6088so2802585e9.3 for ; Tue, 28 Jul 2026 15:09:26 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20251104; t=1785276565; x=1785881365; darn=vger.kernel.org; h=content-transfer-encoding:content-type:mime-version:references :in-reply-to:message-id:subject:cc:to:from:date:from:to:cc:subject :date:message-id:reply-to:content-type; bh=Kfs5/DS4wlz7dZpaWR13thX2/68+v1Oc39FEjVcr9hM=; b=B+57ZYdYgr2A51htOkWG46FdMggmg6gWwAu6jGRFefJZYW9ObkfE7Fwsg7g0JMjYOV uVDTaw4zG14amUdLGnFgO8TYDH7CmmJbgoIT3ljDxMxhuoBAWd/In5vsYgvz9rC4gNc6 bv5wVelxrxpMn20nv/qvaD1Pt508UtNc88bgANYtK7jIE0Cmmr+1lSnlLCRmt4gpRN33 AOoqBuvsQj7MiuWaJ6FqXTcZzZKLl+FAVqsQn9RbkB5BQ6Lv+ZaQpARyKfvxxFlOqwVP C43NVLQzvvIcyPWBZZBZyjZNGrv44OJpJN5wHaN6idrqRgOT3GWqjYK9INPIN571IExR u4jw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1785276565; x=1785881365; h=content-transfer-encoding:content-type:mime-version:references :in-reply-to:message-id:subject:cc:to:from:date:x-gm-gg :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to :content-type; bh=Kfs5/DS4wlz7dZpaWR13thX2/68+v1Oc39FEjVcr9hM=; b=WJSoFE1PeN9H1Zyz+0BT2SXfR2ipywhRHbVA/54k//A8rhVmQJm4SE0QUqhtkmHD2B OIlaM1WFebJDmB6cCMiAS+lySIGm0Iv+7FoS/towf1XpB4NPXtmjfMgpKMt/gWZHEdY/ NEICmkpGZ3YtsDGbpuTdt7FTv6lS2zqk7vVZS90dvfmTl0k4eW+eFhhCtV3J4GFY6xwN b39qW3EKAY2bUOvbClBKa5msCtTbsB+4XmyZ52fPPXwDJsE5DiSG1NMhaYOxO21rSeyU nmEkleDdONeAj5WC6ln3Be1Ue9C1UwgHP72TQ2PwS6M8wu2a/vYE8XTzniTUrYTNwU47 1Blg== X-Forwarded-Encrypted: i=1; AHgh+RqcJ4kOI5FYulcdiC0NwYTq1gh0R5jkmm8oKIi3GwjOuZ/k1QUUeIRCtf5mZR0tZmbju02uFSUBKgV8f3A=@vger.kernel.org X-Gm-Message-State: AOJu0YxoL+nLER8nkjJ1T4zj8dZa7t7gNf1q1vz6d+L24MqKFxcOEf0M VPDJupElS0rpBjKPbEADttkG2q7WVWZvNb4dsr9B2XBUdeTie+VadexD X-Gm-Gg: AR+sD11YGO33Cb9jgu7PbfzpFt6bhUGvm11WYrd6kG1INEZEwHZbpv/IRppFXMvkZx8 oyaDbSw9bT9Atb3feBzTdMMCqjy+y2s1pB3mZq1raTLYPBOS4k8nYG2T3ZQhZsUdNoI/zQgHmY9 rvJHv0zsYYnZdc/BdlIQXS+HeqcxUH+kWYm7AoV5OCIeFh4IdT8qG5A02wK/yccq+bH4qWwHAuP KNoQcyvWsFovFE3RuEA74amZqQ4/nu9aTN21WhJtsGIgDdT457unZNSPsEEIYulAjUAv/+cXtFr 4gGhBV84NWz9yMHQJjQodiNlH3t63GSedlg84MyVuS9MVhqr9/q2f2pDO5+uOqRJ6OSi7P1o/0g 9l+B1kaTLf+GNTJqEZed759Ia0G4xD3Eobnpen8EbBvyvV+pYbw+bNyphTa0mtS0UZAx/UOmOUI cP5XUYWcOzcIPrzgZIcikwP0bjrktuyXPFp0kl9ggL3yU2TBAG6H+wltEM3fdtlqDvda5Og4luc Eter0QOp8Ld2sILhUjeDqzVWg== X-Received: by 2002:a05:600c:3b27:b0:496:c18c:f9a3 with SMTP id 5b1f17b1804b1-496c642d625mr45250245e9.5.1785276565390; Tue, 28 Jul 2026 15:09:25 -0700 (PDT) Received: from pumpkin (82-69-66-36.dsl.in-addr.zen.co.uk. [82.69.66.36]) by smtp.gmail.com with ESMTPSA id 5b1f17b1804b1-496fa42effasm12588615e9.2.2026.07.28.15.09.24 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 28 Jul 2026 15:09:25 -0700 (PDT) Date: Tue, 28 Jul 2026 23:09:23 +0100 From: David Laight To: Dave Hansen Cc: "Chang S. Bae" , Sohil Mehta , "Maciej W. Rozycki" , linux-kernel@vger.kernel.org, x86@kernel.org, tglx@kernel.org, Ingo Molnar , bp@alien8.de, dave.hansen@linux.intel.com, hpa@zytor.com Subject: Re: [PATCH] x86/microcode/intel: Panic on partial microcode update Message-ID: <20260728230923.2df52561@pumpkin> In-Reply-To: <5eb49b65-7f33-4e5d-b800-b30a90b0516e@intel.com> References: <20260630191350.3837-1-chang.seok.bae@intel.com> <4f2a4841-0a73-4f44-aec8-890734660a9c@intel.com> <12374cc0-aa93-409f-8108-7e9f5d7160e1@intel.com> <9762ae8a-70e9-4376-a6fe-a05d05721a23@intel.com> <20260728195611.5d41ee5a@pumpkin> <5eb49b65-7f33-4e5d-b800-b30a90b0516e@intel.com> X-Mailer: Claws Mail 4.1.1 (GTK 3.24.38; arm-unknown-linux-gnueabihf) Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit On Tue, 28 Jul 2026 13:48:20 -0700 Dave Hansen wrote: > On 7/28/26 11:56, David Laight wrote: > >> WARN(), please. Not panic(). > >> > > PANIC_ON_WARN .... > > Right. That's kinda my point. > > If you are of the tin-foil-hat-wearing persuasion, you are paranoid and > can't get enough panic()s in your life. You have panic_on_warn=1 to > magically transform all warnings into panic()s and warm your heart. > > There's no warn_on_panic=1. The trusting don't have an analog. And the panics are much harder to debug. It isn't as though the code waits long enough after generating all the 'console' output to let syslogd get it to filestore. We we trying to find why a customer system kept rebooting. Eventually realised PANIC_ON_OOPS was set, turned it off and the silly bug was obvious. David