From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from smtp.kernel.org (aws-us-west-2-korg-mail-alma10-1.taild15c8.ts.net [100.103.45.18]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 3C9B644213E for ; Wed, 29 Jul 2026 09:44:01 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=100.103.45.18 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1785318243; cv=none; b=YLuQZ28QlHcHCz3gQnVpI7sP8fR3hBrqbCbFM+REwveEkkXTIFRE8pbxsFHxJJ7X3Z9oqs2+asAZ9n/C+OpfvNVtQqkYRFjIG4inWOI3XQNCd3waSdmdzWygYncwg7nv9lfvvsustv95sZFf46vjCV8dqVHESMieRwKTRTQYpdI= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1785318243; c=relaxed/simple; bh=j3/HMIeNJ//4Ns34RIo+Sryt9nUnEgApFwK5f8HHRnM=; h=From:To:Cc:Subject:Date:Message-ID:In-Reply-To:References: MIME-Version; b=fEiHlfAeFzQxJCxyetZq3PByptPtQ6gMq+CmEcC/IBLzgzRCEMSzOEIrPG/U5myUwvroYTJntyhVNYnpiMz/Ld4i/DAEB4ncmlCQD/n4yXnKEaNS2vP3aLhzovO+fcOJOpj7GuxGFLkiaosCTZJGAqIPHOjjfCQKZhTR2fxue9c= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org header.b=LJGyGBH3; arc=none smtp.client-ip=100.103.45.18 Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org header.b="LJGyGBH3" Received: by smtp.kernel.org (Postfix) with ESMTPSA id 98C401F00A3D; Wed, 29 Jul 2026 09:44:00 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=kernel.org; s=k20260515; t=1785318241; bh=X1+h4JYKjBK4Pnga6r0mBPhUEb/3VamPvtV6qAK9BpA=; h=From:To:Cc:Subject:Date:In-Reply-To:References; b=LJGyGBH3LU2ShiPfpewHslFQjC+gXMDraeZpAWwJjzTm70/U4/ZGdfr4TMG1fFdGh 61sW2Yvw1LmKr8mltTdBXlf7cYgJws2HOBedEZQBFhce2+kXNeXIFaoovWKwWFsTGJ FHsDfhuyDWVveI0RLA9Q1csH5q1HHRUHaVkZ8BaMjscWKbNUU8mB8UcP5ZzlNaySAH qcniiXghjkLmkzPKvTl2eXj0tjSmVCIPPj3e0TAUNHWYymzf+DKusAS6+8TMx74jst CdRUO9IiTWrXPbkS2N2yINPDkpCLqx6/TdBVHBinOvgJ62ihdC0wXNB1rrP6+XYyFb r9mxaD90yMpAA== From: srini@kernel.org To: gregkh@linuxfoundation.org Cc: linux-kernel@vger.kernel.org, Ekansh Gupta , Dmitry Baryshkov , Jianping Li , Srinivas Kandagatla Subject: [PATCH 02/10] misc: fastrpc: Allow fastrpc_buf_free() to accept NULL Date: Wed, 29 Jul 2026 10:43:44 +0100 Message-ID: <20260729094352.111065-3-srini@kernel.org> X-Mailer: git-send-email 2.53.0 In-Reply-To: <20260729094352.111065-1-srini@kernel.org> References: <20260729094352.111065-1-srini@kernel.org> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: 8bit From: Ekansh Gupta Make fastrpc_buf_free() a no-op when passed a NULL pointer, allowing callers to avoid open-coded NULL checks. Reviewed-by: Dmitry Baryshkov Signed-off-by: Ekansh Gupta Signed-off-by: Jianping Li Signed-off-by: Srinivas Kandagatla --- drivers/misc/fastrpc.c | 9 +++++---- 1 file changed, 5 insertions(+), 4 deletions(-) diff --git a/drivers/misc/fastrpc.c b/drivers/misc/fastrpc.c index a9b2ae44c06f..32da4664de58 100644 --- a/drivers/misc/fastrpc.c +++ b/drivers/misc/fastrpc.c @@ -422,6 +422,9 @@ static int fastrpc_map_lookup(struct fastrpc_user *fl, int fd, static void fastrpc_buf_free(struct fastrpc_buf *buf) { + if (!buf) + return; + dma_free_coherent(buf->dev, buf->size, buf->virt, fastrpc_ipa_to_dma_addr(buf->fl->cctx, buf->dma_addr)); kfree(buf); @@ -514,8 +517,7 @@ static void fastrpc_user_free(struct kref *ref) struct fastrpc_map *map, *m; struct fastrpc_buf *buf, *b; - if (fl->init_mem) - fastrpc_buf_free(fl->init_mem); + fastrpc_buf_free(fl->init_mem); list_for_each_entry_safe(ctx, n, &fl->pending, node) { list_del(&ctx->node); @@ -560,8 +562,7 @@ static void fastrpc_context_free(struct kref *ref) for (i = 0; i < ctx->nbufs; i++) fastrpc_map_put(ctx->maps[i]); - if (ctx->buf) - fastrpc_buf_free(ctx->buf); + fastrpc_buf_free(ctx->buf); spin_lock_irqsave(&cctx->lock, flags); idr_remove(&cctx->ctx_idr, ctx->ctxid >> 4); -- 2.53.0