From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from smtp.kernel.org (aws-us-west-2-korg-mail-alma10-1.taild15c8.ts.net [100.103.45.18]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 0CC2B449985 for ; Wed, 29 Jul 2026 09:46:57 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=100.103.45.18 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1785318418; cv=none; b=ts98qw88T11K9+fHF6aEdilzGhgiM2Oh1m89IkxqEvFjjRqbA5n+mMm5j98GncGJvYoeTfJbIOTUP+iel7/9vq1M191bIzJ1/8qbDh0LmqGW8S6dCeYf3dYKTsRxv9EPCagljbHNnXKMvmz43PtEKiGX6or6pIZTyfI8xJbzAvA= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1785318418; c=relaxed/simple; bh=1VtBxDEdByaQfa1xV6iHX5zCqPAi3NVQTkJ8Ej8K7XI=; h=From:To:Cc:Subject:Date:Message-ID:In-Reply-To:References: MIME-Version; b=L3CnjBeowGCscQMpW/vN66ReMaf3VwCuNRdkmq5i4WroFhlgJQQye+Re+ijCUrNGqjXolYGQZetZ5uliKXSoyTMsw20vbgU389EgQv9r50xEchO27P82Mzr+Xw9iWKAjcyTfkMmI1HVDKs6O/mWuUQm02LYQbsMOb5c0a5g7vxo= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org header.b=d7PvWB0g; arc=none smtp.client-ip=100.103.45.18 Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org header.b="d7PvWB0g" Received: by smtp.kernel.org (Postfix) with ESMTPSA id 9D2301F00A3D; Wed, 29 Jul 2026 09:46:55 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=kernel.org; s=k20260515; t=1785318416; bh=ZFBjxVG2JdfQUCl/5uFOj4AAkSEFfd7eUQUp/FXtliQ=; h=From:To:Cc:Subject:Date:In-Reply-To:References; b=d7PvWB0gqSnynhO8jcOI0B8s011WQNXjjZLGe/WKBGt/TC4SEjmTgUgrttj5Bg+K3 Yh7T4iEZcITKCbHqXU2UZ5dj2OknRwBeGI935c6x4ykwcYXGmBCe4oVHnX1pdN+22h Pttx6SFSzrUvaFIkiXcuhJ+sH3X864m/dkXS7oTrybT0D9BdK9KnHWp/VDOopeyGbH 1NlDY4LyAFn27GWlclwPBT2euqobGCfcPPxDkWYO+ke+2LmRyd+8cAOmsE47Zo1A/i 1HQzwj9SKu8pGCpsiBlqgireHRhLO3+nkX502kFZOmdR3/dlDSQULc2c2U+O+Thwev 2OCixUd+N+Cbg== From: srini@kernel.org To: gregkh@linuxfoundation.org Cc: linux-kernel@vger.kernel.org, Bartosz Golaszewski , Johan Hovold , Loic Poulain , Srinivas Kandagatla Subject: [PATCH 03/14] nvmem: check the return value of gpiod_set_value_cansleep() Date: Wed, 29 Jul 2026 10:46:36 +0100 Message-ID: <20260729094647.111468-4-srini@kernel.org> X-Mailer: git-send-email 2.53.0 In-Reply-To: <20260729094647.111468-1-srini@kernel.org> References: <20260729094647.111468-1-srini@kernel.org> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: 8bit From: Bartosz Golaszewski GPIO setters now return integer values and can indicate failures in lower abstraction layers. Check the return values of gpiod_set_value_cansleep() calls in nvmem core. Reviewed-by: Johan Hovold Signed-off-by: Bartosz Golaszewski Tested-by: Loic Poulain Signed-off-by: Srinivas Kandagatla --- drivers/nvmem/core.c | 16 +++++++++++----- 1 file changed, 11 insertions(+), 5 deletions(-) diff --git a/drivers/nvmem/core.c b/drivers/nvmem/core.c index ea17374209ba..a7e58bceb7ab 100644 --- a/drivers/nvmem/core.c +++ b/drivers/nvmem/core.c @@ -64,16 +64,22 @@ static int __nvmem_reg_read(struct nvmem_device *nvmem, unsigned int offset, static int __nvmem_reg_write(struct nvmem_device *nvmem, unsigned int offset, void *val, size_t bytes) { - int ret; + int ret, wr_ok; if (!nvmem->reg_write) return -EOPNOTSUPP; - gpiod_set_value_cansleep(nvmem->wp_gpio, 0); - ret = nvmem->reg_write(nvmem->priv, offset, val, bytes); - gpiod_set_value_cansleep(nvmem->wp_gpio, 1); + ret = gpiod_set_value_cansleep(nvmem->wp_gpio, 0); + if (ret) + return ret; - return ret; + wr_ok = nvmem->reg_write(nvmem->priv, offset, val, bytes); + + ret = gpiod_set_value_cansleep(nvmem->wp_gpio, 1); + if (ret) + return ret; + + return wr_ok; } static int nvmem_access_with_keepouts(struct nvmem_device *nvmem, -- 2.53.0