From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail-wm1-f49.google.com (mail-wm1-f49.google.com [209.85.128.49]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 2CE53361DA7 for ; Wed, 29 Jul 2026 05:46:03 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.128.49 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1785303965; cv=none; b=CT4m5pE21sjRLzrVb/lgrskk4ZSBjjQvsEO7IcWVbuulFVIHrrqSdzzzHlXTgP56QQCv+OJeK0/RXueEfIR/OiAwyidTHB8NJFVaYuUgkRTNUWTIOwpq/A/EUZMokf7xTQDVaYeW/lGw2QeR1SScByiCx6YMXPSb7X6+C+2RhOU= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1785303965; c=relaxed/simple; bh=NNRhx5kCrh7KxH5C17Ma8caUSEtsaxgQsdVLvCvhiCw=; h=Date:From:To:Cc:Subject:Message-ID:MIME-Version:Content-Type: Content-Disposition; b=Msp2SCTqdeCHX769JeDUhIMErLfMzDQaGhDfiSiLhsCPFwQ5an41kz3iJ53zogUfzMfHZBOOyzhPwjQWrXphHmJruRbD45apG3A6DQDDqc45642CgVh+eizeIWYgfkSjosZlz+mA9m0JEAmeyKW7C4+264eXheMm/fZGmFDZ9Sk= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com; spf=pass smtp.mailfrom=gmail.com; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b=BqUDcMUY; arc=none smtp.client-ip=209.85.128.49 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=gmail.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="BqUDcMUY" Received: by mail-wm1-f49.google.com with SMTP id 5b1f17b1804b1-4953de5be0aso3459885e9.0 for ; Tue, 28 Jul 2026 22:46:03 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20251104; t=1785303962; x=1785908762; darn=vger.kernel.org; h=content-disposition:content-type:mime-version:message-id:subject:cc :to:from:date:from:to:cc:subject:date:message-id:reply-to :content-type; bh=hVwpUPi151eolMFYb/dgE7OHy6q7d6NUaiE4xjATEk0=; b=BqUDcMUYVuT89R/nL6tsOzZ//wPVGARWo9glUz1QLyzMQ8NsVjFvp2pJAx3cWGpbhs 2Qx6V5IW2dU3w5+pxixPYD7hKL3Z9QWOBWCuVdvDnC+LFtvEVJbKj4mWjrLspi1taiI1 wROpfSRuRks2jszdSxMDhphNl8RnWjRB1VB7Yeckcy4lpfUOssmthAK9jR2jk42n1FPV W988nm1iPCO9u01SGX5BzqiNHAducRipaf/MXdDCJu8dX6rfeBf1cB8MT1Ippw1uY/SO gIZ679cpmHZn+NQ0I85WBCCROmFIuZ8VvX0PCXO4LPu4oJxvSBD3ci5388NxhkfdYQ3z mLAw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1785303962; x=1785908762; h=content-disposition:content-type:mime-version:message-id:subject:cc :to:from:date:x-gm-gg:x-gm-message-state:from:to:cc:subject:date :message-id:reply-to:content-type; bh=hVwpUPi151eolMFYb/dgE7OHy6q7d6NUaiE4xjATEk0=; b=bnIF3bYfyuTAuBlkR7E8IEd+WERVRwIH5kU+sxgWGu7Ug8XcUOihjLayn0Ona9CiTx l8cBm0tcUQxyjZ8t2nTx9BsFfGNTvtHNc6CnsDk+tyTCJCWMd2t4EhW0/gMCvnYuu+jT 5qesQKOgRF/GB4fSwd6ya3BCWqSUoBliu2tbN4fqd8BSU2fLOYoCsS11Ribxdbb1SbCy f6+D0Qsg56SHkyEnwkF+NhfOIkjE0LvFW+iiAlvUmLsBs3IRL4d6H4zgNhukjChn1sFb uVM/NoTOYrMvPFTHX9OnQcb2HBnkHdljKqpX7DRFE2EqSAhW24gWG+2r9froa5SSJ2MX E0mg== X-Forwarded-Encrypted: i=1; AHgh+RqKiPw5OWtG0Oqbp1NcVh5rwVpoNS52IKiON5tidJXNGGhxVJNpFpf4nGZoqQho/nkWC987jM9B5ugaEzA=@vger.kernel.org X-Gm-Message-State: AOJu0YwjO8EODjLmt54ap+DN6qaLWGLtrgg2oOTl/91MgOBMFJWxpK3Q JQdvP0pzFyDi8bhnMr1Nlkk4898ZMyD7Aln9NnswfuMVlkir87cqFmQn X-Gm-Gg: AR+sD13jkex18F18w54eBGwPSjbP53HPHw7pON4t3LJCtHnoD3GXU8wkLYytYZAv/EV Zk2AwKASKzkWE6HdAemqYyr7Dda7hITzj2SJsHxlgKdU1pEjhLjL5yS4v8/wfI3yNzI7P3qj0gi CFh2ec9H7ppJCPesEJGB9MZDKYgOzrmgnbWQVyl0yO3BNX08Y9pA4DOIn7WNwpLJ0wdj5mCNfcz tSRxix9V+MmNQlwA8E9+2GvlyXaWATeTzwbGm+SKEYZz3/cCEoiUJjYA4IqSaGo/p3mJXjA4FXL saGSNV1ZQE6ne49XaD76+11YulVhje/ARDoWEGW4REIKCKjGEYNaWdnJU4YZBEi++a/GGODvCjp 4tKlHhRbycnVXwa3jTFLndi3ISR4ONKjwoGkwkgAzUWSWtCX7wOP3lvxIMQ39ua27fy9YMDojAw Y3ovCgocJMCDcyDHu3DX8qNGbmsSVX5U3XwgS/hmZGMoz2ghGGTYxwmPxz X-Received: by 2002:a05:600c:4f91:b0:495:7eab:3abd with SMTP id 5b1f17b1804b1-496c65a26bemr53982335e9.33.1785303962326; Tue, 28 Jul 2026 22:46:02 -0700 (PDT) Received: from localhost ([2c0f:3d00:6be:8900:ce5e:9212:ea4b:f30]) by smtp.gmail.com with ESMTPSA id 5b1f17b1804b1-49764d77970sm31931095e9.5.2026.07.28.22.46.01 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 28 Jul 2026 22:46:01 -0700 (PDT) Date: Wed, 29 Jul 2026 08:45:58 +0300 From: Dan Carpenter To: oe-kbuild@lists.linux.dev, Niranjan H Y Cc: lkp@intel.com, oe-kbuild-all@lists.linux.dev, linux-kernel@vger.kernel.org, Mark Brown , Pierre-Louis Bossart Subject: sound/soc/codecs/tac5xx2-sdw.c:984 tac5xx2_jack_init() warn: missing error code 'ret' Message-ID: <202607291308.8OeeiyIv-lkp@intel.com> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline tree: https://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git master head: fc02acf6ac0ccde0c805c2daa9148683cdd01ba8 commit: 38c89fededd5a9472e8222a20aa066058585f7b2 ASoC: tac5xx2-sdw: add soundwire based codec driver date: 3 months ago config: i386-randconfig-r073-20260729 (https://download.01.org/0day-ci/archive/20260729/202607291308.8OeeiyIv-lkp@intel.com/config) compiler: clang version 22.1.3 (https://github.com/llvm/llvm-project e9846648fd6183ee6d8cbdb4502213fcf902a211) smatch: v0.5.0-9187-g5189e3fb If you fix the issue in a separate patch/commit (i.e. not just a new version of the same patch/commit), kindly add following tags | Fixes: 38c89fededd5 ("ASoC: tac5xx2-sdw: add soundwire based codec driver") | Reported-by: kernel test robot | Reported-by: Dan Carpenter | Closes: https://lore.kernel.org/r/202607291308.8OeeiyIv-lkp@intel.com/ smatch warnings: sound/soc/codecs/tac5xx2-sdw.c:984 tac5xx2_jack_init() warn: missing error code 'ret' vim +/ret +984 sound/soc/codecs/tac5xx2-sdw.c 38c89fededd5a9 Niranjan H Y 2026-05-05 979 static int tac5xx2_jack_init(struct tac5xx2_prv *tac_dev) 38c89fededd5a9 Niranjan H Y 2026-05-05 980 { 38c89fededd5a9 Niranjan H Y 2026-05-05 981 int ret = 0; 38c89fededd5a9 Niranjan H Y 2026-05-05 982 38c89fededd5a9 Niranjan H Y 2026-05-05 983 if (!tac_dev->hs_jack) 38c89fededd5a9 Niranjan H Y 2026-05-05 @984 goto disable_interrupts; Is this supposed to be an error path? tac_dev->hs_jack can't be NULL in real life. 38c89fededd5a9 Niranjan H Y 2026-05-05 985 38c89fededd5a9 Niranjan H Y 2026-05-05 986 ret = regmap_write(tac_dev->regmap, SDW_SCP_SDCA_INTMASK2, 38c89fededd5a9 Niranjan H Y 2026-05-05 987 SDW_SCP_SDCA_INTMASK_SDCA_11); 38c89fededd5a9 Niranjan H Y 2026-05-05 988 if (ret) { 38c89fededd5a9 Niranjan H Y 2026-05-05 989 dev_err(tac_dev->dev, 38c89fededd5a9 Niranjan H Y 2026-05-05 990 "Failed to register jack detection interrupt: %d\n", ret); 38c89fededd5a9 Niranjan H Y 2026-05-05 991 goto disable_interrupts; 38c89fededd5a9 Niranjan H Y 2026-05-05 992 } 38c89fededd5a9 Niranjan H Y 2026-05-05 993 38c89fededd5a9 Niranjan H Y 2026-05-05 994 ret = regmap_write(tac_dev->regmap, SDW_SCP_SDCA_INTMASK3, 38c89fededd5a9 Niranjan H Y 2026-05-05 995 SDW_SCP_SDCA_INTMASK_SDCA_16); 38c89fededd5a9 Niranjan H Y 2026-05-05 996 if (ret) { 38c89fededd5a9 Niranjan H Y 2026-05-05 997 dev_err(tac_dev->dev, 38c89fededd5a9 Niranjan H Y 2026-05-05 998 "Failed to register for button detect interrupt: %d\n", ret); 38c89fededd5a9 Niranjan H Y 2026-05-05 999 goto disable_interrupts; 38c89fededd5a9 Niranjan H Y 2026-05-05 1000 } 38c89fededd5a9 Niranjan H Y 2026-05-05 1001 38c89fededd5a9 Niranjan H Y 2026-05-05 1002 return 0; 38c89fededd5a9 Niranjan H Y 2026-05-05 1003 38c89fededd5a9 Niranjan H Y 2026-05-05 1004 disable_interrupts: 38c89fededd5a9 Niranjan H Y 2026-05-05 1005 /* ignore errors while disabling interrupts */ 38c89fededd5a9 Niranjan H Y 2026-05-05 1006 regmap_write(tac_dev->regmap, SDW_SCP_SDCA_INTMASK2, 0); 38c89fededd5a9 Niranjan H Y 2026-05-05 1007 regmap_write(tac_dev->regmap, SDW_SCP_SDCA_INTMASK3, 0); 38c89fededd5a9 Niranjan H Y 2026-05-05 1008 38c89fededd5a9 Niranjan H Y 2026-05-05 1009 return ret; 38c89fededd5a9 Niranjan H Y 2026-05-05 1010 } -- 0-DAY CI Kernel Test Service https://github.com/intel/lkp-tests/wiki