From: SJ Park <sj@kernel.org>
Cc: SJ Park <sj@kernel.org>,
Andrew Morton <akpm@linux-foundation.org>,
damon@lists.linux.dev, linux-kernel@vger.kernel.org,
linux-mm@kvack.org
Subject: [RFC PATCH v1.2 04/12] mm/damon/core: validate number of probes in valid_probe_params()
Date: Wed, 29 Jul 2026 07:02:44 -0700 [thread overview]
Message-ID: <20260729140253.87753-5-sj@kernel.org> (raw)
In-Reply-To: <20260729140253.87753-1-sj@kernel.org>
Each DAMON context is allowed to have only up to DAMON_MAX_PROBES
probes. The central place for validating DAMON probe parameters,
damon_valid_probe_params(), is not validating the upper limit, though.
Do the validation.
Signed-off-by: SJ Park <sj@kernel.org>
---
mm/damon/core.c | 7 +++++++
1 file changed, 7 insertions(+)
diff --git a/mm/damon/core.c b/mm/damon/core.c
index 1b0f12d17de3a..07f4e7126397b 100644
--- a/mm/damon/core.c
+++ b/mm/damon/core.c
@@ -1401,6 +1401,13 @@ static bool damon_valid_probe_params(struct damon_ctx *ctx)
unsigned char max_probe_hits;
struct damon_probe *probe;
unsigned int wsum, wsum_to_add;
+ int nr_probes;
+
+ nr_probes = 0;
+ damon_for_each_probe(probe, ctx)
+ nr_probes++;
+ if (nr_probes > DAMON_MAX_PROBES)
+ return false;
if (!damon_has_probe_weights(ctx))
return true;
--
2.47.3
next prev parent reply other threads:[~2026-07-29 14:03 UTC|newest]
Thread overview: 13+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-07-29 14:02 [RFC PATCH v1.2 00/12] mm/damon: cleanup code, add test cases, and update guidances in docs SJ Park
2026-07-29 14:02 ` [RFC PATCH v1.2 01/12] mm/damon/core: use damon_nr_samples_per_aggr() for max merge threshold SJ Park
2026-07-29 14:02 ` [RFC PATCH v1.2 02/12] mm/damon/core: remove debug messages SJ Park
2026-07-29 14:02 ` [RFC PATCH v1.2 03/12] mm/damon/vaddr: remove a debug message SJ Park
2026-07-29 14:02 ` SJ Park [this message]
2026-07-29 14:02 ` [RFC PATCH v1.2 05/12] mm/damon/sysfs: remove probes number validation SJ Park
2026-07-29 14:02 ` [RFC PATCH v1.2 06/12] mm/damon/tests/core-kunit: extend set_regions() test for error case SJ Park
2026-07-29 14:02 ` [RFC PATCH v1.2 07/12] mm/damon/tests/core-kunit: test <=0 size damon_set_regions() inputs SJ Park
2026-07-29 14:02 ` [RFC PATCH v1.2 08/12] mm/damon/tests/core-kunit: test overlapping ranges for set_regions() SJ Park
2026-07-29 14:02 ` [RFC PATCH v1.2 09/12] mm/damon/tests/core-kunit: test damon_nr_samples_per_aggr() SJ Park
2026-07-29 14:02 ` [RFC PATCH v1.2 10/12] selftests/damon/sysfs.sh: test hugepage_mem_bp quota goal SJ Park
2026-07-29 14:02 ` [RFC PATCH v1.2 11/12] Docs/mm/damon/maintainer-profile: update AI review for Sashiko replies SJ Park
2026-07-29 14:02 ` [RFC PATCH v1.2 12/12] Docs/ABI/damon: recommend subsystem doc instead of admin-guide SJ Park
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20260729140253.87753-5-sj@kernel.org \
--to=sj@kernel.org \
--cc=akpm@linux-foundation.org \
--cc=damon@lists.linux.dev \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mm@kvack.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox