From: SJ Park <sj@kernel.org>
Cc: SJ Park <sj@kernel.org>,
Andrew Morton <akpm@linux-foundation.org>,
Brendan Higgins <brendan.higgins@linux.dev>,
David Gow <davidgow@davidgow.net>,
damon@lists.linux.dev, kunit-dev@googlegroups.com,
linux-kernel@vger.kernel.org, linux-kselftest@vger.kernel.org,
linux-mm@kvack.org
Subject: [RFC PATCH 2/6] mm/damon/tests/core-kunit: add damon_commit_probes() test
Date: Wed, 29 Jul 2026 07:47:33 -0700 [thread overview]
Message-ID: <20260729144738.90895-3-sj@kernel.org> (raw)
In-Reply-To: <20260729144738.90895-1-sj@kernel.org>
Add kunit test to ensure damon_commit_probes() updates destination DAMON
context with source probes as expected.
Signed-off-by: SJ Park <sj@kernel.org>
---
mm/damon/tests/core-kunit.h | 81 +++++++++++++++++++++++++++++++++++++
1 file changed, 81 insertions(+)
diff --git a/mm/damon/tests/core-kunit.h b/mm/damon/tests/core-kunit.h
index ff864402e9c75..d1e8c612fea03 100644
--- a/mm/damon/tests/core-kunit.h
+++ b/mm/damon/tests/core-kunit.h
@@ -1393,6 +1393,86 @@ static void damon_test_commit_filter(struct kunit *test)
});
}
+static struct damon_ctx *damon_test_help_setup_probes(unsigned int weights[],
+ int nr_weights)
+{
+ struct damon_ctx *ctx;
+ struct damon_probe *probe;
+ int i;
+
+ ctx = damon_new_ctx();
+ if (!ctx)
+ return NULL;
+ for (i = 0; i < nr_weights; i++) {
+ probe = damon_new_probe();
+ if (!probe) {
+ damon_destroy_ctx(ctx);
+ return NULL;
+ }
+ probe->weight = weights[i];
+ damon_add_probe(ctx, probe);
+ }
+ return ctx;
+}
+
+static void damon_test_commit_probes_for(struct kunit *test,
+ unsigned int dst_weights[], int nr_dst_probes,
+ unsigned int src_weights[], int nr_src_probes)
+{
+ struct damon_ctx *dst, *src;
+ int err;
+ struct damon_probe *dst_probe, *src_probe;
+
+ dst = damon_test_help_setup_probes(dst_weights, nr_dst_probes);
+ if (!dst)
+ kunit_skip(test, "dst alloc fail");
+ src = damon_test_help_setup_probes(src_weights, nr_src_probes);
+ if (!src) {
+ damon_destroy_ctx(dst);
+ kunit_skip(test, "src alloc fail");
+ }
+
+ err = damon_commit_probes(dst, src);
+ KUNIT_EXPECT_EQ(test, err, 0);
+ if (err)
+ return;
+ nr_dst_probes = 0;
+ damon_for_each_probe(dst_probe, dst)
+ nr_dst_probes++;
+ nr_src_probes = 0;
+ damon_for_each_probe(src_probe, src)
+ nr_src_probes++;
+ KUNIT_EXPECT_EQ(test, nr_dst_probes, nr_src_probes);
+ nr_dst_probes = 0;
+ damon_for_each_probe(dst_probe, dst) {
+ src_probe = damon_nth_probe(nr_dst_probes, src);
+ KUNIT_EXPECT_EQ(test, src_probe->weight, dst_probe->weight);
+ nr_dst_probes++;
+ }
+ damon_destroy_ctx(dst);
+ damon_destroy_ctx(src);
+}
+
+static void damon_test_commit_probes(struct kunit *test)
+{
+ damon_test_commit_probes_for(test,
+ (unsigned int[]){}, 0, (unsigned int[]){}, 0);
+ damon_test_commit_probes_for(test,
+ (unsigned int[]){}, 0, (unsigned int[]){1}, 1);
+ damon_test_commit_probes_for(test,
+ (unsigned int[]){}, 0, (unsigned int[]){1, 2}, 2);
+ damon_test_commit_probes_for(test,
+ (unsigned int[]){1}, 1, (unsigned int[]){2}, 1);
+ damon_test_commit_probes_for(test,
+ (unsigned int[]){1}, 1, (unsigned int[]){2, 3}, 2);
+ damon_test_commit_probes_for(test,
+ (unsigned int[]){2, 3}, 2, (unsigned int[]){1}, 1);
+ damon_test_commit_probes_for(test,
+ (unsigned int[]){2, 3}, 2, (unsigned int[]){}, 0);
+ damon_test_commit_probes_for(test,
+ (unsigned int[]){2}, 1, (unsigned int[]){}, 0);
+}
+
static void damon_test_commit_ctx(struct kunit *test)
{
struct damon_ctx *src, *dst;
@@ -1745,6 +1825,7 @@ static struct kunit_case damon_test_cases[] = {
KUNIT_CASE(damos_test_commit_migrate_hot),
KUNIT_CASE(damon_test_commit_target_regions),
KUNIT_CASE(damon_test_commit_filter),
+ KUNIT_CASE(damon_test_commit_probes),
KUNIT_CASE(damon_test_commit_ctx),
KUNIT_CASE(damos_test_filter_out),
KUNIT_CASE(damon_test_feed_loop_next_input),
--
2.47.3
next prev parent reply other threads:[~2026-07-29 14:47 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-07-29 14:47 [RFC PATCH 0/6] mm/damon: add kunit and selftests for probes and probe weights SJ Park
2026-07-29 14:47 ` [RFC PATCH 1/6] mm/damon/tests/core-kunit: test damon_commit_filter() SJ Park
2026-07-29 14:47 ` SJ Park [this message]
2026-07-29 14:47 ` [RFC PATCH 3/6] selftests/damon/_damon_sysfs: implement DamonProbes SJ Park
2026-07-29 14:47 ` [RFC PATCH 4/6] selftests/damon/drgn_dump_damon_status: dump probes SJ Park
2026-07-29 14:47 ` [RFC PATCH 5/6] selftests/damon/sysfs.py: extend commit assertion function for probes SJ Park
2026-07-29 14:47 ` [RFC PATCH 6/6] selftests/damon/sysfs.py: test damon probes SJ Park
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20260729144738.90895-3-sj@kernel.org \
--to=sj@kernel.org \
--cc=akpm@linux-foundation.org \
--cc=brendan.higgins@linux.dev \
--cc=damon@lists.linux.dev \
--cc=davidgow@davidgow.net \
--cc=kunit-dev@googlegroups.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-kselftest@vger.kernel.org \
--cc=linux-mm@kvack.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox