From: Jakub Kicinski <kuba@kernel.org>
To: Vikas Gupta <vikas.gupta@broadcom.com>
Cc: davem@davemloft.net, edumazet@google.com, pabeni@redhat.com,
andrew+netdev@lunn.ch, horms@kernel.org, netdev@vger.kernel.org,
linux-kernel@vger.kernel.org, bhargava.marreddy@broadcom.com,
rahul-rg.gupta@broadcom.com, vsrama-krishna.nemani@broadcom.com,
rajashekar.hudumula@broadcom.com, dharmender.garg@broadcom.com,
ajit.khaparde@broadcom.com
Subject: Re: [PATCH net-next 0/4] bnge: add more functionality
Date: Wed, 29 Jul 2026 16:33:52 -0700 [thread overview]
Message-ID: <20260729163352.6e0b9bc5@kernel.org> (raw)
In-Reply-To: <20260724142954.3101980-1-vikas.gupta@broadcom.com>
On Fri, 24 Jul 2026 19:59:50 +0530 Vikas Gupta wrote:
> Patch 1: Makes bnge_shutdown() functional by properly unregistering the
> netdevice and freeing associated hardware queues and interrupts.
> Patch 2: Implements ndo_set_rx_mode_async().
>
> Patch 3: Adds a dedicated HWRM (Hardware Resource Management) command
> sequence to handle explicit interface down and up transitions cleanly.
If you have to respin - there are 4 patches in the series.
Sashikos point at bugs in the EAGAIN flow handling in
ndo_set_rx_mode_async. Can you double check that?
https://sashiko.dev/#/patchset/20260724142954.3101980-2-vikas.gupta@broadcom.com
https://netdev-ai.bots.linux.dev/sashiko/#/patchset/20260724142954.3101980-2-vikas.gupta@broadcom.com
And the concern about IRQs being in use on shutdown perhaps.
[P.S. Ugh, looks like I wrote this yesterday but didn't it send? sorry]
prev parent reply other threads:[~2026-07-29 23:33 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-07-24 14:29 [PATCH net-next 0/4] bnge: add more functionality Vikas Gupta
2026-07-24 14:29 ` [PATCH net-next 1/4] bnge: add steps in bnge_shutdown() Vikas Gupta
2026-07-29 2:09 ` Jakub Kicinski
2026-07-24 14:29 ` [PATCH net-next 2/4] bnge: refactor rx mode helpers to accept explicit address lists Vikas Gupta
2026-07-29 2:08 ` Jakub Kicinski
2026-07-29 2:09 ` Jakub Kicinski
2026-07-24 14:29 ` [PATCH net-next 3/4] bnge: add ndo_set_rx_mode_async support Vikas Gupta
2026-07-29 2:09 ` Jakub Kicinski
2026-07-24 14:29 ` [PATCH net-next 4/4] bnge: send hwrm for interface down/up transitions Vikas Gupta
2026-07-29 2:08 ` Jakub Kicinski
2026-07-29 2:09 ` Jakub Kicinski
2026-07-29 23:33 ` Jakub Kicinski [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20260729163352.6e0b9bc5@kernel.org \
--to=kuba@kernel.org \
--cc=ajit.khaparde@broadcom.com \
--cc=andrew+netdev@lunn.ch \
--cc=bhargava.marreddy@broadcom.com \
--cc=davem@davemloft.net \
--cc=dharmender.garg@broadcom.com \
--cc=edumazet@google.com \
--cc=horms@kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=netdev@vger.kernel.org \
--cc=pabeni@redhat.com \
--cc=rahul-rg.gupta@broadcom.com \
--cc=rajashekar.hudumula@broadcom.com \
--cc=vikas.gupta@broadcom.com \
--cc=vsrama-krishna.nemani@broadcom.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox