From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail-wr1-f42.google.com (mail-wr1-f42.google.com [209.85.221.42]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id C9D09453A56 for ; Wed, 29 Jul 2026 14:43:29 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.221.42 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1785336211; cv=none; b=LOyv9Xtkw4gASw3+XDgql9G+1XyalxbLz50wsohzXs4A+cThSOxl3RSwp2fEc3e61kl3KB4GqCODCB61n7h4LQfM9z5Brd9nJbUcFnmi54nF2I2Oi3/zGBoNWYjlxoQPOheYy34qq0W+K0zcirIjvBha8zcLvPlu10sEmZPLM3k= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1785336211; c=relaxed/simple; bh=fJzBEsV+r2rsxHE7wtzfpu6HLOOVOkXN/h6IJb+JkTU=; h=Date:From:To:Cc:Subject:Message-ID:In-Reply-To:References: MIME-Version:Content-Type; b=qiIDKl7LIPShqyvgvKNNrBq1wnyPF44ImSiCV0dLA6BymlhmffLL7III9+McLIcU1aswLOHmkEhVQiUjO9CSaZB626Lg7rdwC9mN3GKsvn9dulMMy3ewf2HgjMNQkpVZeJ+luFYqSMoLdJCGq/vJmEB0MBKKEBOZh3RcDFFQXsw= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com; spf=pass smtp.mailfrom=gmail.com; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b=BQ60eEbX; arc=none smtp.client-ip=209.85.221.42 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=gmail.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="BQ60eEbX" Received: by mail-wr1-f42.google.com with SMTP id ffacd0b85a97d-47f9ab7ee38so689583f8f.2 for ; Wed, 29 Jul 2026 07:43:29 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20251104; t=1785336208; x=1785941008; darn=vger.kernel.org; h=content-transfer-encoding:content-type:mime-version:references :in-reply-to:message-id:subject:cc:to:from:date:from:to:cc:subject :date:message-id:reply-to:content-type; bh=d8oryUDvqGtQsqz51BYnQBJc1k4wLZ1+2yLF7stESiM=; b=BQ60eEbX1kStZvMdtr89prFtjzls9ZGgzJb+qrmh1dYt6MGlzNDJh5Q3WLfu2P5aTD +raW87PfuKPISl/oHa2vncnm9JGowQjJpgXCrNsNDkKO5tsIOJVImfTaYZYTqnPK0dK2 IhS1ZuDTutF0KvzUz81R3W8iAdsDJkWnJSFJ4Z8gtrQrXWDjC1Y5osBieaDgpEV5Qa8l ASjjjO/EQ+1KkU1Ze8VKlky854KArm4Kkj2KDZSUit/BKjnZ30qQW3IEXU7b6joItx3b f2ZjpFUiDgzlisbHwGzz6p3dGPkPsUKT/Wab4mP7q4Rh3/EgYvwDApdYLyr2VUf4hrG/ SFgg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1785336208; x=1785941008; h=content-transfer-encoding:content-type:mime-version:references :in-reply-to:message-id:subject:cc:to:from:date:x-gm-gg :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to :content-type; bh=d8oryUDvqGtQsqz51BYnQBJc1k4wLZ1+2yLF7stESiM=; b=U1ZIOo48Ctull5aUmf/61lMgB6Xo5/nBuLnm+YZjpwPvMhpNueRhe7OmeOujSTZ1fe kwG4unFgg10et50qdngpXfDyajRDcOF9LmBCm//tWNEreBdnOLMn5hvHRnlCC+VIOLZQ o4/RkjN/jrWB69Qhm6fZdvhtO8+/nBrOdh4LNs2ZAoE39JU9ld1B1GiQlcWgk8D/Llx9 HvQmqPHndZq6IjI1o2y6SdjY3pE3RVn7HAPEVvBee3leukrgnCdgBqtj00FI78Hx2zw6 rK7EF6n4Qfjhfuo0tVN2hBt9dUZAVBB5OTLoiAybq18mcCv7+sGAswULL2np2YQGF18F 0SnQ== X-Forwarded-Encrypted: i=1; AHgh+Rqpv/QCHs7+tykLULKENVy3QJWhI+tnUeJRQWtROxEsd2fxwvybpvI23KEgd07bMRJ3bdzimn2UyxpgvtY=@vger.kernel.org X-Gm-Message-State: AOJu0YzvyzXjJI0ksOlg31VhnMFIaGWu9q6Hhjnyj59j5B0Ky7JxpfhO FHxGgtM9+UYnUQvePx8lMnGRegaqGCiaZsdoM1+ZNi1bFTOsJNRtkPSR X-Gm-Gg: AR+sD10A4fOLE3palfr+O3eFxNUlSynfT47y7gKKz5Lw9axww0exp/waWQSG+4Bu1jb xUDsNV2DUYVLyTlKVQ9dUaSQbOzP7MCUcS6EqU8JdPg2eC3AMSWOjpJ+DV01DkYO+ACV7fkAIqP Vbu1dvh6uzekTg4RaqIoOk8ip+qtSiZG/xNsMaYAIGgKBDsrG+wLCmTmy8Tg3+1H1N94CrAwIt/ ntVL/Epi404Wzxcl0IRePqVHmEVT90Bp3lVINiSvMD4PtQPzR/RH4NQaGxFCq0+jYZf5P6itaLz lnuDNl/rQyhldgVldSmjY3XyVd35psxfrZdKes4edSuNRf49b0kO9C3QzGhUbG1PbI1tLP12XqH /nrJ//hD4dwTo8x5lFHVfL9ycxZcAQKOM84R9IqafyxHVMlLKFS/IH2PLRGr3OL1Zb0DFSaCxGc Uei2mgO4R/vfo2SBGzjif87aUCV1bZViNYtUooPuJklwrxFcoKSQTpecnj49rpL93Vku5Qqbwym /bwp1Ivjg5QUBoB2svg4ZekFWzS5dyDpOhr0ZXeia+vPBBSvAliHYdo6RcKtjsDefRRlZaUMRSe RzMIE+uvhuHZr8wr307YS+PXQQXqFMnt+oeZ06M4rtgnbz7F1pI95xXgwwygK17hiyQhtGbT0Hf 5gTWA5MK9vXYbPtGWr9sJp6QsPsaKryOyq8bBjCTmC6sFNq1ui/CtcdNz7JsO8CGbTC62rtU= X-Received: by 2002:a05:6000:220f:b0:47f:4e42:669 with SMTP id ffacd0b85a97d-47fb1ed964cmr8993565f8f.22.1785336207932; Wed, 29 Jul 2026 07:43:27 -0700 (PDT) Received: from localhost (90-182-112-124.rcp.o2.cz. [90.182.112.124]) by smtp.gmail.com with ESMTPSA id ffacd0b85a97d-47fb647a8d4sm8618890f8f.0.2026.07.29.07.43.27 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Wed, 29 Jul 2026 07:43:27 -0700 (PDT) Date: Wed, 29 Jul 2026 16:43:26 +0200 From: Joshua Crofts To: Dileep Kumar Nagavarapu Cc: Jonathan Cameron , David Lechner , Nuno =?ISO-8859-1?Q?S=E1?= , Andy Shevchenko , Michal Simek , Conall O'Griofa , , , , , Sai Krishna Potthuri Subject: Re: [PATCH v3 1/6] iio: adc: xilinx-xadc: Modernize driver code Message-ID: <20260729164326.00005c44@gmail.com> In-Reply-To: <20260729125455.95893-2-DileepKumar.Nagavarapu@amd.com> References: <20260729125455.95893-1-DileepKumar.Nagavarapu@amd.com> <20260729125455.95893-2-DileepKumar.Nagavarapu@amd.com> X-Mailer: Claws Mail 4.4.0 (GTK 3.24.51; x86_64-w64-mingw32) Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit On Wed, 29 Jul 2026 18:24:50 +0530 Dileep Kumar Nagavarapu wrote: > Modernize the XADC driver by updating the code to follow current > kernel development practices. > > The changes include: > - Switching to kernel integer types (u16, u32) > - Replacing open-coded bit manipulation with GENMASK(), > and FIELD_GET() helpers > - Using cleanup and guard helpers where appropriate > - Addressing coding style issues reported by checkpatch.pl > - Removing legacy coding patterns and simplifying the code > - Added MAINTAINERS entry for the Xilinx XADC driver > > These updates improve readability, maintainability, and consistency > with modern kernel APIs without changing functionality. > > No functional change intended. > > Co-developed-by: Sai Krishna Potthuri > Signed-off-by: Sai Krishna Potthuri > Signed-off-by: Dileep Kumar Nagavarapu > --- I thought I was reading a cover letter and then I realized that these are all changes in one patch only. Please separate this into multiple patches, I count 6 separate patches. > MAINTAINERS | 7 + > drivers/iio/adc/xilinx-xadc-core.c | 351 ++++++++++++--------------- > drivers/iio/adc/xilinx-xadc-events.c | 53 ++-- > drivers/iio/adc/xilinx-xadc.h | 78 +++--- > 4 files changed, 222 insertions(+), 267 deletions(-) > ... > diff --git a/drivers/iio/adc/xilinx-xadc-core.c b/drivers/iio/adc/xilinx-xadc-core.c > index cab66bb8cc1c..b468179736f7 100644 > --- a/drivers/iio/adc/xilinx-xadc-core.c > +++ b/drivers/iio/adc/xilinx-xadc-core.c > @@ -11,6 +11,9 @@ > * - AXI XADC interface: Xilinx PG019 > */ > > +#include > +#include > +#include Since you're moving the driver to kernel types, include as well. Maybe you could do an additional patch that removes the catch-all kernel.h header and adds used/removes unused headers in accordance with the IWYU principle? -- Kind regards, Joshua Crofts