From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail-pf1-f175.google.com (mail-pf1-f175.google.com [209.85.210.175]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id C174545C6F4 for ; Wed, 29 Jul 2026 17:10:08 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.210.175 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1785345010; cv=none; b=N2QA5ckidV1ImCKPmPG5Q3acFvnTTTIa//gWFKb8CUuDUA55GoY8OepCqTXBemAtSpLhPyq/bZC5VZOE+NyjFRD+HBgSm3ewf/gG1ksSoGZSC3YAYW7TsPDiL4olJ8lI+OjQvFEB+hQ5T1VRDXL0xgScHH4HRlJeDRu7KT4+GQs= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1785345010; c=relaxed/simple; bh=hozdLyqkwUyv7nQGeKMb9Yul7dJcbrG59xMfsmKI734=; h=From:To:Cc:Subject:Date:Message-ID:In-Reply-To:References: MIME-Version; b=ETy8Z836c2G2csu3jQrF/+l1RWXWoutfmHty8cKmXWYFqpzNMNzJ6yvRXYpgpYcPeozkEXbPzsyVcgaxGOu73xfZEoH1wvAOYHXhvpQ9mLEhMmOTdD3tFVrJELOAf65L/N110eNqoIPII3yNZ6mm6+teZjF0KCRQ4UMtBDDdl50= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com; spf=pass smtp.mailfrom=gmail.com; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b=F/vliqsd; arc=none smtp.client-ip=209.85.210.175 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=gmail.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="F/vliqsd" Received: by mail-pf1-f175.google.com with SMTP id d2e1a72fcca58-8423f236418so1020306b3a.1 for ; Wed, 29 Jul 2026 10:10:08 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20251104; t=1785345008; x=1785949808; darn=vger.kernel.org; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to:content-type; bh=Ep93HPjH5mmfbaJOhBXSdXp3nxY941Jgshzn8ZjPsSw=; b=F/vliqsdRzUs6x4m569+gWW9LXTjPHZs0AlBqg+/qTrvhwiYgpP2q5gzamkDwsAxdl AHmv3iaVYyGRBviw7HnjdCCdZjz7TeP+kiOnYF0bcw4/BeVdoFdLkntYNxfLgbw3y9oS OSu7Vby6N9degefnfnpuWKA9qDw+y86w9n8/CjugCJ6lsBQrd8U9+j+XH8hn+qJPFBvn Rwivr/FRIKP2bk6j4KI31AvCiC9VcrCoDSNk/cOwIeYdohWZnfwAUT4FFd7wqCwCoorw FHA9UaX28fxDUPRB++Vv3BHO4J72mvBDB5Q7Q8iWH2mCgW+EGCmLAQSiy1L03ID1t3I7 WT5Q== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1785345008; x=1785949808; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-gg:x-gm-message-state:from :to:cc:subject:date:message-id:reply-to:content-type; bh=Ep93HPjH5mmfbaJOhBXSdXp3nxY941Jgshzn8ZjPsSw=; b=lZggISWvE/4pCYCTfyPEaowyVY+a2JRNrMtH6JfxQOCn8qhO47J4EQzO+tMYN5RO04 v2+niYTP0oeW/Gibrc428zC7SZnj8hFJp61N8j2KjP8PntuNYahqSBlzzPR97Ofjnb/f buOfcec5+q7XO19FDuGGwV6eK+jGjpfuy5PpiQcs8PuOVwt/UXD86uE6tcrxZJcCgY03 JQbo2tXoqu3uPYCkvZ3jxBSjEVwhktZ2vSRHk3URgEWtpzqbBmmd3bRpNi/l2uXVCVjS 2hQh3FVsnkr0ebm4FENGESwANtVfv7FiwJ36mIqf/kYH5IYzYXSYpfwXGGZLhvI7CDf/ RBwg== X-Forwarded-Encrypted: i=1; AHgh+RqQ8xyh3T0AHA+qlD8aI8lV9PtMiwrhmS1ghMbzTTxJN2GjtpaWwuBcOKd2IxK/mf+xTSFAIATS8X7AloE=@vger.kernel.org X-Gm-Message-State: AOJu0YxUEZdch+EIe7OGbwiCJDIIsrykahyzrkyuW8f/iB7tDdYOHyhf 60nkxg7UmUXeOu+k76iJPizgS460uppNX6nZEhDlrUCBldEFz0oTsWx9 X-Gm-Gg: AR+sD116sagrSjsNxQU4JQvvRzGKfQvY5fB6c78B/KQrh59+2tmkZNE9zgfP9qJ9xOK 8+Iq3ex0szCManmpv2Y8kUuUhJhyJy949RqQqM+2SFzcZyGZa2Wy1RDJLx6Z8g1RVUo2oWkTrzZ LTByznsnY37UqkkC37Ia3Zmj95Gnqg0CzozrECNo7H28aBRkx+v5J47nNQcc6YdcigBLH08KXQg PCxPp4Z4FJe7vE/nhbvXkr32fmu9r5+m9nOiQhyEjbuPp7uggWXxX7IAPVFbLYLH/yzVJJUoz+I JS6C2APvQN+5E9j8fvGzTNBtpxDroT7GCBWrnHF3d5/BPwEk+kyyl1G9TG/X3xmhuiKliWTs4m9 PsJw5LioOhB5M/C8lw1gh7bCvI6zQlgPFiwnI0gHW7Ki1jCawr4z8zcI64bsfCpndm3A9nNF1Ri K2sMBSpO/LO6qmYf4utzk9imsTAusdnCmUFvFSprwz8ZOieWl43Kx5AOg= X-Received: by 2002:a05:6a00:10c3:b0:845:d274:c024 with SMTP id d2e1a72fcca58-84e932c7a28mr7886101b3a.61.1785345007996; Wed, 29 Jul 2026 10:10:07 -0700 (PDT) Received: from ubuntu.. ([110.9.142.4]) by smtp.gmail.com with ESMTPSA id d2e1a72fcca58-84ea0052e04sm1694231b3a.22.2026.07.29.10.10.06 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Wed, 29 Jul 2026 10:10:07 -0700 (PDT) From: Sang-Heon Jeon To: Dmitry Torokhov Cc: linux-input@vger.kernel.org, linux-kernel@vger.kernel.org Subject: [PATCH v2 1/3] Input: pmic8xxx-keypad - remove conditional return with no effect Date: Thu, 30 Jul 2026 02:09:33 +0900 Message-ID: <20260729171001.260698-2-ekffu200098@gmail.com> X-Mailer: git-send-email 2.43.0 In-Reply-To: <20260729171001.260698-1-ekffu200098@gmail.com> References: <20260729171001.260698-1-ekffu200098@gmail.com> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: 8bit Both branches of the check return the same value, so the check has no effect. Remove it and return the value directly. This is the result of running the Coccinelle script from scripts/coccinelle/misc/cond_return_no_effect.cocci. Signed-off-by: Sang-Heon Jeon --- drivers/input/keyboard/pmic8xxx-keypad.c | 8 +------- 1 file changed, 1 insertion(+), 7 deletions(-) diff --git a/drivers/input/keyboard/pmic8xxx-keypad.c b/drivers/input/keyboard/pmic8xxx-keypad.c index 35d1aa2a22a5..c916e80e2f58 100644 --- a/drivers/input/keyboard/pmic8xxx-keypad.c +++ b/drivers/input/keyboard/pmic8xxx-keypad.c @@ -462,15 +462,9 @@ static int pmic8xxx_kp_enable(struct pmic8xxx_kp *kp) static int pmic8xxx_kp_disable(struct pmic8xxx_kp *kp) { - int rc; - kp->ctrl_reg &= ~KEYP_CTRL_KEYP_EN; - rc = regmap_write(kp->regmap, KEYP_CTRL, kp->ctrl_reg); - if (rc < 0) - return rc; - - return rc; + return regmap_write(kp->regmap, KEYP_CTRL, kp->ctrl_reg); } static int pmic8xxx_kp_open(struct input_dev *dev) -- 2.43.0