From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail-vk1-f173.google.com (mail-vk1-f173.google.com [209.85.221.173]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id C810A43CEE7 for ; Wed, 29 Jul 2026 22:14:32 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.221.173 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1785363274; cv=none; b=biFXdql4YKZdq+8dVM0sL1DnIfNH0mef9wEfExzD7qbXF1tr3+ml9sbP3mgQ5j/RvHqgJ/uxvvIo41eU7/CR7SB5O3r0MlGOOG3poLLg3BrihH0/PKF+mao2/tKEaxaaBgtHiFPn/LRRDvB2z/rp+z6NDyB3LPqP8wZOHtMNuMQ= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1785363274; c=relaxed/simple; bh=tFlH95MChwTnDp6rMME2y4i5ULh+qHvaBd1XlI957o4=; h=From:To:Cc:Subject:Date:Message-ID:MIME-Version; b=R958y/+n2iNsA3Q8hECF0dBS2RBuS5V2rRhrzCtzJ7uZ3fGXZydHlI+tJmXLjp8Xegbt8cI4CTrADlP69JVfknvt/xiQYg1miRrPPNF5T4JYTjGCbpDtc0W+ahfuVx9M61vGVHGjwvub/uQXt80Rr5ZBle3pCuBuzkjVVmldiV0= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com; spf=pass smtp.mailfrom=gmail.com; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b=FEiZ/+n2; arc=none smtp.client-ip=209.85.221.173 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=gmail.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="FEiZ/+n2" Received: by mail-vk1-f173.google.com with SMTP id 71dfb90a1353d-59b074ec7ceso530167e0c.1 for ; Wed, 29 Jul 2026 15:14:32 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20251104; t=1785363271; x=1785968071; darn=vger.kernel.org; h=content-transfer-encoding:mime-version:message-id:date:subject:cc :to:from:from:to:cc:subject:date:message-id:reply-to:content-type; bh=8T1b0patbsofaK9CnxW2rL9dJ5bYZkc3ipS6ER6koZk=; b=FEiZ/+n25ck9JJx5QRkS+czh1aQrYr5m2JVK1Q8bo3m4RhntiPox8bME6la9WmCx7U EOdH36icStFqHsByP+9EP8LcLlQYyRvKiD9n9ekHWPdR1l2sKpSXVDiRbp/CMwCWGVTL mI+u+8K++mniVZ5JsXc92tXNaBwU9iILd1VsFp7H6vrkTq1EBHDWn8nzmEeV2txSaYmY Gk8b1Ndm2BM6EPUfGDOrLa0xOaCKCKZ/wsy9U00QENxBGZUhav5UR+uBIx4KnI2nwZcS XWHt7rarnTXRPAjxnZfBaHhVsCEyncphDjVNNi4FTD7ncWx+l4n+LOk9XwE78ZGLTyyb 38fw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1785363271; x=1785968071; h=content-transfer-encoding:mime-version:message-id:date:subject:cc :to:from:x-gm-gg:x-gm-message-state:from:to:cc:subject:date :message-id:reply-to:content-type; bh=8T1b0patbsofaK9CnxW2rL9dJ5bYZkc3ipS6ER6koZk=; b=CQzBqX77TihOJ06FPGxyNPbD9lz1ZrxIf3ek2W4YJ9D0ApHY4F0jww3pzVavvM+J2m 6NY/+3EXBFcZ5YBWNsoA0iee3EVCN5N14RR93D89t6DaDH1UGnKTB0K9XJtANqmXmrj7 C2bkq0g4BdHmiz/JdM7tfX0bWGT39r86LtqRPA4bBQfQMEXrZcCI9BbBP2oFv3tcA6Sr fDC9tm7mvxU0JxMEeVJeWihV4QJY9ZAt00JNSwXo8YF+kSPdzbRI72ztTNRROPSsdyi9 +i+C6z23cZFSbx+qdyBcInduwX6FIjOfji1Byxo72ReJZBesm2VqRtIoSGlqjRaLHA2A MXYQ== X-Forwarded-Encrypted: i=1; AHgh+RoeJm9jhVGnonafJF8mvOwciVfZOK6KVNy69wHKk5GJbzWLBHDcPi0fxvvzyeZYyYCLSLa0TVCQ+0RfZBQ=@vger.kernel.org X-Gm-Message-State: AOJu0YzElxjgflD7ytBKI142NJq5cHHAzLxVPddRfG4hvUwERxKHpNJ/ OU2ZUtYcgt2glwRp661TZI/6WTGMqwe1Mqho1lQbv+9J6ovS1lREJcg5 X-Gm-Gg: AR+sD125cZLibl5SmcC/BZNvSiD6m3V8vz8yNNqk31MNE2b97yfgRBHP+kXI1pqlpeO wfNcgxfPZ1AKGvxs8e/1W9H9W1ns+8UMl55gDmigvv+vAta77Tp7jPI9w34G7ZZZQZ8XT6sAx1f uI17jgFopXXkGFJEJ4SsW/3S+04+BR7hjYS95rGSC8Nm2wzrm9CybonA+gXqA2WERGVTtEMdncI OiW6myCt6gNx6vy6mI0D6clGa/MrBZLJESNpkliYgQsocGhS1T7zVOkZe7yTK606igQ3qumG/6H 18GyXFByNbjCBmBaal41sy+MQglI22ZWRtkQUcjZrOfSXGOCe/9E27VN3nX0ipWGePI7jLlcKkw KmwKd7ryTdj5acr+kyQ/CdEj/kstTIDt4Zhn89HW9ga5mPI6nr6IGf8DmBLZn+GLMJxN1pNtaYw 87qtXLYOjDVsHBSmlWI7MmZXtngDvdaeOuiA/GW2vEbXXoemEvytQ2HDFKmtyAjLTV2OJUdb5IB SL6CkkBDQ0yAJf02QjekAfvwyxrYVHO3w9Agg== X-Received: by 2002:a05:6122:8b04:b0:5c1:2150:9de7 with SMTP id 71dfb90a1353d-5c36624b938mr307e0c.12.1785363271392; Wed, 29 Jul 2026 15:14:31 -0700 (PDT) Received: from fabio-X870-EAGLE-WIFI7.. ([2804:1b3:a801:60b4:a913:91a7:b883:6046]) by smtp.gmail.com with ESMTPSA id 71dfb90a1353d-5c34eefcf80sm3269180e0c.1.2026.07.29.15.14.28 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Wed, 29 Jul 2026 15:14:30 -0700 (PDT) From: Fabio Estevam To: tglx@kernel.org Cc: radu@rendec.net, Frank.Li@nxp.com, imx@lists.linux.dev, linux-kernel@vger.kernel.org, Fabio Estevam Subject: [PATCH v2] irqchip: imx-irqsteer: Convert to devm_pm_runtime_enable() Date: Wed, 29 Jul 2026 19:14:16 -0300 Message-ID: <20260729221416.499781-1-festevam@gmail.com> X-Mailer: git-send-email 2.43.0 Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: 8bit imx_irqsteer_probe() enables runtime PM, but imx_irqsteer_remove() does not disable it. Consequently, runtime PM remains enabled after unbinding the device, and rebinding it triggers: Unbalanced pm_runtime_enable! Use devm_pm_runtime_enable() to automatically disable runtime PM when the device is removed. Fixes: 4730d2233311 ("irqchip/imx-irqsteer: Add runtime PM support") Signed-off-by: Fabio Estevam --- Changes since v1: - Use devm_pm_runtime_enable() (Frank) drivers/irqchip/irq-imx-irqsteer.c | 4 +++- 1 file changed, 3 insertions(+), 1 deletion(-) diff --git a/drivers/irqchip/irq-imx-irqsteer.c b/drivers/irqchip/irq-imx-irqsteer.c index 87b07f517be3..ba1203d3edd4 100644 --- a/drivers/irqchip/irq-imx-irqsteer.c +++ b/drivers/irqchip/irq-imx-irqsteer.c @@ -263,7 +263,9 @@ static int imx_irqsteer_probe(struct platform_device *pdev) platform_set_drvdata(pdev, data); pm_runtime_set_active(&pdev->dev); - pm_runtime_enable(&pdev->dev); + ret = devm_pm_runtime_enable(&pdev->dev); + if (ret) + goto out; return 0; out: -- 2.43.0