From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from out-183.mta0.migadu.com (out-183.mta0.migadu.com [91.218.175.183]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id DF7AF37FF7F for ; Thu, 30 Jul 2026 06:09:19 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=91.218.175.183 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1785391762; cv=none; b=dJq+3JISB2s3XKc+tp52gLYb26UYYZUIgfMDwGDYrgC+24Gws9fluzUfamuvUAe57EcFy62v5UeuLfDMp5VK/u6xqjFKuA68q/Qx8rSSkuXE1HaNs2ER6Fy3LyNtRRR+ziEefk9S/eFqRaBm8ul7Xek5U0AlRaxxjZAQpGlz2qQ= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1785391762; c=relaxed/simple; bh=cMRHW5rNkYJRNQLff7L96yh3ojPO8UNrg0QnbPXu/dg=; h=From:To:Cc:Subject:Date:Message-ID:In-Reply-To:References: MIME-Version; b=mHxiYW8cQm0jLmq9I4qkS9+tis88xPK8NasJEYrHDAbzhmazVTA4RWnMc3kdqQ/UIXjXa5U02zoBE/+WXf67yPDNHFhbj1ar4byH2+AbVrzLttn70ggngJUZ1fuWRP4RNR1sDJkt3WkavT6W2hRrGnDYloeECY9NNtLVrRVphp4= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=linux.dev; spf=pass smtp.mailfrom=linux.dev; dkim=pass (1024-bit key) header.d=linux.dev header.i=@linux.dev header.b=J7oxhrvN; arc=none smtp.client-ip=91.218.175.183 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=linux.dev Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=linux.dev Authentication-Results: smtp.subspace.kernel.org; dkim=pass (1024-bit key) header.d=linux.dev header.i=@linux.dev header.b="J7oxhrvN" X-Report-Abuse: Please report any abuse attempt to abuse@migadu.com and include these headers. DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linux.dev; s=key1; t=1785391757; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=cMRHW5rNkYJRNQLff7L96yh3ojPO8UNrg0QnbPXu/dg=; b=J7oxhrvND7xWHIiuCk6omtothFXltw9FlM8VB4yW98r5yFTKTIM9gtG+Zcw9LtQa6gKmRa VD6dTcc6z1c18ZaLgBSC5VG/IFf4eDKihDL8aQC7KtJvipwcsmrqhB/Rtw9nWcUZpyRJUE 1b471Dk8QBQWksbSsNtE2xnfcJcYl2U= From: luka.gejak@linux.dev To: Bitterblue Smith Cc: Luka Gejak , Ping-Ke Shih , linux-wireless@vger.kernel.org, linux-kernel@vger.kernel.org, Michael Straube , Peter Robinson Subject: Re: [PATCH 05/19] wifi: rtw88: fw: send rate adaptation and RSSI info in the vendor layout Date: Thu, 30 Jul 2026 06:08:50 +0000 Message-ID: <20260730060903.30187-3-luka.gejak@linux.dev> In-Reply-To: References: Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-Migadu-Flow: FLOW_OUT From: Luka Gejak On 25/07/2026 02:46, Bitterblue Smith wrote: > Not sure where you found the value 0x04. I see in > hal/phydm/phydm_rssi_monitor.c that it's setting bit 1, same as rtw88. > The other bytes you set here are equivalent to the macros in the else > branch. Agreed, there is nothing here the existing macros do not already do. > This doesn't look like the vendor driver's behaviour. To me it > looks like rtw88 is already handling the no_update bit correctly. > > I bet you don't need to modify rtw_fw_send_ra_info() at all. You are right. Without the patch the negotiated rate and uplink are unchanged, MCS7 either way, so the whole patch is dropped in v2. Best regards, Luka Gejak