The Linux Kernel Mailing List
 help / color / mirror / Atom feed
From: Yixun Lan <dlan@kernel.org>
To: linux-kernel@vger.kernel.org, Rob Herring <robh@kernel.org>,
	Krzysztof Kozlowski <krzk+dt@kernel.org>,
	Conor Dooley <conor+dt@kernel.org>,
	Paul Walmsley <pjw@kernel.org>,
	Palmer Dabbelt <palmer@dabbelt.com>,
	Albert Ou <aou@eecs.berkeley.edu>,
	Alexandre Ghiti <alex@ghiti.fr>,
	"open list:OPEN FIRMWARE AND FLATTENED DEVICE TREE BINDINGS"
	<devicetree@vger.kernel.org>,
	"open list:RISC-V ARCHITECTURE" <linux-riscv@lists.infradead.org>,
	"open list:RISC-V SPACEMIT SoC Support"
	<spacemit@lists.linux.dev>
Subject: Re: [PATCH v2 4/4] riscv: dts: spacemit: Add Milk-V Jupiter board (M1)
Date: Thu, 30 Jul 2026 11:29:32 +0000	[thread overview]
Message-ID: <20260730112932-GKF77474@kernel.org> (raw)
In-Reply-To: <amsj0kK6LtnxRT_J@aurel32.net>

Hi Aurelien,

On 12:13 Thu 30 Jul     , Aurelien Jarno wrote:
> Hi Yixun,
> 
> On 2026-07-30 08:54, Yixun Lan wrote:
> > Hi Aurelien, 
> > 
> > 
> > On 18:00 Wed 29 Jul     , Aurelien Jarno wrote:
> > > Add support for the Milk-V Jupiter board with the M1 CPU. The M1 differs
> > > from the K1 only by its package, which provides improved cooling
> > > performance and allows it to run at up to 1.8 GHz instead of 1.6 GHz.
> > > 
> > > Add m1-opp.dtsi to define the 1.8 GHz operating point and the
> > > corresponding core voltage, based on the upstream kernel. Include it
> > > from m1-milkv-jupiter.dts. Raise the maximum buck1 voltage to 1.116V to
> > > match the new operating point.
> > > 
> > While checking the schematics, the buck1,2 provide power supply both
> > for cpu core and AVDD09 domain - check schematics page 9/25 [1]
> > 
> > the R81 is NC, so buck1,2 is actually all power supply, raise voltage will
> > result high risk to damage the chip (overvoltage of AVDD09 domain), so
> 
> Yes, both buck1 and buck2 supply the CPU core. I only raised buck1 here, 
> because it's the only one controlled by the cpu scaling, but in practice 
> I believe that configuring the PMIC as Dual-Phase Mode couple the two 
> regulator at the hardware level and only the first one need to be set. 
> See my analysis there:
> https://lore.kernel.org/spacemit/178402025712.1568061.9223355686030414906.b4-ty@b4/T/#m828e80aaf454606baafbd43e3795089ba397145f
> 
Your anylsis is correct, and that's not the problem I'm talking about..

what I mean is that more than one cumsumers to buck12, where AVDD may not
be able to tolerate high voltage, even vendor can't guarantee to run stably,
vendor kernel enable 1.8GHz as turbo-mode which won't run for long duration.

https://github.com/spacemit-com/linux-6.6/blob/k1-bl-v2.2.y/arch/riscv/boot/dts/spacemit/k1-x_opp_table.dtsi#L20

 buck1,2 |--> CPU CORE
         |--> AVDD09 (DDR, AFEAP ..)

> But I can indeed raise both values for consistency.
> 
> > a safe strategy would to test if M1 able to run at 1.8G without voltage 
> > change (still at 1.05v)?
> 
> I'll try that, but my guess is that given the vendor kernel raises the 
> voltage to 1.116V, it is actually needed.
> 
> Regards
> Aurelien
> 
> -- 
> Aurelien Jarno                          GPG: 4096R/1DDD8C9B
> aurelien@aurel32.net                     http://aurel32.net

-- 
Yixun Lan (dlan)

      reply	other threads:[~2026-07-30 11:29 UTC|newest]

Thread overview: 10+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2026-07-29 16:00 [PATCH v2 0/4] riscv: dts: spacemit: Add cpu scaling for Milk-V Jupiter Aurelien Jarno
2026-07-29 16:00 ` [PATCH v2 1/4] " Aurelien Jarno
2026-07-29 16:00 ` [PATCH v2 2/4] riscv: dts: spacemit: Add a common board dtsi for Milk-V Jupiter boards Aurelien Jarno
2026-07-29 16:00 ` [PATCH v2 3/4] dt-bindings: riscv: spacemit: add Milk-V Jupiter M1 compatible Aurelien Jarno
2026-07-30  7:26   ` Krzysztof Kozlowski
2026-07-30 10:06     ` Aurelien Jarno
2026-07-29 16:00 ` [PATCH v2 4/4] riscv: dts: spacemit: Add Milk-V Jupiter board (M1) Aurelien Jarno
2026-07-30  8:54   ` Yixun Lan
2026-07-30 10:13     ` Aurelien Jarno
2026-07-30 11:29       ` Yixun Lan [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20260730112932-GKF77474@kernel.org \
    --to=dlan@kernel.org \
    --cc=alex@ghiti.fr \
    --cc=aou@eecs.berkeley.edu \
    --cc=conor+dt@kernel.org \
    --cc=devicetree@vger.kernel.org \
    --cc=krzk+dt@kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-riscv@lists.infradead.org \
    --cc=palmer@dabbelt.com \
    --cc=pjw@kernel.org \
    --cc=robh@kernel.org \
    --cc=spacemit@lists.linux.dev \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox