From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from verein.lst.de (verein.lst.de [213.95.11.211]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 86CEC43786E for ; Thu, 30 Jul 2026 13:37:34 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=213.95.11.211 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1785418657; cv=none; b=OttE4Ahojf4Yen/R0lm76+tJnZE0HeBbLwc9WHtSYN6qj6JL57ejC8nkx7p7dWLqpYUZFOx3+NWr0CIzKUH/dKcla61dFvBQsUBqlBYdUQlAzJX2UmKo9OeQzN9JBB3i6gD/AlAXpisaPyNwXwfrqtZ4O2HmYtc0M68KzQ8ZPr8= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1785418657; c=relaxed/simple; bh=+m/A0r6osCWKOXm/rF2VycrrWB8l5W7K5wb2ByORPXQ=; h=Date:From:To:Cc:Subject:Message-ID:References:MIME-Version: Content-Type:Content-Disposition:In-Reply-To; b=LebNAV5LtX3VOLbLv9Mljb6IxSZ+SChBMJhPaexZiGQiyAah2ZfiYTVmSR/pHsHLKYlwAXckt53mivNkGFyyvEKEwkTKU4UxXFCs6IrEAFwH2AlEdCUnOvU87D5FFKrUw5Ya9BHMd9CEH2Nsj+fnX0UTqhgkn5d5YfPcz1zwfbA= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=lst.de; spf=pass smtp.mailfrom=lst.de; arc=none smtp.client-ip=213.95.11.211 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=lst.de Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=lst.de Received: by verein.lst.de (Postfix, from userid 2407) id 2BB0468BFE; Thu, 30 Jul 2026 15:37:27 +0200 (CEST) Date: Thu, 30 Jul 2026 15:37:26 +0200 From: Christoph Hellwig To: Greg Kroah-Hartman Cc: Christoph Hellwig , Keith Busch , Hari Mishal , Jens Axboe , Sagi Grimberg , Hannes Reinecke , Kanchan Joshi , Nitesh Shetty , linux-nvme@lists.infradead.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH 2/2] nvme: drop WARN_ON_ONCE on write_stream bounds check Message-ID: <20260730133726.GA2983@lst.de> References: <20260725135111.14041-1-harimishal1@gmail.com> <20260725135111.14041-3-harimishal1@gmail.com> <2026072748-unpopular-onlooker-4a2b@gregkh> <2026072849-uproar-aqua-07c3@gregkh> <20260728051838.GA20593@lst.de> <2026072834-buffoon-entwine-ed16@gregkh> <20260730114123.GB25956@lst.de> <2026073003-primp-granular-c176@gregkh> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <2026073003-primp-granular-c176@gregkh> User-Agent: Mutt/1.5.17 (2007-11-01) On Thu, Jul 30, 2026 at 03:18:21PM +0200, Greg Kroah-Hartman wrote: > On Thu, Jul 30, 2026 at 01:41:23PM +0200, Christoph Hellwig wrote: > > On Tue, Jul 28, 2026 at 08:58:00AM +0200, Greg Kroah-Hartman wrote: > > [... monster quote mostly dropped, please stick mail netiquette] > > > > but a debug setup you get what you pay for, and I'm really tired of > > > > all these totally stupid attempts to make WARN_ON the new BUG_ON. > > > > It is not, and that's for a reason. > > > > > > I'm tired of it too, but again, if this can be hit by something a user > > > does, it ends up being a DoS on the machine :( > > > > So let's kill parnic_on_warn? Or tain the kernel when it is set so > > that anyone enaling it knows they have to keep the pieces when it > > breaks? > > I know why the cloud-boxes want panic-on-warn enabled, as they are > cattle and want any potential problem to just reboot the box and keep on > going. And Samsung likes it for their billions of devices for the same > reason (it's "safe" to reboot a phone I guess...) > > So as much as I would _love_ to drop it, we seem to have real users. Then at least add a taint to make it clear to them that they are getting themselves into trouble instead of trying taking the only useful debug tool away because of bad choices of a few.