From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail-pg1-f182.google.com (mail-pg1-f182.google.com [209.85.215.182]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 7F5BC469836 for ; Thu, 30 Jul 2026 16:04:54 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.215.182 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1785427495; cv=none; b=fg4PT58BmZJ5vzuYscnZUYahUf5h2J7Z3NeX/ujEfm+Pa2f18RauAL6yNmOV+isitVEv8dH6CZ+gS5XWraJ3uoM6iLZkiPXj5Kq3/2AzTD7/Ddmoncz7oxYlq5XY+tiKtAFSydSzRVTHgFbERsc+JKxuhFQjCv4t+6Tgu4yRLzI= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1785427495; c=relaxed/simple; bh=p88XlrozqCp0s3F6xoru/MvtjflcfHotb3mOweyKOX4=; h=From:To:Cc:Subject:Date:Message-ID:In-Reply-To:References: MIME-Version; b=iZr+6fD5do74z79lhpyTXMP69zg93sBIOmk6DSwE2O+R9FRJubDlZDOEo99cg27FbK8qqjtWybvjjYLkDlqfZ7MXZvRpXYLyrQKH+RKHo2PQ0Pdzm5mPs997OEad6Aj1NFj+bQPfludi/gD2Cvmv3uMZbUzb0q+GPCHzjnjzcw8= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com; spf=pass smtp.mailfrom=gmail.com; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b=M/wxPg2I; arc=none smtp.client-ip=209.85.215.182 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=gmail.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="M/wxPg2I" Received: by mail-pg1-f182.google.com with SMTP id 41be03b00d2f7-ca5b707b78aso161100a12.0 for ; Thu, 30 Jul 2026 09:04:54 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20251104; t=1785427494; x=1786032294; darn=vger.kernel.org; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to:content-type; bh=gTi6VJL4D2x6nJ6t6S27JxQ0hh8cwm7AwOqGNxZS6p4=; b=M/wxPg2I2AQhG69R01+nJDGOzBiqu4uvIBSOMB0eEseui6hEOhgF+bE4QWVdgs+NYt cT5LN3v+OLAmkRO2YDhpFtuoMssNpVftoYXkGWeazmSfhcJymPCJQAsoZ1BitEa7WkXW xY8Sbor1TeC9UZg+jNs8R29f16klfUjEheV0KBQ+c+/z+L7FnRCUITAwSKDLopzCD7zO cpqROmUBBbtBlFUbYfr+nUJ7dkLS63A+Qb37/tk+/L6jgLKzQoPy/rMO0UYMhNKm6kcT elKdEiFHKEFh4wsCa2a6BHnVMkDJCx7B18m0jdJiiwc8koDY/fIelJbqg3ZhhnoK4zfZ P4PA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1785427494; x=1786032294; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-gg:x-gm-message-state:from :to:cc:subject:date:message-id:reply-to:content-type; bh=gTi6VJL4D2x6nJ6t6S27JxQ0hh8cwm7AwOqGNxZS6p4=; b=PIpyGLIJMTFV8dg5e0uHhqKY3OfIlpmu9uahof78bYprJ2r9tJpMV5PSCEGCcfi9wR sVDXIHCi6ky473TwmzK4s81wxxXDwG4tiIvbUQNqes3pVlfF2/8SnIXGRqUKoEaOWClj e/QjllKrB1WJSkCXpT4cHjK0cMeZ5GH1+yLqks2rl9Y6NoY+jjOhNTwq95jBbNA6cGEP Sgp5yBKRs5peu/BjEpwOUDGjPYdHnRsxxKLxTxBkIo2opzsSb3EMIr8gb4iFobQGl5ll 6UNSm+o0xNTHe73ZJ9WG37a2kLx2AG5X/oWqeUw+v5FNPaOVkUCZT/9hk++tWCSp6Ro3 XKYQ== X-Forwarded-Encrypted: i=1; AHgh+RrAQkf7xRvSYIhifRlb3aI3n1Gth21XK9ju+i0dLvu/mtA5zVlmzXpKD0sMeHgVuHrzavrptBtesg2LY0A=@vger.kernel.org X-Gm-Message-State: AOJu0YwjPqNGy65pveetTqiEyEOrvY3FCdhA5p43YGvORxEpEZqP2foo MP981/Aw85yZF+6ZdYumzLaZoEv2jYOlUrECu4n0RA/WJIj0GwLvsrIw X-Gm-Gg: AR+sD13qv+VKaBymJswi+MvE3AIDKzoGWsRYuBawKJvt8sraCfr8XNrfQXtKrK8rFU1 v6VDUj8QFhTeKEGnxrVVDMQXPirMKdcuXy1QvXbFu3JKwNUWPfwqGCLWy3X9g9t7MVt9dqY4903 EqKJLCYZiSlwOd45Q/wjUFcAzJSj5DPgVhbRl8MsDECHOQFaBopDuUu/7qo2ejxO2WZOQxqo6nU FqrZzT/mxj8VTtTRsZrmj93dxOivOncTVEao7bp9xTG7Iu13y13WvnaNYbLbxKNRBOAn80fgLIx vSFyhePJ+7QEP4JmPhB9SSkblA1ckAV4DdrbWLPPOlnZOWzNTY+NyMMXpem/i95I/RtGJVXZM1W jbihDCEnyR9PB3jzhjkRYIAH3gxZR+8gFNyrm7eEW/2eXbRaAI9V7DUdIyYPvKvVErfvcWUD52e DNrMqs9PPeRSQiwWcBf3v8kUnFLTG+AxuHZJWB/TxRXN5Fu3plOlYJAuh2OP3KYnTAt0+G5gezw SE= X-Received: by 2002:a17:90b:1dcc:b0:381:bcfb:e710 with SMTP id 98e67ed59e1d1-38fa8041704mr793333a91.3.1785427493649; Thu, 30 Jul 2026 09:04:53 -0700 (PDT) Received: from Potato.tail66a299.ts.net ([171.76.83.76]) by smtp.gmail.com with ESMTPSA id a92af1059eb24-13e72643a12sm35012783c88.5.2026.07.30.09.04.50 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Thu, 30 Jul 2026 09:04:53 -0700 (PDT) From: Shivesh X-Google-Original-From: Shivesh To: arend.vanspriel@broadcom.com Cc: linux-wireless@vger.kernel.org, brcm80211@lists.linux.dev, brcm80211-dev-list.pdl@broadcom.com, linux-kernel@vger.kernel.org, Shivesh Subject: [PATCH 8/8] wifi: brcmsmac: ampdu: clarify standard compliance on QoS change Date: Thu, 30 Jul 2026 16:03:56 +0000 Message-ID: <20260730160425.11933-8-shivesh@example.com> X-Mailer: git-send-email 2.53.0 In-Reply-To: <20260730160425.11933-1-shivesh@example.com> References: <20260730160425.11933-1-shivesh@example.com> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: 8bit Updates XXX comment to properly reference IEEE 802.11n requirements that all MPDUs in an A-MPDU must share the same TID. Signed-off-by: Shivesh --- .../net/wireless/broadcom/brcm80211/brcmsmac/ampdu.c | 11 +++++------ 1 file changed, 5 insertions(+), 6 deletions(-) diff --git a/drivers/net/wireless/broadcom/brcm80211/brcmsmac/ampdu.c b/drivers/net/wireless/broadcom/brcm80211/brcmsmac/ampdu.c index fc7a5dd2e5d8..3fd8bdbd35e5 100644 --- a/drivers/net/wireless/broadcom/brcm80211/brcmsmac/ampdu.c +++ b/drivers/net/wireless/broadcom/brcm80211/brcmsmac/ampdu.c @@ -516,12 +516,11 @@ int brcms_c_ampdu_add_frame(struct brcms_ampdu_session *session, return -ENOSPC; /* - * We aren't really out of space if the new frame is of - * a different priority, but we want the same behaviour - * so return -ENOSPC anyway. - * - * XXX: The old AMPDU code did this, but is it really - * necessary? + * IEEE 802.11n standard requires that all MPDUs within an + * A-MPDU belong to the same TID (Traffic Identifier). + * Since priority maps to TID, a different priority means + * we must close the current aggregate and start a new one, + * so we return -ENOSPC here. */ first = skb_peek(&session->skb_list); if (p->priority != first->priority) -- 2.53.0