From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.129.124]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id E178D3EC81F for ; Thu, 30 Jul 2026 22:59:12 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=170.10.129.124 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1785452354; cv=none; b=Vq8Uh8IGG82oaDZtUuaeUYxSEEKWUm+tvY5PNsPzAmILEg40hKOi4OuCAsuRjZQC3E3JlYZgkKBqqaw/Uv3O+9ZWV5cI4EHZp6NA1u+kchIlLbaHxV3Zx571OBZCex6ICngIWNxG0cw40xGt5KjZcZVUZ6fIISuVS1v2R17Vei0= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1785452354; c=relaxed/simple; bh=wpO1t/7FGPKrcFhoNcA92Vi0PmjZQCcIGe0oiSegWrs=; h=Date:From:To:Cc:Subject:Message-ID:References:MIME-Version: Content-Type:Content-Disposition:In-Reply-To; b=L0JgzDYMWhwGbW9BbHbv8ZRhwVlrfXcHzj3mp1PE2yPU7I4vFIk6m2xY3k+Mc+Txm1SF+lo4tJdyj7qXp74RYpUxZAMSPRfDv8cAcDrHs7JTzmLaqvPzqxCS13SdM/AhssSAgjS4k1OYfn4UJDzZinJDadQrV0d+mHrglb9k/Y4= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=quarantine dis=none) header.from=redhat.com; spf=pass smtp.mailfrom=redhat.com; dkim=pass (1024-bit key) header.d=redhat.com header.i=@redhat.com header.b=Fi55ukzW; dkim=pass (2048-bit key) header.d=redhat.com header.i=@redhat.com header.b=XSo1hEXO; arc=none smtp.client-ip=170.10.129.124 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=quarantine dis=none) header.from=redhat.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=redhat.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (1024-bit key) header.d=redhat.com header.i=@redhat.com header.b="Fi55ukzW"; dkim=pass (2048-bit key) header.d=redhat.com header.i=@redhat.com header.b="XSo1hEXO" DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1785452351; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=Sx+8dGfrU/EPbcECFTxS2R77qIQIIRmUdLHbVGAEsZE=; b=Fi55ukzWXCfYPyKkSwjq7yoOpwg6GK0bpfmBmNTapmzOIEssGr1x+s1e/5an3MG7PaSvyk 5gNiwsLyFxOCZk1l011GGeJCLk62Igea+UdQ0J+ul5UEoILyJp0klShNh8m6wllp8nbcdY ocUXVpF9IBREiEzzaPVPPcRzjeXf7Ac= Received: from mail-wm1-f72.google.com (mail-wm1-f72.google.com [209.85.128.72]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_256_GCM_SHA384) id us-mta-543-qVvUW0mXNc-Ca4qKOcLWPg-1; Thu, 30 Jul 2026 18:59:08 -0400 X-MC-Unique: qVvUW0mXNc-Ca4qKOcLWPg-1 X-Mimecast-MFC-AGG-ID: qVvUW0mXNc-Ca4qKOcLWPg_1785452347 Received: by mail-wm1-f72.google.com with SMTP id 5b1f17b1804b1-4955ce558d8so1784805e9.3 for ; Thu, 30 Jul 2026 15:59:07 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=google; t=1785452347; x=1786057147; darn=vger.kernel.org; h=in-reply-to:content-disposition:content-type:mime-version :references:message-id:subject:cc:to:from:date:from:to:cc:subject :date:message-id:reply-to:content-type; bh=Sx+8dGfrU/EPbcECFTxS2R77qIQIIRmUdLHbVGAEsZE=; b=XSo1hEXOb3LtKVNxsec/0HaM3v/PCGYYphLYn3mS0cAteWMTyMZ3SFA4G8E9af7GBP WiM7cNqAwP2b3kOgGdrwAhfkukyapsm/189bXSJL4tkMeGFlkPanRxHyQ3iJc3bA1RIy lam0FQQefX8nG8lpRdjSrRpMPqaam7aarbi051z7FSSztYF+atKRr0spaJNxDxQqSjiK tHMEbT/zglU6wZTUptL7mrKYIW8pH9em4pqVVTgR+kzWMGE+UvVhZWBqa1MJRcOUMc5g TWtXk/6U5Vh18Q3ZFyDHAs/iQZrF9jgryJgRjmMYNHiDGLW6J1V1ygHCKCS/Evd9RSqc PvTA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1785452347; x=1786057147; h=in-reply-to:content-disposition:content-type:mime-version :references:message-id:subject:cc:to:from:date:x-gm-gg :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to :content-type; bh=Sx+8dGfrU/EPbcECFTxS2R77qIQIIRmUdLHbVGAEsZE=; b=iws8XLh9UHfiKSZPjA4vtCMoaqDg46rXkL+A1ud/8GNSKcpPtfFdLh5reiMPNo8WLS 7WgqajrnQMPbBBGq0XELVZNjMWS18FcG9rLxpDUN2BDxNIEgKkGU0QXzoAFJrIZkEhQv /8QHD6Dbjw0JmzxyB8yJjvbX6cgsXDPPdSZ8VUTBcBCzis1x9W4tBOvETlcvlrRDrfF3 ymhBZEj8FMZxEltvQIAAqe9fqIJvST4T/pJRelV+NWYiwxBrhgt6BkKi/uHtF0JR6j2b 7NaWhv7ZYjVBZy9C1cLNmA1FdbcN4qny3W7r+6y8mngfaFjItfKz9Ug/CI+x0vJK2WrM UL4w== X-Forwarded-Encrypted: i=1; AHgh+RpWrXtfQs95AvctLfFzNWM6HmmRcO5mExtJoZTbBL/iQnb2ofuGc5ZgBD09Gx6rqvSxP6WwSxVzuE6bogI=@vger.kernel.org X-Gm-Message-State: AOJu0Yx6XQP1VvlQS2KvAbXEzDSMDY9Rf7FQlRCBV5Ddnf04HvWwTUnG eT+7w6d5feK1KFuOVQuZ0I8nomiElBE1PWfh4cIdK51/S5zEhdgS8mDqwb6gj0v493AnarUP6be TJstK8Ur5LEyBoXlykFCKcxjFNyyznqo4WO5YZ1eip62vzdmymugLa5ES+qpLz4/X4A== X-Gm-Gg: AR+sD13OWnSsantN8Ta7oMZGIMGd3kN6icHS2cX9LDrwH6nWWvfGzOX7ed7x8UvWb+d Pr7qJaqDThR+hZzYXqdZrnBzXLDdBt3ZVE/+MPT7M8Wnd8vMcM3EUDeAVL3TZBGJa+joaCqWxwQ tGvZ0QhZwpK4jUlLtCwxcaU2c/FguUjQPgNj6Rmf3x4sDbBZc+Hu+lUhfH8SetzKxp0wG/J0agu 1dhNq2g6l1OSW2yUyX9pqJ5CkGVls2zJhFfhIqXanIdpP6ViDW/vfBkTvgQrn0Pty6NuSmBBCpd YW9+OTOfU2YZH3Ro/g5P1VQjc/L7wSMu8dIMofKNBbDVjOln2rjuJNbYER0ugx7BgpcMukRLDmI L7YnXN6UBzibGSuDOKAPALlM= X-Received: by 2002:a05:600c:1d15:b0:498:490:3bbe with SMTP id 5b1f17b1804b1-49804903c27mr34934975e9.16.1785452346896; Thu, 30 Jul 2026 15:59:06 -0700 (PDT) X-Received: by 2002:a05:600c:1d15:b0:498:490:3bbe with SMTP id 5b1f17b1804b1-49804903c27mr34934755e9.16.1785452346444; Thu, 30 Jul 2026 15:59:06 -0700 (PDT) Received: from redhat.com (ppp-94-66-118-61.home.otenet.gr. [94.66.118.61]) by smtp.gmail.com with ESMTPSA id 5b1f17b1804b1-49800f1a91fsm89806315e9.6.2026.07.30.15.59.04 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Thu, 30 Jul 2026 15:59:05 -0700 (PDT) Date: Thu, 30 Jul 2026 18:59:02 -0400 From: "Michael S. Tsirkin" To: Christian Brauner Cc: Octavian Purdila , netdev@vger.kernel.org, Alexander Viro , Andrew Morton , Arseniy Krasnov , "David S. Miller" , Eric Dumazet , Eugenio =?iso-8859-1?Q?P=E9rez?= , Jakub Kicinski , Jason Wang , kvm@vger.kernel.org, linux-block@vger.kernel.org, linux-fsdevel@vger.kernel.org, linux-kernel@vger.kernel.org, Paolo Abeni , Simon Horman , Stefan Hajnoczi , Stefano Garzarella , virtualization@lists.linux.dev, Xuan Zhuo , Jens Axboe Subject: Re: [PATCH net v3 1/2] iov_iter: export iov_iter_restore Message-ID: <20260730185844-mutt-send-email-mst@kernel.org> References: <20260622222757.2130402-1-tavip@google.com> <20260622222757.2130402-2-tavip@google.com> <20260625-erstbesteigung-mundschutz-invalide-3b0d4cd4cbc9@brauner> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20260625-erstbesteigung-mundschutz-invalide-3b0d4cd4cbc9@brauner> On Thu, Jun 25, 2026 at 12:43:18PM +0200, Christian Brauner wrote: > > Export iov_iter_restore so that it can be used by modules. > > > > This is needed by the virtio vsock transport (which can be built as a > > module) to restore the msg_iter state when transmission fails. > > > > Acked-by: Stefano Garzarella > > Signed-off-by: Octavian Purdila > > > > diff --git a/lib/iov_iter.c b/lib/iov_iter.c > > index 273919b16161..f5df63961fb2 100644 > > --- a/lib/iov_iter.c > > +++ b/lib/iov_iter.c > > @@ -1491,6 +1491,7 @@ void iov_iter_restore(struct iov_iter *i, struct iov_iter_state *state) > > i->__iov -= state->nr_segs - i->nr_segs; > > i->nr_segs = state->nr_segs; > > } > > +EXPORT_SYMBOL_GPL(iov_iter_restore); > > At least only export it for the module that really needs it. For > example, see: > > EXPORT_SYMBOL_FOR_MODULES(__kernel_write, "autofs4"); > > -- > Christian Brauner Octavian, you wanna try?